Correct extraction of namespace and name from path

2026-02-23 06:50:49 +01:00 · 2018-09-10 08:37:31 +02:00
parent 9198cac0a5
commit 6d659b8ac1
4 changed files with 241 additions and 35 deletions
--- a/scm-webapp/src/test/java/sonia/scm/web/protocol/HttpProtocolServletTest.java
+++ b/scm-webapp/src/test/java/sonia/scm/web/protocol/HttpProtocolServletTest.java
@@ -0,0 +1,124 @@
+package sonia.scm.web.protocol;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import sonia.scm.PushStateDispatcher;
+import sonia.scm.repository.DefaultRepositoryProvider;
+import sonia.scm.repository.NamespaceAndName;
+import sonia.scm.repository.Repository;
+import sonia.scm.repository.RepositoryNotFoundException;
+import sonia.scm.repository.api.RepositoryService;
+import sonia.scm.repository.api.RepositoryServiceFactory;
+import sonia.scm.repository.spi.HttpScmProtocol;
+import sonia.scm.web.UserAgent;
+import sonia.scm.web.UserAgentParser;
+
+import javax.inject.Provider;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.IOException;
+import java.util.Optional;
+
+import static java.util.Optional.of;
+import static org.mockito.AdditionalMatchers.not;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+import static org.mockito.MockitoAnnotations.initMocks;
+
+public class HttpProtocolServletTest {
+
+  private static final NamespaceAndName EXISTING_REPO = new NamespaceAndName("space", "repo");
+
+  @Mock
+  private RepositoryServiceFactory serviceFactory;
+  @Mock
+  private HttpServletRequest httpServletRequest;
+  @Mock
+  private PushStateDispatcher dispatcher;
+  @Mock
+  private UserAgentParser userAgentParser;
+  @Mock
+  private NamespaceAndNameFromPathExtractor namespaceAndNameFromPathExtractor;
+  @Mock
+  private Provider<HttpServletRequest> requestProvider;
+
+  @InjectMocks
+  private HttpProtocolServlet servlet;
+
+  @Mock
+  private RepositoryService repositoryService;
+  @Mock
+  private UserAgent userAgent;
+
+  @Mock
+  private HttpServletRequest request;
+  @Mock
+  private HttpServletResponse response;
+  @Mock
+  private HttpScmProtocol protocol;
+
+  @Before
+  public void init() throws RepositoryNotFoundException {
+    initMocks(this);
+    when(userAgentParser.parse(request)).thenReturn(userAgent);
+    when(userAgent.isBrowser()).thenReturn(false);
+    when(serviceFactory.create(not(eq(EXISTING_REPO)))).thenThrow(RepositoryNotFoundException.class);
+    when(serviceFactory.create(EXISTING_REPO)).thenReturn(repositoryService);
+    when(requestProvider.get()).thenReturn(httpServletRequest);
+  }
+
+  @Test
+  public void shouldDispatchBrowserRequests() throws ServletException, IOException {
+    when(userAgent.isBrowser()).thenReturn(true);
+    when(request.getRequestURI()).thenReturn("uri");
+
+    servlet.service(request, response);
+
+    verify(dispatcher).dispatch(request, response, "uri");
+  }
+
+  @Test
+  public void shouldHandleBadPaths() throws IOException, ServletException {
+    when(request.getPathInfo()).thenReturn("/space/name");
+    when(namespaceAndNameFromPathExtractor.fromUri("/space/name")).thenReturn(Optional.empty());
+
+    servlet.service(request, response);
+
+    verify(response).setStatus(400);
+  }
+
+  @Test
+  public void shouldHandleNotExistingRepository() throws RepositoryNotFoundException, IOException, ServletException {
+    when(request.getPathInfo()).thenReturn("/space/name");
+    NamespaceAndName namespaceAndName = new NamespaceAndName("space", "name");
+    when(namespaceAndNameFromPathExtractor.fromUri("/space/name")).thenReturn(of(namespaceAndName));
+    doThrow(new RepositoryNotFoundException(namespaceAndName)).when(serviceFactory).create(namespaceAndName);
+
+    servlet.service(request, response);
+
+    verify(response).setStatus(404);
+  }
+
+  @Test
+  public void shouldDelegateToProvider() throws RepositoryNotFoundException, IOException, ServletException {
+    when(request.getPathInfo()).thenReturn("/space/name");
+    NamespaceAndName namespaceAndName = new NamespaceAndName("space", "name");
+    when(namespaceAndNameFromPathExtractor.fromUri("/space/name")).thenReturn(of(namespaceAndName));
+    doReturn(repositoryService).when(serviceFactory).create(namespaceAndName);
+    Repository repository = new Repository();
+    when(repositoryService.getRepository()).thenReturn(repository);
+    when(repositoryService.getProtocol(HttpScmProtocol.class)).thenReturn(protocol);
+
+    servlet.service(request, response);
+
+    verify(httpServletRequest).setAttribute(DefaultRepositoryProvider.ATTRIBUTE_NAME, repository);
+    verify(protocol).serve(request, response, null);
+    verify(repositoryService).close();
+  }
+}