Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-05-07 02:26:23 +02:00
Code Issues Packages Projects Releases Activity

Reduce code smells (#2089)

Browse Source 
Reduce code smells found by deepsource.io. We focused on the low-hanging fruits and not breaking any api.
This commit is contained in:
Eduard Heimbuch
2022-07-15 15:33:37 +02:00
committed by GitHub
parent f61d0c113f
commit 67c083ee54
15 changed files with 149 additions and 443 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scm-it/src/test/java/sonia/scm/it/utils/RepositoryUtil.java
View File

@@ -21,7 +21,7 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
package sonia.scm.it.utils;
import com.google.common.base.Charsets;
@@ -92,11 +92,11 @@ public class RepositoryUtil {
* @throws IOException
*/
public static Changeset commitMultipleFileModifications(RepositoryClient repositoryClient, String username, Map<String, String> addedFiles, Map<String, String> modifiedFiles, List<String> removedFiles) throws IOException {
for (String fileName : addedFiles.keySet()) {
writeAndAddFile(repositoryClient, fileName, addedFiles.get(fileName));
for (Map.Entry<String,String> entry : addedFiles.entrySet()) {
writeAndAddFile(repositoryClient, entry.getKey(), entry.getValue());
}
for (String fileName : modifiedFiles.keySet()) {
writeAndAddFile(repositoryClient, fileName, modifiedFiles.get(fileName));
for (Map.Entry<String,String> entry : modifiedFiles.entrySet()) {
writeAndAddFile(repositoryClient, entry.getKey(), entry.getValue());
}
for (String fileName : removedFiles) {
deleteFileAndApplyRemoveCommand(repositoryClient, fileName);