From 66887db4476a798bea2aaeb78c1e12dfaa3b7ee1 Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Sat, 16 Jun 2012 12:27:48 +0200
Subject: [PATCH] added logging to browse command builder

---
 .../repository/api/BrowseCommandBuilder.java  | 35 +++++++++++++++++--
 1 file changed, 32 insertions(+), 3 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java b/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java
index 6ec29a7264..c46b9a9b8e 100644
--- a/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java
+++ b/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java
@@ -37,6 +37,9 @@ package sonia.scm.repository.api;
 
 import com.google.common.base.Objects;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import sonia.scm.cache.Cache;
 import sonia.scm.cache.CacheManager;
 import sonia.scm.repository.BrowserResult;
@@ -64,6 +67,12 @@ public final class BrowseCommandBuilder
   /** Name of the cache */
   private static final String CACHE_NAME = "sonia.scm.cache.browse";
 
+  /**
+   * the logger for BrowseCommandBuilder
+   */
+  private static final Logger logger =
+    LoggerFactory.getLogger(BrowseCommandBuilder.class);
+
   //~--- constructors ---------------------------------------------------------
 
   /**
@@ -119,6 +128,12 @@ public final class BrowseCommandBuilder
 
     if (disableCache)
     {
+      if (logger.isDebugEnabled())
+      {
+        logger.debug("create browser result for {} with disabled cache",
+                     request);
+      }
+
       result = browseCommand.getBrowserResult(request);
     }
     else
@@ -127,13 +142,27 @@ public final class BrowseCommandBuilder
 
       result = cache.get(key);
 
-      if (result != null)
+      if (result == null)
       {
-        cache.put(key, result);
+        if (logger.isDebugEnabled())
+        {
+          logger.debug("create browser result for {}", request);
+        }
+
+        result = browseCommand.getBrowserResult(request);
+
+        if (result != null)
+        {
+          cache.put(key, result);
+        }
+      }
+      else if (logger.isDebugEnabled())
+      {
+        logger.debug("retrive browser result from cache for {}", request);
       }
     }
 
-    if (! disablePreProcessors && result != null)
+    if (!disablePreProcessors && (result != null))
     {
       preProcessorUtil.prepareForReturn(repository, result);
     }