From 848075050cbb81bde86be364af0df878185f160b Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Fri, 5 Apr 2019 14:44:33 +0200 Subject: [PATCH 1/2] fixed mailto url scheme according to rfc2368 --- .../packages/ui-components/src/MailLink.js | 2 +- .../src/repos/changesets/ChangesetAuthor.js | 11 +++++++---- scm-ui/src/users/components/table/UserRow.js | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/scm-ui-components/packages/ui-components/src/MailLink.js b/scm-ui-components/packages/ui-components/src/MailLink.js index 7d009cde85..e18264e85c 100644 --- a/scm-ui-components/packages/ui-components/src/MailLink.js +++ b/scm-ui-components/packages/ui-components/src/MailLink.js @@ -11,7 +11,7 @@ class MailLink extends React.Component { if (!address) { return null; } - return {address}; + return {address}; } } diff --git a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetAuthor.js b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetAuthor.js index 4035cbd899..b240bc1af2 100644 --- a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetAuthor.js +++ b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetAuthor.js @@ -2,13 +2,13 @@ import React from "react"; import type { Changeset } from "@scm-manager/ui-types"; import { ExtensionPoint } from "@scm-manager/ui-extensions"; -import {translate} from "react-i18next"; +import { translate } from "react-i18next"; type Props = { changeset: Changeset, // context props - t: (string) => string + t: string => string }; class ChangesetAuthor extends React.Component { @@ -28,7 +28,10 @@ class ChangesetAuthor extends React.Component { renderWithMail(name: string, mail: string) { const { t } = this.props; return ( - + {name} ); @@ -44,7 +47,7 @@ class ChangesetAuthor extends React.Component { props={{ changeset: this.props.changeset }} renderAll={true} /> - + ); } } diff --git a/scm-ui/src/users/components/table/UserRow.js b/scm-ui/src/users/components/table/UserRow.js index 84bd1234fa..9cb55295fb 100644 --- a/scm-ui/src/users/components/table/UserRow.js +++ b/scm-ui/src/users/components/table/UserRow.js @@ -20,7 +20,7 @@ export default class UserRow extends React.Component { {this.renderLink(to, user.name)} {this.renderLink(to, user.displayName)} - {user.mail} + {user.mail} From d3b1a1b7aaf42232b5f7202e94c637e50cf7350f Mon Sep 17 00:00:00 2001 From: Rene Pfeuffer Date: Wed, 10 Apr 2019 08:50:36 +0000 Subject: [PATCH 2/2] Close branch bugfix/mailto_emptyspace