From 58798b947f0e33912e79211874ea97744d4e2686 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Tue, 4 Jan 2011 17:28:09 +0100 Subject: [PATCH] fix XmlUserManager unit tests --- .../src/main/java/sonia/scm/user/xml/XmlUserManager.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scm-webapp/src/main/java/sonia/scm/user/xml/XmlUserManager.java b/scm-webapp/src/main/java/sonia/scm/user/xml/XmlUserManager.java index 0863e12bab..e552d4c30a 100644 --- a/scm-webapp/src/main/java/sonia/scm/user/xml/XmlUserManager.java +++ b/scm-webapp/src/main/java/sonia/scm/user/xml/XmlUserManager.java @@ -164,8 +164,6 @@ public class XmlUserManager extends AbstractUserManager throw new ScmSecurityException("admin account is required"); } - AssertUtil.assertIsValid(user); - if (userDB.contains(user.getName())) { throw new UserAllreadyExistException(); @@ -178,6 +176,7 @@ public class XmlUserManager extends AbstractUserManager user.setType(TYPE); } + AssertUtil.assertIsValid(user); user.setCreationDate(System.currentTimeMillis()); synchronized (XmlUserManager.class) @@ -269,12 +268,12 @@ public class XmlUserManager extends AbstractUserManager throw new ScmSecurityException("admin account is required"); } - AssertUtil.assertIsValid(user); - String name = user.getName(); if (userDB.contains(name)) { + AssertUtil.assertIsValid(user); + synchronized (XmlUserManager.class) { userDB.remove(name);