From 575a03521f7ba7cc71dfd666ba79575ef52a2ccd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= <rene.pfeuffer@cloudogu.com>
Date: Thu, 6 Jun 2019 08:41:38 +0200
Subject: [PATCH] Fix group v1 migration with empty group database file

---
 .../update/group/XmlGroupV1UpdateStep.java    |  4 ++-
 .../sonia/scm/update/UpdateStepTestUtil.java  | 13 +++++++-
 .../group/XmlGroupV1UpdateStepTest.java       | 30 +++++++++++++++++++
 .../scm/update/group/groups_empty_groups.xml  |  6 ++++
 .../scm/update/group/groups_no_groups.xml     |  5 ++++
 5 files changed, 56 insertions(+), 2 deletions(-)
 create mode 100644 scm-webapp/src/test/resources/sonia/scm/update/group/groups_empty_groups.xml
 create mode 100644 scm-webapp/src/test/resources/sonia/scm/update/group/groups_no_groups.xml

diff --git a/scm-webapp/src/main/java/sonia/scm/update/group/XmlGroupV1UpdateStep.java b/scm-webapp/src/main/java/sonia/scm/update/group/XmlGroupV1UpdateStep.java
index 9622af0f34..7130ead4a9 100644
--- a/scm-webapp/src/main/java/sonia/scm/update/group/XmlGroupV1UpdateStep.java
+++ b/scm-webapp/src/main/java/sonia/scm/update/group/XmlGroupV1UpdateStep.java
@@ -63,7 +63,9 @@ public class XmlGroupV1UpdateStep implements UpdateStep {
       return;
     }
     XmlGroupV1UpdateStep.V1GroupDatabase v1Database = readV1Database(v1GroupsFile.get());
-    v1Database.groupList.groups.forEach(this::update);
+    if (v1Database.groupList != null && v1Database.groupList.groups != null) {
+      v1Database.groupList.groups.forEach(this::update);
+    }
   }
 
   @Override
diff --git a/scm-webapp/src/test/java/sonia/scm/update/UpdateStepTestUtil.java b/scm-webapp/src/test/java/sonia/scm/update/UpdateStepTestUtil.java
index 88b09fc086..8326e6d255 100644
--- a/scm-webapp/src/test/java/sonia/scm/update/UpdateStepTestUtil.java
+++ b/scm-webapp/src/test/java/sonia/scm/update/UpdateStepTestUtil.java
@@ -47,6 +47,12 @@ private final SCMContextProvider contextProvider;
     copyTestDatabaseFile(configDir, fileName);
   }
 
+  public void copyConfigFile(String fileName, String targetFileName) throws IOException {
+    Path configDir = tempDir.resolve("config");
+    Files.createDirectories(configDir);
+    copyTestDatabaseFile(configDir, fileName, targetFileName);
+  }
+
   public ConfigurationEntryStore<AssignedPermission> getStoreForConfigFile(String name) {
     return storeFactory
       .withType(AssignedPermission.class)
@@ -59,7 +65,12 @@ private final SCMContextProvider contextProvider;
   }
 
   private void copyTestDatabaseFile(Path configDir, String fileName) throws IOException {
+    Path targetFileName = Paths.get(fileName).getFileName();
+    copyTestDatabaseFile(configDir, fileName, targetFileName.toString());
+  }
+
+  private void copyTestDatabaseFile(Path configDir, String fileName, String targetFileName) throws IOException {
     URL url = Resources.getResource(fileName);
-    Files.copy(url.openStream(), configDir.resolve(Paths.get(fileName).getFileName()));
+    Files.copy(url.openStream(), configDir.resolve(targetFileName));
   }
 }
diff --git a/scm-webapp/src/test/java/sonia/scm/update/group/XmlGroupV1UpdateStepTest.java b/scm-webapp/src/test/java/sonia/scm/update/group/XmlGroupV1UpdateStepTest.java
index 394dc44109..6dee5fd5c1 100644
--- a/scm-webapp/src/test/java/sonia/scm/update/group/XmlGroupV1UpdateStepTest.java
+++ b/scm-webapp/src/test/java/sonia/scm/update/group/XmlGroupV1UpdateStepTest.java
@@ -99,6 +99,36 @@ class XmlGroupV1UpdateStepTest {
     }
   }
 
+  @Nested
+  class WithExistingDatabaseWithEmptyList {
+
+    @BeforeEach
+    void createGroupV1XML() throws IOException {
+      testUtil.copyConfigFile("sonia/scm/update/group/groups_empty_groups.xml", "groups.xml");
+    }
+
+    @Test
+    void shouldCreateNewGroupFromGroupsV1Xml() throws JAXBException {
+      updateStep.doUpdate();
+      verify(groupDAO, times(0)).add(any());
+    }
+  }
+
+  @Nested
+  class WithExistingDatabaseWithoutList {
+
+    @BeforeEach
+    void createGroupV1XML() throws IOException {
+      testUtil.copyConfigFile("sonia/scm/update/group/groups_no_groups.xml", "groups.xml");
+    }
+
+    @Test
+    void shouldCreateNewGroupFromGroupsV1Xml() throws JAXBException {
+      updateStep.doUpdate();
+      verify(groupDAO, times(0)).add(any());
+    }
+  }
+
   @Test
   void shouldNotFailForMissingConfigDir() throws JAXBException {
     updateStep.doUpdate();
diff --git a/scm-webapp/src/test/resources/sonia/scm/update/group/groups_empty_groups.xml b/scm-webapp/src/test/resources/sonia/scm/update/group/groups_empty_groups.xml
new file mode 100644
index 0000000000..c5f82daaa6
--- /dev/null
+++ b/scm-webapp/src/test/resources/sonia/scm/update/group/groups_empty_groups.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<group-db>
+    <creationTime>1558006904769</creationTime>
+    <groups/>
+    <lastModified>1558007174172</lastModified>
+</group-db>
diff --git a/scm-webapp/src/test/resources/sonia/scm/update/group/groups_no_groups.xml b/scm-webapp/src/test/resources/sonia/scm/update/group/groups_no_groups.xml
new file mode 100644
index 0000000000..8014b299cc
--- /dev/null
+++ b/scm-webapp/src/test/resources/sonia/scm/update/group/groups_no_groups.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<group-db>
+    <creationTime>1558006904769</creationTime>
+    <lastModified>1558007174172</lastModified>
+</group-db>