From 53147db0e20b5555b4dd2228d2c88cd0bc14b879 Mon Sep 17 00:00:00 2001
From: Florian Scholdei <florian.scholdei@cloudogu.com>
Date: Thu, 28 Nov 2019 02:01:49 +0100
Subject: [PATCH] Move button to right side and small fixes

---
 .../components/PermissionRoleDetails.tsx      | 10 ++++--
 .../repos/components/form/RepositoryForm.tsx  |  2 +-
 .../sources/containers/SourceExtensions.tsx   | 31 ++++++++++---------
 3 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/scm-ui/ui-webapp/src/admin/roles/components/PermissionRoleDetails.tsx b/scm-ui/ui-webapp/src/admin/roles/components/PermissionRoleDetails.tsx
index e4a2a0f05c..f6e0bf35d6 100644
--- a/scm-ui/ui-webapp/src/admin/roles/components/PermissionRoleDetails.tsx
+++ b/scm-ui/ui-webapp/src/admin/roles/components/PermissionRoleDetails.tsx
@@ -2,7 +2,7 @@ import React from "react";
 import { WithTranslation, withTranslation } from "react-i18next";
 import { ExtensionPoint } from "@scm-manager/ui-extensions";
 import { RepositoryRole } from "@scm-manager/ui-types";
-import { Button } from "@scm-manager/ui-components";
+import { Level, Button } from "@scm-manager/ui-components";
 import PermissionRoleDetailsTable from "./PermissionRoleDetailsTable";
 
 type Props = WithTranslation & {
@@ -14,7 +14,12 @@ class PermissionRoleDetails extends React.Component<Props> {
   renderEditButton() {
     const { t, url } = this.props;
     if (!!this.props.role._links.update) {
-      return <Button label={t("repositoryRole.editButton")} link={`${url}/edit`} color="primary" />;
+      return (
+        <>
+          <hr />
+          <Level right={<Button label={t("repositoryRole.editButton")} link={`${url}/edit`} color="primary" />} />
+        </>
+      );
     }
     return null;
   }
@@ -25,7 +30,6 @@ class PermissionRoleDetails extends React.Component<Props> {
     return (
       <>
         <PermissionRoleDetailsTable role={role} />
-        <hr />
         {this.renderEditButton()}
         <ExtensionPoint
           name="repositoryRole.role-details.information"
diff --git a/scm-ui/ui-webapp/src/repos/components/form/RepositoryForm.tsx b/scm-ui/ui-webapp/src/repos/components/form/RepositoryForm.tsx
index a99fc14524..37fd072880 100644
--- a/scm-ui/ui-webapp/src/repos/components/form/RepositoryForm.tsx
+++ b/scm-ui/ui-webapp/src/repos/components/form/RepositoryForm.tsx
@@ -52,7 +52,7 @@ class RepositoryForm extends React.Component<Props, State> {
     }
   }
 
-  isFalsy(value) {
+  isFalsy(value: string) {
     return !value;
   }
 
diff --git a/scm-ui/ui-webapp/src/repos/sources/containers/SourceExtensions.tsx b/scm-ui/ui-webapp/src/repos/sources/containers/SourceExtensions.tsx
index c75b0106a9..2ea57a65ba 100644
--- a/scm-ui/ui-webapp/src/repos/sources/containers/SourceExtensions.tsx
+++ b/scm-ui/ui-webapp/src/repos/sources/containers/SourceExtensions.tsx
@@ -7,24 +7,25 @@ import { fetchSources, getFetchSourcesFailure, getSources, isFetchSourcesPending
 import { connect } from "react-redux";
 import { Loading, ErrorNotification } from "@scm-manager/ui-components";
 import Notification from "@scm-manager/ui-components/src/Notification";
-import {WithTranslation, withTranslation} from "react-i18next";
+import { WithTranslation, withTranslation } from "react-i18next";
 
-type Props = WithTranslation & RouteComponentProps & {
-  repository: Repository;
+type Props = WithTranslation &
+  RouteComponentProps & {
+    repository: Repository;
 
-  // url params
-  extension: string;
-  revision?: string;
-  path?: string;
+    // url params
+    extension: string;
+    revision?: string;
+    path?: string;
 
-  // redux state
-  loading: boolean;
-  error?: Error | null;
-  sources?: File | null;
+    // redux state
+    loading: boolean;
+    error?: Error | null;
+    sources?: File | null;
 
-  // dispatch props
-  fetchSources: (repository: Repository, revision: string, path: string) => void;
-};
+    // dispatch props
+    fetchSources: (repository: Repository, revision: string, path: string) => void;
+  };
 
 const extensionPointName = "repos.sources.extensions";
 
@@ -32,7 +33,7 @@ class SourceExtensions extends React.Component<Props> {
   componentDidMount() {
     const { fetchSources, repository, revision, path } = this.props;
     // TODO get typing right
-    fetchSources(repository,revision || "", path || "");
+    fetchSources(repository, revision || "", path || "");
   }
 
   render() {