From 4f4ab9cad419f9cea5b22bcffa088a2d35a4d2fc Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Mon, 19 Oct 2020 15:18:35 +0200
Subject: [PATCH] new user created by SyncingRealmHelper are always external

---
 .../src/main/java/sonia/scm/security/SyncingRealmHelper.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/scm-core/src/main/java/sonia/scm/security/SyncingRealmHelper.java b/scm-core/src/main/java/sonia/scm/security/SyncingRealmHelper.java
index 0f60569b8f..7b8d82f557 100644
--- a/scm-core/src/main/java/sonia/scm/security/SyncingRealmHelper.java
+++ b/scm-core/src/main/java/sonia/scm/security/SyncingRealmHelper.java
@@ -148,7 +148,10 @@ public final class SyncingRealmHelper {
         }
       } else {
         try {
-          userManager.create(user);
+          User clone = user.clone();
+          // New user created by syncing realm helper is always external
+          clone.setExternal(true);
+          userManager.create(clone);
         } catch (AlreadyExistsException e) {
           throw new IllegalStateException("got AlreadyExistsException though user " + user.getName() + " could not be loaded", e);