From 46132585e8861de45d74d96aa3c0504739e2d954 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maren=20S=C3=BCwer?= <maren.suewer@cloudogu.com>
Date: Fri, 7 Sep 2018 10:04:42 +0200
Subject: [PATCH] add check if links exists in order to update permissions
 directly before fetching

---
 scm-ui/src/permissions/containers/SinglePermission.js | 2 +-
 scm-ui/src/permissions/modules/permissions.js         | 6 +++---
 scm-ui/src/permissions/modules/permissions.test.js    | 5 +++--
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/scm-ui/src/permissions/containers/SinglePermission.js b/scm-ui/src/permissions/containers/SinglePermission.js
index 76216eae3e..58525f1090 100644
--- a/scm-ui/src/permissions/containers/SinglePermission.js
+++ b/scm-ui/src/permissions/containers/SinglePermission.js
@@ -90,7 +90,7 @@ class SinglePermission extends React.Component<Props, State> {
   render() {
     const { permission } = this.state;
     const { loading, error, namespace, repoName } = this.props;
-    const typeSelector = this.props.permission._links.update ? (
+    const typeSelector = this.props.permission._links && this.props.permission._links.update ? (
       <td>
         <TypeSelector
           handleTypeChange={this.handleTypeChange}
diff --git a/scm-ui/src/permissions/modules/permissions.js b/scm-ui/src/permissions/modules/permissions.js
index 4cb55b9b2b..1460228bff 100644
--- a/scm-ui/src/permissions/modules/permissions.js
+++ b/scm-ui/src/permissions/modules/permissions.js
@@ -424,8 +424,8 @@ export default function reducer(
         }
       };
     case CREATE_PERMISSION_SUCCESS:
-      return state;
-    /*  const position = action.payload.position;
+      // return state;
+      const position = action.payload.position;
       const permissions = state[action.payload.position].entries;
       permissions.push(action.payload.permission);
       return {
@@ -434,7 +434,7 @@ export default function reducer(
           ...state[position],
           entries: permissions
         }
-      };*/
+      };
     case DELETE_PERMISSION_SUCCESS:
       const permissionPosition = action.payload.position;
       const new_Permissions = deletePermissionFromState(
diff --git a/scm-ui/src/permissions/modules/permissions.test.js b/scm-ui/src/permissions/modules/permissions.test.js
index 8d5a0a8ad6..0d12b58346 100644
--- a/scm-ui/src/permissions/modules/permissions.test.js
+++ b/scm-ui/src/permissions/modules/permissions.test.js
@@ -471,7 +471,8 @@ describe("permissions reducer", () => {
     );
   });
 
-  /*it("should add permission", () => { //changing state had to be removed because of errors
+  it("should add permission", () => {
+    //changing state had to be removed because of errors
     const oldState = {
       "hitchhiker/puzzle42": {
         entries: [hitchhiker_puzzle42Permission_user_eins]
@@ -496,7 +497,7 @@ describe("permissions reducer", () => {
     expect(newState["hitchhiker/puzzle42"]).toEqual(
       expectedState["hitchhiker/puzzle42"]
     );
-  });*/
+  });
 });
 
 describe("permissions selectors", () => {