diff --git a/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java b/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java index f1f09521b7..d81c806471 100644 --- a/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java +++ b/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java @@ -318,7 +318,7 @@ public class DefaultAdvancedHttpClientTest } @Test - public void shouldNotTraceRequestIfUntracedResponseCode() throws IOException { + public void shouldNotTraceRequestIfAcceptedResponseCode() throws IOException { when(connection.getResponseCode()).thenReturn(400); new AdvancedHttpRequest(client, HttpMethod.GET, "https://www.scm-manager.org").acceptStatusCodes(400).request(); @@ -328,6 +328,17 @@ public class DefaultAdvancedHttpClientTest verify(span).close(); } + @Test + public void shouldTraceRequestAsFailedIfAcceptedResponseCodeDoesntMatch() throws IOException { + when(connection.getResponseCode()).thenReturn(401); + + new AdvancedHttpRequest(client, HttpMethod.GET, "https://www.scm-manager.org").acceptStatusCodes(400).request(); + verify(tracer).span("HTTP Request"); + verify(span).label("status", 401); + verify(span).failed(); + verify(span).close(); + } + //~--- set methods ----------------------------------------------------------