From 3ea55c34226fba38b11c41424c5dc1dd5ab451c1 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Mon, 10 Aug 2020 08:53:49 +0200 Subject: [PATCH] Fix small SonarQube findings --- .../main/java/sonia/scm/repository/spi/AbstractGitCommand.java | 1 - .../src/main/java/sonia/scm/repository/spi/GitLogComputer.java | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/AbstractGitCommand.java b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/AbstractGitCommand.java index 28f0f72b8b..9e13e82971 100644 --- a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/AbstractGitCommand.java +++ b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/AbstractGitCommand.java @@ -41,7 +41,6 @@ import org.eclipse.jgit.transport.PushResult; import org.eclipse.jgit.transport.RemoteRefUpdate; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import sonia.scm.repository.GitUtil; import sonia.scm.repository.GitWorkingCopyFactory; import sonia.scm.repository.InternalRepositoryException; import sonia.scm.repository.Person; diff --git a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitLogComputer.java b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitLogComputer.java index b8c31045d8..eae8ea5851 100644 --- a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitLogComputer.java +++ b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitLogComputer.java @@ -38,7 +38,6 @@ import org.eclipse.jgit.treewalk.filter.PathFilter; import org.eclipse.jgit.treewalk.filter.TreeFilter; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import sonia.scm.ContextEntry; import sonia.scm.NotFoundException; import sonia.scm.repository.Changeset; import sonia.scm.repository.ChangesetPagingResult; @@ -171,7 +170,7 @@ public class GitLogComputer { } else { LOG.debug("the repository with id {} seems to be empty", this.repositoryId); - return new ChangesetPagingResult(0, Collections.EMPTY_LIST); + return new ChangesetPagingResult(0, Collections.emptyList()); } } catch (MissingObjectException e) { throw notFound(entity(GitLogCommand.REVISION, e.getObjectId().getName()).in(sonia.scm.repository.Repository.class, repositoryId));