From 3d97e7952489682ec64964cf239a25bc7ad93f96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= <rene.pfeuffer@cloudogu.com>
Date: Fri, 26 Feb 2021 11:23:38 +0100
Subject: [PATCH] Replace printStackTrace with correct logging

---
 .../sonia/scm/importexport/RepositoryImportLogger.java | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/scm-webapp/src/main/java/sonia/scm/importexport/RepositoryImportLogger.java b/scm-webapp/src/main/java/sonia/scm/importexport/RepositoryImportLogger.java
index 68e2103e9a..f78c26cfd7 100644
--- a/scm-webapp/src/main/java/sonia/scm/importexport/RepositoryImportLogger.java
+++ b/scm-webapp/src/main/java/sonia/scm/importexport/RepositoryImportLogger.java
@@ -25,6 +25,8 @@
 package sonia.scm.importexport;
 
 import org.apache.shiro.SecurityUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import sonia.scm.repository.Repository;
 import sonia.scm.store.Blob;
 import sonia.scm.store.BlobStore;
@@ -39,6 +41,8 @@ import static java.nio.charset.StandardCharsets.UTF_8;
 
 class RepositoryImportLogger {
 
+  private static final Logger LOG = LoggerFactory.getLogger(RepositoryImportLogger.class);
+
   private final BlobStore logStore;
   private PrintWriter print;
   private Blob blob;
@@ -67,7 +71,7 @@ class RepositoryImportLogger {
       outputStream.write(user.getId().getBytes(UTF_8));
       outputStream.write(0);
     } catch (IOException e) {
-      e.printStackTrace();
+      LOG.warn("Could not write user to import log blob", e);
     }
   }
 
@@ -75,7 +79,7 @@ class RepositoryImportLogger {
     try {
       return blob.getOutputStream();
     } catch (IOException e) {
-      e.printStackTrace();
+      LOG.warn("Could not create logger for import; failed to get output stream from blob", e);
       return new OutputStream() {
         @Override
         public void write(int b) {
@@ -109,7 +113,7 @@ class RepositoryImportLogger {
     try {
       blob.commit();
     } catch (IOException e) {
-      e.printStackTrace();
+      LOG.warn("Could not commit blob with import log", e);
     }
   }