Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-07-04 13:38:25 +02:00
Code Issues Packages Projects Releases Activity

Set update step info for new repositories (#1554)

Browse Source 
Sets versions for repository update steps to newest versions for new repositories to prevent unnecessary updates.
This commit is contained in:
René Pfeuffer
2021-02-25 08:12:16 +01:00
committed by GitHub
parent 3a8d031ed5
commit 3c94ce91d6
5 changed files with 283 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

93
scm-webapp/src/test/java/sonia/scm/update/RepositoryUpdateAfterCreationHookTest.java Normal file
View File

@@ -0,0 +1,93 @@
/*
* MIT License
*
* Copyright (c) 2020-present Cloudogu GmbH and Contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
package sonia.scm.update;
import com.google.common.collect.ImmutableSet;
import org.junit.jupiter.api.Test;
import sonia.scm.HandlerEventType;
import sonia.scm.migration.RepositoryUpdateContext;
import sonia.scm.migration.RepositoryUpdateStep;
import sonia.scm.repository.Repository;
import sonia.scm.repository.RepositoryEvent;
import sonia.scm.version.Version;
import static org.mockito.ArgumentMatchers.argThat;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
class RepositoryUpdateAfterCreationHookTest {
private static final Repository REPOSITORY = new Repository("1", "git", "space", "X");
@Test
void shouldSetHighestVersion() {
UpdateStepStore updateStepStore = mock(UpdateStepStore.class);
RepositoryUpdateAfterCreationHook hook = new RepositoryUpdateAfterCreationHook(
ImmutableSet.of(
createStep("1.1.0", "test.data"),
createStep("1.0.0", "test.data"),
createStep("2.0.0", "more.data"),
createStep("3.0.0", "more.data")
),
updateStepStore);
hook.updateRepository(new RepositoryEvent(HandlerEventType.CREATE, REPOSITORY));
verify(updateStepStore).storeExecutedUpdate(eq("1"), updateStepWith("1.1.0", "test.data"));
verify(updateStepStore).storeExecutedUpdate(eq("1"), updateStepWith("3.0", "more.data"));
}
private RepositoryUpdateStep updateStepWith(String version, String dataType) {
return argThat(
argument -> argument.getTargetVersion().equals(Version.parse(version))
&& argument.getAffectedDataType().equals(dataType)
);
}
private RepositoryUpdateStep createStep(String versionString, String dataType) {
return new RepositoryUpdateStep() {
@Override
public void doUpdate(RepositoryUpdateContext repositoryUpdateContext) {
}
@Override
public Version getTargetVersion() {
return Version.parse(versionString);
}
@Override
public String getAffectedDataType() {
return dataType;
}
@Override
public String toString() {
return String.format("Test update step with type %s for version %s", dataType, versionString);
}
};
}
}

23
scm-webapp/src/test/java/sonia/scm/update/UpdateEngineTest.java
View File

@@ -52,6 +52,7 @@ class UpdateEngineTest {
ConfigurationEntryStoreFactory storeFactory = new InMemoryConfigurationEntryStoreFactory();
RepositoryUpdateIterator repositoryUpdateIterator = mock(RepositoryUpdateIterator.class, CALLS_REAL_METHODS);
UpdateStepStore updateStepStore = new UpdateStepStore(storeFactory);
List<String> processedUpdates = new ArrayList<>();
@@ -73,7 +74,7 @@ class UpdateEngineTest {
updateSteps.add(new FixedVersionUpdateStep("test", "1.2.0"));
updateSteps.add(new FixedVersionUpdateStep("test", "1.1.0"));
UpdateEngine updateEngine = new UpdateEngine(updateSteps, emptySet(), storeFactory, repositoryUpdateIterator);
UpdateEngine updateEngine = new UpdateEngine(updateSteps, emptySet(), repositoryUpdateIterator, updateStepStore);
updateEngine.update();
assertThat(processedUpdates)
@@ -89,7 +90,7 @@ class UpdateEngineTest {
updateSteps.add(new FixedVersionUpdateStep("test", "1.2.0"));
repositoryUpdateSteps.add(new FixedVersionUpdateStep("test", "1.1.0"));
UpdateEngine updateEngine = new UpdateEngine(updateSteps, repositoryUpdateSteps, storeFactory, repositoryUpdateIterator);
UpdateEngine updateEngine = new UpdateEngine(updateSteps, repositoryUpdateSteps, repositoryUpdateIterator, updateStepStore);
updateEngine.update();
assertThat(processedUpdates)
@@ -105,7 +106,7 @@ class UpdateEngineTest {
repositoryUpdateSteps.add(new FixedVersionUpdateStep("test", "1.1.1"));
repositoryUpdateSteps.add(new FixedVersionUpdateStep("test", "1.1.0"));
UpdateEngine updateEngine = new UpdateEngine(updateSteps, repositoryUpdateSteps, storeFactory, repositoryUpdateIterator);
UpdateEngine updateEngine = new UpdateEngine(updateSteps, repositoryUpdateSteps, repositoryUpdateIterator, updateStepStore);
updateEngine.update("1337");
assertThat(processedUpdates)
@@ -119,7 +120,7 @@ class UpdateEngineTest {
updateSteps.add(new FixedVersionUpdateStep("test", "1.2.0"));
updateSteps.add(new CoreFixedVersionUpdateStep("core", "1.2.0"));
UpdateEngine updateEngine = new UpdateEngine(updateSteps, emptySet(), storeFactory, repositoryUpdateIterator);
UpdateEngine updateEngine = new UpdateEngine(updateSteps, emptySet(), repositoryUpdateIterator, updateStepStore);
updateEngine.update();
assertThat(processedUpdates)
@@ -131,7 +132,7 @@ class UpdateEngineTest {
Set<UpdateStep> updateSteps = singleton(new FixedVersionUpdateStep("test", "1.2.0"));
Set<RepositoryUpdateStep> repositoryUpdateSteps = singleton(new FixedVersionUpdateStep("test", "1.2.0"));
UpdateEngine updateEngine = new UpdateEngine(updateSteps, repositoryUpdateSteps, storeFactory, repositoryUpdateIterator);
UpdateEngine updateEngine = new UpdateEngine(updateSteps, repositoryUpdateSteps, repositoryUpdateIterator, updateStepStore);
updateEngine.update();
assertThat(processedUpdates)
@@ -144,12 +145,12 @@ class UpdateEngineTest {
updateSteps.add(new FixedVersionUpdateStep("test", "1.1.1"));
UpdateEngine firstUpdateEngine = new UpdateEngine(updateSteps, emptySet(), storeFactory, repositoryUpdateIterator);
UpdateEngine firstUpdateEngine = new UpdateEngine(updateSteps, emptySet(), repositoryUpdateIterator, updateStepStore);
firstUpdateEngine.update();
processedUpdates.clear();
UpdateEngine secondUpdateEngine = new UpdateEngine(updateSteps, emptySet(), storeFactory, repositoryUpdateIterator);
UpdateEngine secondUpdateEngine = new UpdateEngine(updateSteps, emptySet(), repositoryUpdateIterator, updateStepStore);
secondUpdateEngine.update();
assertThat(processedUpdates).isEmpty();
@@ -161,13 +162,13 @@ class UpdateEngineTest {
repositoryUpdateSteps.add(new FixedVersionUpdateStep("test", "1.1.1"));
UpdateEngine firstUpdateEngine = new UpdateEngine(emptySet(), repositoryUpdateSteps, storeFactory, repositoryUpdateIterator);
UpdateEngine firstUpdateEngine = new UpdateEngine(emptySet(), repositoryUpdateSteps, repositoryUpdateIterator, updateStepStore);
firstUpdateEngine.update();
processedUpdates.clear();
repositoryUpdateSteps.add(new FixedVersionUpdateStep("test", "1.2.0"));
UpdateEngine secondUpdateEngine = new UpdateEngine(emptySet(), repositoryUpdateSteps, storeFactory, repositoryUpdateIterator);
UpdateEngine secondUpdateEngine = new UpdateEngine(emptySet(), repositoryUpdateSteps, repositoryUpdateIterator, updateStepStore);
secondUpdateEngine.update();
assertThat(processedUpdates)
@@ -180,14 +181,14 @@ class UpdateEngineTest {
updateSteps.add(new FixedVersionUpdateStep("test", "1.1.1"));
UpdateEngine updateEngine = new UpdateEngine(updateSteps, emptySet(), storeFactory, repositoryUpdateIterator);
UpdateEngine updateEngine = new UpdateEngine(updateSteps, emptySet(), repositoryUpdateIterator, updateStepStore);
updateEngine.update();
processedUpdates.clear();
updateSteps.add(new FixedVersionUpdateStep("other", "1.1.1"));
updateEngine = new UpdateEngine(updateSteps, emptySet(), storeFactory, repositoryUpdateIterator);
updateEngine = new UpdateEngine(updateSteps, emptySet(), repositoryUpdateIterator, updateStepStore);
updateEngine.update();
assertThat(processedUpdates).containsExactly("other:1.1.1");