mirror of
https://github.com/scm-manager/scm-manager.git
synced 2026-07-04 09:49:26 +02:00
replace QuartzScheduler with a more lightweight scheduler
The new scheduler is based on the cron-utils package and uses the same cron syntax as quartz. CronScheduler was mainly introduced, because of a ClassLoader leak with the old Quartz implementation. The leak comes from shiros use of InheriatableThreadLocal in combination with the WorkerThreads of Quartz. CronScheduler uses a ThreadFactory which clears the Shiro context before a new Thread is created (see CronThreadFactory).
This commit is contained in:
Sebastian Sdorra
@@ -0,0 +1,75 @@
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import org.junit.jupiter.api.BeforeEach;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
|
||||
import java.time.Clock;
|
||||
import java.time.Duration;
|
||||
import java.time.Instant;
|
||||
import java.time.ZoneId;
|
||||
import java.time.ZonedDateTime;
|
||||
import java.util.Optional;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class CronExpressionTest {
|
||||
|
||||
@Mock
|
||||
private Clock clock;
|
||||
|
||||
@BeforeEach
|
||||
void setUpClockMock() {
|
||||
when(clock.getZone()).thenReturn(ZoneId.systemDefault());
|
||||
when(clock.instant()).thenReturn(Instant.parse("2007-12-03T10:15:00.00Z"));
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCalculateTheNextRunIn30Seconds() {
|
||||
assertNextRun("30 * * * * ?", 30);
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCalculateTheNextRunIn10Seconds() {
|
||||
assertNextRun("0/10 * * * * ?", 10);
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldReturnEmptyOptional() {
|
||||
CronExpression expression = new CronExpression(clock, "30 12 12 12 * ? 1985");
|
||||
|
||||
Optional<ZonedDateTime> optionalNextRun = expression.calculateNextRun();
|
||||
assertThat(optionalNextRun).isNotPresent();
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldReturnTrue() {
|
||||
ZonedDateTime time = ZonedDateTime.now(clock).minusSeconds(1L);
|
||||
|
||||
CronExpression expression = new CronExpression(clock, "30 * * * * ?");
|
||||
assertThat(expression.shouldRun(time)).isTrue();
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldReturnFalse() {
|
||||
ZonedDateTime time = ZonedDateTime.now(clock).plusSeconds(1L);
|
||||
|
||||
CronExpression expression = new CronExpression(clock, "30 * * * * ?");
|
||||
assertThat(expression.shouldRun(time)).isFalse();
|
||||
}
|
||||
|
||||
private void assertNextRun(String expressionAsString, long expectedSecondsToNextRun) {
|
||||
CronExpression expression = new CronExpression(clock, expressionAsString);
|
||||
|
||||
Optional<ZonedDateTime> optionalNextRun = expression.calculateNextRun();
|
||||
assertThat(optionalNextRun).isPresent();
|
||||
|
||||
ZonedDateTime nextRun = optionalNextRun.get();
|
||||
long nextRunInSeconds = Duration.between(ZonedDateTime.now(clock), nextRun).getSeconds();
|
||||
assertThat(nextRunInSeconds).isEqualTo(expectedSecondsToNextRun);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,66 @@
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import org.junit.jupiter.api.BeforeEach;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
|
||||
import java.util.concurrent.Future;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.*;
|
||||
import static org.mockito.ArgumentMatchers.any;
|
||||
import static org.mockito.ArgumentMatchers.anyString;
|
||||
import static org.mockito.Mockito.*;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class CronSchedulerTest {
|
||||
|
||||
@Mock
|
||||
private CronTaskFactory taskFactory;
|
||||
|
||||
@Mock
|
||||
private CronTask task;
|
||||
|
||||
@BeforeEach
|
||||
@SuppressWarnings("unchecked")
|
||||
void setUpTaskFactory() {
|
||||
lenient().when(taskFactory.create(anyString(), any(Runnable.class))).thenReturn(task);
|
||||
lenient().when(taskFactory.create(anyString(), any(Class.class))).thenReturn(task);
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldScheduleWithClass() {
|
||||
when(task.hasNextRun()).thenReturn(true);
|
||||
try (CronScheduler scheduler = new CronScheduler(taskFactory)) {
|
||||
scheduler.schedule("vep", TestingRunnable.class);
|
||||
verify(task).setFuture(any(Future.class));
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldScheduleWithRunnable() {
|
||||
when(task.hasNextRun()).thenReturn(true);
|
||||
try (CronScheduler scheduler = new CronScheduler(taskFactory)) {
|
||||
scheduler.schedule("vep", new TestingRunnable());
|
||||
verify(task).setFuture(any(Future.class));
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldSkipSchedulingWithoutNextRun(){
|
||||
try (CronScheduler scheduler = new CronScheduler(taskFactory)) {
|
||||
scheduler.schedule("vep", new TestingRunnable());
|
||||
verify(task, never()).setFuture(any(Future.class));
|
||||
}
|
||||
}
|
||||
|
||||
private static class TestingRunnable implements Runnable {
|
||||
|
||||
@Override
|
||||
public void run() {
|
||||
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
@@ -0,0 +1,67 @@
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import com.google.inject.Injector;
|
||||
import com.google.inject.util.Providers;
|
||||
import org.junit.jupiter.api.BeforeEach;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.InjectMocks;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
|
||||
import javax.inject.Provider;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.junit.jupiter.api.Assertions.*;
|
||||
import static org.mockito.ArgumentMatchers.any;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class CronTaskFactoryTest {
|
||||
|
||||
@Mock
|
||||
private Injector injector;
|
||||
|
||||
@Mock
|
||||
private PrivilegedRunnableFactory runnableFactory;
|
||||
|
||||
@InjectMocks
|
||||
private CronTaskFactory taskFactory;
|
||||
|
||||
@BeforeEach
|
||||
@SuppressWarnings("unchecked")
|
||||
void setUpMocks() {
|
||||
when(runnableFactory.create(any(Provider.class))).thenAnswer(ic -> {
|
||||
Provider<? extends Runnable> r = ic.getArgument(0);
|
||||
return r.get();
|
||||
});
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCreateATaskWithNameFromRunnable() {
|
||||
CronTask task = taskFactory.create("30 * * * * ?", new One());
|
||||
assertThat(task.getName()).isEqualTo(One.class.getName());
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCreateATaskWithNameFromClass() {
|
||||
when(injector.getProvider(One.class)).thenReturn(Providers.of(new One()));
|
||||
|
||||
CronTask task = taskFactory.create("30 * * * * ?", One.class);
|
||||
assertThat(task.getName()).isEqualTo(One.class.getName());
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCreateATaskWithCronExpression() {
|
||||
CronTask task = taskFactory.create("30 * * * * ?", new One());
|
||||
assertThat(task.getExpression().toString()).isEqualTo("30 * * * * ?");
|
||||
}
|
||||
|
||||
public static class One implements Runnable {
|
||||
|
||||
@Override
|
||||
public void run() {
|
||||
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,95 @@
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.InjectMocks;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.invocation.InvocationOnMock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
import org.mockito.stubbing.Answer;
|
||||
|
||||
import java.time.ZonedDateTime;
|
||||
import java.util.Optional;
|
||||
import java.util.concurrent.Future;
|
||||
|
||||
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
|
||||
import static org.junit.jupiter.api.Assertions.*;
|
||||
import static org.mockito.Mockito.*;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class CronTaskTest {
|
||||
|
||||
@Mock
|
||||
private CronExpression expression;
|
||||
|
||||
@Mock
|
||||
private Runnable runnable;
|
||||
|
||||
@Mock
|
||||
private Future<?> future;
|
||||
|
||||
@Test
|
||||
void shouldReturnTrue() {
|
||||
when(expression.calculateNextRun()).thenReturn(Optional.of(ZonedDateTime.now()));
|
||||
|
||||
CronTask task = task();
|
||||
|
||||
assertThat(task.hasNextRun()).isTrue();
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldReturnFalse() {
|
||||
when(expression.calculateNextRun()).thenReturn(Optional.empty());
|
||||
|
||||
CronTask task = task();
|
||||
|
||||
assertThat(task.hasNextRun()).isFalse();
|
||||
}
|
||||
|
||||
private CronTask task() {
|
||||
return new CronTask("one", expression, runnable);
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCancelWithoutNextRun() {
|
||||
ZonedDateTime time = ZonedDateTime.now();
|
||||
when(expression.calculateNextRun()).thenAnswer(new FirstTimeAnswer(Optional.of(time), Optional.empty()));
|
||||
when(expression.shouldRun(time)).thenReturn(true);
|
||||
|
||||
CronTask task = task();
|
||||
task.setFuture(future);
|
||||
task.run();
|
||||
|
||||
verify(runnable).run();
|
||||
verify(future).cancel(false);
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldNotRun() {
|
||||
task().run();
|
||||
|
||||
verify(runnable, never()).run();
|
||||
}
|
||||
|
||||
private static class FirstTimeAnswer implements Answer<Object> {
|
||||
|
||||
private boolean first = true;
|
||||
private final Object answer;
|
||||
private final Object secondAnswer;
|
||||
|
||||
FirstTimeAnswer(Object answer, Object secondAnswer) {
|
||||
this.answer = answer;
|
||||
this.secondAnswer = secondAnswer;
|
||||
}
|
||||
|
||||
@Override
|
||||
public Object answer(InvocationOnMock invocation) {
|
||||
if (first) {
|
||||
first = false;
|
||||
return answer;
|
||||
}
|
||||
return secondAnswer;
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
@@ -0,0 +1,87 @@
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import org.apache.shiro.subject.Subject;
|
||||
import org.apache.shiro.util.ThreadContext;
|
||||
import org.junit.jupiter.api.BeforeEach;
|
||||
import org.junit.jupiter.api.Nested;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
|
||||
import java.util.Collections;
|
||||
import java.util.Map;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class CronThreadFactoryTest {
|
||||
|
||||
private Runnable doNothind = () -> {};
|
||||
|
||||
@Test
|
||||
void shouldCreateThreadWithName() {
|
||||
try (CronThreadFactory threadFactory = new CronThreadFactory()) {
|
||||
Thread thread = threadFactory.newThread(doNothind);
|
||||
assertThat(thread.getName()).startsWith("CronScheduler-");
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCreateThreadsWithDifferentNames() {
|
||||
try (CronThreadFactory threadFactory = new CronThreadFactory()) {
|
||||
Thread one = threadFactory.newThread(doNothind);
|
||||
Thread two = threadFactory.newThread(doNothind);
|
||||
assertThat(one.getName()).isNotEqualTo(two.getName());
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldCreateThreadsWithDifferentNamesFromDifferentFactories() {
|
||||
String one;
|
||||
try (CronThreadFactory threadFactory = new CronThreadFactory()) {
|
||||
one = threadFactory.newThread(doNothind).getName();
|
||||
}
|
||||
|
||||
String two;
|
||||
try (CronThreadFactory threadFactory = new CronThreadFactory()) {
|
||||
two = threadFactory.newThread(doNothind).getName();
|
||||
}
|
||||
|
||||
assertThat(one).isNotEqualTo(two);
|
||||
}
|
||||
|
||||
@Nested
|
||||
class ShiroTests {
|
||||
|
||||
@Mock
|
||||
private Subject subject;
|
||||
|
||||
@BeforeEach
|
||||
void setUpContext() {
|
||||
ThreadContext.bind(subject);
|
||||
}
|
||||
|
||||
@Test
|
||||
void shouldNotInheritShiroContext() throws InterruptedException {
|
||||
ShiroResourceCapturingRunnable runnable = new ShiroResourceCapturingRunnable();
|
||||
try (CronThreadFactory threadFactory = new CronThreadFactory()) {
|
||||
Thread thread = threadFactory.newThread(runnable);
|
||||
thread.start();
|
||||
thread.join();
|
||||
}
|
||||
assertThat(runnable.resources).isSameAs(Collections.emptyMap());
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class ShiroResourceCapturingRunnable implements Runnable {
|
||||
|
||||
private Map<Object, Object> resources;
|
||||
|
||||
@Override
|
||||
public void run() {
|
||||
resources = ThreadContext.getResources();
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1,168 +0,0 @@
|
||||
/***
|
||||
* Copyright (c) 2015, Sebastian Sdorra
|
||||
* All rights reserved.
|
||||
*
|
||||
* Redistribution and use in source and binary forms, with or without
|
||||
* modification, are permitted provided that the following conditions are met:
|
||||
*
|
||||
* 1. Redistributions of source code must retain the above copyright notice,
|
||||
* this list of conditions and the following disclaimer.
|
||||
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
||||
* this list of conditions and the following disclaimer in the documentation
|
||||
* and/or other materials provided with the distribution.
|
||||
* 3. Neither the name of SCM-Manager; nor the names of its
|
||||
* contributors may be used to endorse or promote products derived from this
|
||||
* software without specific prior written permission.
|
||||
*
|
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
||||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
||||
* DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
|
||||
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
||||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
||||
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
|
||||
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
||||
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
||||
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
*
|
||||
* https://bitbucket.org/sdorra/scm-manager
|
||||
*
|
||||
*/
|
||||
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import com.google.inject.Injector;
|
||||
import com.google.inject.Provider;
|
||||
import org.junit.Test;
|
||||
import static org.mockito.Mockito.*;
|
||||
import org.junit.Rule;
|
||||
import org.junit.rules.ExpectedException;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.Mockito;
|
||||
import org.mockito.junit.MockitoJUnitRunner;
|
||||
import org.quartz.JobDataMap;
|
||||
import org.quartz.JobDetail;
|
||||
import org.quartz.JobExecutionContext;
|
||||
import org.quartz.JobExecutionException;
|
||||
import sonia.scm.web.security.AdministrationContext;
|
||||
import sonia.scm.web.security.PrivilegedAction;
|
||||
|
||||
/**
|
||||
* Unit tests for {@link InjectionEnabledJob}.
|
||||
*
|
||||
* @author Sebastian Sdorra
|
||||
*/
|
||||
@RunWith(MockitoJUnitRunner.class)
|
||||
public class InjectionEnabledJobTest {
|
||||
|
||||
@Mock
|
||||
private Injector injector;
|
||||
|
||||
@Mock
|
||||
private JobDataMap dataMap;
|
||||
|
||||
@Mock
|
||||
private JobDetail detail;
|
||||
|
||||
@Mock
|
||||
private JobExecutionContext jec;
|
||||
|
||||
@Mock
|
||||
private Provider<Runnable> runnable;
|
||||
|
||||
@Mock
|
||||
private AdministrationContext context;
|
||||
|
||||
@Rule
|
||||
public ExpectedException expected = ExpectedException.none();
|
||||
|
||||
/**
|
||||
* Tests {@link InjectionEnabledJob#execute(org.quartz.JobExecutionContext)} without context.
|
||||
*
|
||||
* @throws JobExecutionException
|
||||
*/
|
||||
@Test
|
||||
public void testExecuteWithoutContext() throws JobExecutionException
|
||||
{
|
||||
expected.expect(NullPointerException.class);
|
||||
expected.expectMessage("execution context");
|
||||
new InjectionEnabledJob().execute(null);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link InjectionEnabledJob#execute(org.quartz.JobExecutionContext)} without job detail.
|
||||
*
|
||||
* @throws JobExecutionException
|
||||
*/
|
||||
@Test
|
||||
public void testExecuteWithoutJobDetail() throws JobExecutionException
|
||||
{
|
||||
expected.expect(NullPointerException.class);
|
||||
expected.expectMessage("detail");
|
||||
new InjectionEnabledJob().execute(jec);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link InjectionEnabledJob#execute(org.quartz.JobExecutionContext)} without data map.
|
||||
*
|
||||
* @throws JobExecutionException
|
||||
*/
|
||||
@Test
|
||||
public void testExecuteWithoutDataMap() throws JobExecutionException
|
||||
{
|
||||
when(jec.getJobDetail()).thenReturn(detail);
|
||||
expected.expect(NullPointerException.class);
|
||||
expected.expectMessage("data map");
|
||||
new InjectionEnabledJob().execute(jec);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link InjectionEnabledJob#execute(org.quartz.JobExecutionContext)} without injector.
|
||||
*
|
||||
* @throws JobExecutionException
|
||||
*/
|
||||
@Test
|
||||
public void testExecuteWithoutInjector() throws JobExecutionException
|
||||
{
|
||||
when(jec.getJobDetail()).thenReturn(detail);
|
||||
when(detail.getJobDataMap()).thenReturn(dataMap);
|
||||
expected.expect(NullPointerException.class);
|
||||
expected.expectMessage("injector");
|
||||
new InjectionEnabledJob().execute(jec);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link InjectionEnabledJob#execute(org.quartz.JobExecutionContext)} without runnable.
|
||||
*
|
||||
* @throws JobExecutionException
|
||||
*/
|
||||
@Test
|
||||
public void testExecuteWithoutRunnable() throws JobExecutionException
|
||||
{
|
||||
when(jec.getJobDetail()).thenReturn(detail);
|
||||
when(detail.getJobDataMap()).thenReturn(dataMap);
|
||||
when(dataMap.get(Injector.class.getName())).thenReturn(injector);
|
||||
expected.expect(JobExecutionException.class);
|
||||
expected.expectMessage("runnable");
|
||||
new InjectionEnabledJob().execute(jec);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link InjectionEnabledJob#execute(org.quartz.JobExecutionContext)}.
|
||||
*
|
||||
* @throws JobExecutionException
|
||||
*/
|
||||
@Test
|
||||
public void testExecute() throws JobExecutionException
|
||||
{
|
||||
when(jec.getJobDetail()).thenReturn(detail);
|
||||
when(detail.getJobDataMap()).thenReturn(dataMap);
|
||||
when(dataMap.get(Injector.class.getName())).thenReturn(injector);
|
||||
when(dataMap.get(Runnable.class.getName())).thenReturn(runnable);
|
||||
when(injector.getInstance(AdministrationContext.class)).thenReturn(context);
|
||||
new InjectionEnabledJob().execute(jec);
|
||||
verify(context).runAsAdmin(Mockito.any(PrivilegedAction.class));
|
||||
}
|
||||
|
||||
}
|
||||
@@ -0,0 +1,53 @@
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import com.google.inject.util.Providers;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.InjectMocks;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
import sonia.scm.web.security.AdministrationContext;
|
||||
import sonia.scm.web.security.PrivilegedAction;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
import static org.mockito.ArgumentMatchers.any;
|
||||
import static org.mockito.Mockito.doAnswer;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class PrivilegedRunnableFactoryTest {
|
||||
|
||||
@Mock
|
||||
private AdministrationContext administrationContext;
|
||||
|
||||
@InjectMocks
|
||||
private PrivilegedRunnableFactory runnableFactory;
|
||||
|
||||
@Test
|
||||
void shouldRunAsPrivilegedAction() {
|
||||
doAnswer((ic) -> {
|
||||
PrivilegedAction action = ic.getArgument(0);
|
||||
action.run();
|
||||
return null;
|
||||
}).when(administrationContext).runAsAdmin(any(PrivilegedAction.class));
|
||||
|
||||
RemindingRunnable runnable = new RemindingRunnable();
|
||||
|
||||
Runnable action = runnableFactory.create(Providers.of(runnable));
|
||||
assertThat(action).isNotExactlyInstanceOf(RemindingRunnable.class);
|
||||
|
||||
assertThat(runnable.run).isFalse();
|
||||
action.run();
|
||||
assertThat(runnable.run).isTrue();
|
||||
}
|
||||
|
||||
private static class RemindingRunnable implements Runnable {
|
||||
|
||||
private boolean run = false;
|
||||
|
||||
@Override
|
||||
public void run() {
|
||||
run = true;
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
@@ -1,222 +0,0 @@
|
||||
/***
|
||||
* Copyright (c) 2015, Sebastian Sdorra
|
||||
* All rights reserved.
|
||||
*
|
||||
* Redistribution and use in source and binary forms, with or without
|
||||
* modification, are permitted provided that the following conditions are met:
|
||||
*
|
||||
* 1. Redistributions of source code must retain the above copyright notice,
|
||||
* this list of conditions and the following disclaimer.
|
||||
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
||||
* this list of conditions and the following disclaimer in the documentation
|
||||
* and/or other materials provided with the distribution.
|
||||
* 3. Neither the name of SCM-Manager; nor the names of its
|
||||
* contributors may be used to endorse or promote products derived from this
|
||||
* software without specific prior written permission.
|
||||
*
|
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
||||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
||||
* DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
|
||||
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
||||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
||||
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
|
||||
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
||||
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
||||
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
*
|
||||
* https://bitbucket.org/sdorra/scm-manager
|
||||
*
|
||||
*/
|
||||
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import com.google.inject.Injector;
|
||||
import com.google.inject.Provider;
|
||||
import java.io.IOException;
|
||||
import org.junit.Test;
|
||||
import static org.junit.Assert.*;
|
||||
import static org.mockito.Mockito.*;
|
||||
import static org.hamcrest.Matchers.*;
|
||||
import org.junit.Before;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.ArgumentCaptor;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.MockitoJUnitRunner;
|
||||
import org.quartz.CronTrigger;
|
||||
import org.quartz.JobDetail;
|
||||
import org.quartz.SchedulerException;
|
||||
import org.quartz.Trigger;
|
||||
|
||||
/**
|
||||
* Unit tests for {@link QuartzScheduler}.
|
||||
*
|
||||
* @author Sebastian Sdorra
|
||||
*/
|
||||
@RunWith(MockitoJUnitRunner.class)
|
||||
public class QuartzSchedulerTest {
|
||||
|
||||
@Mock
|
||||
private Injector injector;
|
||||
|
||||
@Mock
|
||||
private org.quartz.Scheduler quartzScheduler;
|
||||
|
||||
private QuartzScheduler scheduler;
|
||||
|
||||
@Before
|
||||
public void setUp()
|
||||
{
|
||||
scheduler = new QuartzScheduler(injector, quartzScheduler);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#schedule(java.lang.String, java.lang.Runnable)}.
|
||||
*
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
@SuppressWarnings("unchecked")
|
||||
public void testSchedule() throws SchedulerException
|
||||
{
|
||||
DummyRunnable dr = new DummyRunnable();
|
||||
Task task = scheduler.schedule("42 2 * * * ?", dr);
|
||||
assertNotNull(task);
|
||||
|
||||
ArgumentCaptor<JobDetail> detailCaptor = ArgumentCaptor.forClass(JobDetail.class);
|
||||
ArgumentCaptor<Trigger> triggerCaptor = ArgumentCaptor.forClass(Trigger.class);
|
||||
verify(quartzScheduler).scheduleJob(detailCaptor.capture(), triggerCaptor.capture());
|
||||
|
||||
Trigger trigger = triggerCaptor.getValue();
|
||||
assertThat(trigger, is(instanceOf(CronTrigger.class)));
|
||||
CronTrigger cron = (CronTrigger) trigger;
|
||||
assertEquals("42 2 * * * ?", cron.getCronExpression());
|
||||
|
||||
JobDetail detail = detailCaptor.getValue();
|
||||
assertEquals(InjectionEnabledJob.class, detail.getJobClass());
|
||||
Provider<Runnable> runnable = (Provider<Runnable>) detail.getJobDataMap().get(Runnable.class.getName());
|
||||
assertNotNull(runnable);
|
||||
assertSame(dr, runnable.get());
|
||||
assertEquals(injector, detail.getJobDataMap().get(Injector.class.getName()));
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#schedule(java.lang.String, java.lang.Class)}.
|
||||
*
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
public void testScheduleWithClass() throws SchedulerException
|
||||
{
|
||||
scheduler.schedule("42 * * * * ?", DummyRunnable.class);
|
||||
|
||||
verify(injector).getProvider(DummyRunnable.class);
|
||||
|
||||
ArgumentCaptor<JobDetail> detailCaptor = ArgumentCaptor.forClass(JobDetail.class);
|
||||
ArgumentCaptor<Trigger> triggerCaptor = ArgumentCaptor.forClass(Trigger.class);
|
||||
verify(quartzScheduler).scheduleJob(detailCaptor.capture(), triggerCaptor.capture());
|
||||
|
||||
Trigger trigger = triggerCaptor.getValue();
|
||||
assertThat(trigger, is(instanceOf(CronTrigger.class)));
|
||||
CronTrigger cron = (CronTrigger) trigger;
|
||||
assertEquals("42 * * * * ?", cron.getCronExpression());
|
||||
|
||||
JobDetail detail = detailCaptor.getValue();
|
||||
assertEquals(InjectionEnabledJob.class, detail.getJobClass());
|
||||
assertEquals(injector, detail.getJobDataMap().get(Injector.class.getName()));
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#init(sonia.scm.SCMContextProvider)}.
|
||||
*
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
public void testInit() throws SchedulerException
|
||||
{
|
||||
when(quartzScheduler.isStarted()).thenReturn(Boolean.FALSE);
|
||||
scheduler.init(null);
|
||||
verify(quartzScheduler).start();
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#init(sonia.scm.SCMContextProvider)} when the underlying scheduler is already started.
|
||||
*
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
public void testInitAlreadyRunning() throws SchedulerException
|
||||
{
|
||||
when(quartzScheduler.isStarted()).thenReturn(Boolean.TRUE);
|
||||
scheduler.init(null);
|
||||
verify(quartzScheduler, never()).start();
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#init(sonia.scm.SCMContextProvider)} when the underlying scheduler throws an exception.
|
||||
*
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
@SuppressWarnings("unchecked")
|
||||
public void testInitException() throws SchedulerException
|
||||
{
|
||||
when(quartzScheduler.isStarted()).thenThrow(SchedulerException.class);
|
||||
scheduler.init(null);
|
||||
verify(quartzScheduler, never()).start();
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#close()}.
|
||||
*
|
||||
* @throws IOException
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
public void testClose() throws IOException, SchedulerException
|
||||
{
|
||||
when(quartzScheduler.isStarted()).thenReturn(Boolean.TRUE);
|
||||
scheduler.close();
|
||||
verify(quartzScheduler).shutdown();
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#close()} when the underlying scheduler is not running.
|
||||
*
|
||||
* @throws IOException
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
public void testCloseNotRunning() throws IOException, SchedulerException
|
||||
{
|
||||
when(quartzScheduler.isStarted()).thenReturn(Boolean.FALSE);
|
||||
scheduler.close();
|
||||
verify(quartzScheduler, never()).shutdown();
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzScheduler#close()} when the underlying scheduler throws an exception.
|
||||
*
|
||||
* @throws IOException
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
@SuppressWarnings("unchecked")
|
||||
public void testCloseException() throws IOException, SchedulerException
|
||||
{
|
||||
when(quartzScheduler.isStarted()).thenThrow(SchedulerException.class);
|
||||
scheduler.close();
|
||||
verify(quartzScheduler, never()).shutdown();
|
||||
}
|
||||
|
||||
|
||||
public static class DummyRunnable implements Runnable {
|
||||
|
||||
@Override
|
||||
public void run()
|
||||
{
|
||||
throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
@@ -1,89 +0,0 @@
|
||||
/***
|
||||
* Copyright (c) 2015, Sebastian Sdorra
|
||||
* All rights reserved.
|
||||
*
|
||||
* Redistribution and use in source and binary forms, with or without
|
||||
* modification, are permitted provided that the following conditions are met:
|
||||
*
|
||||
* 1. Redistributions of source code must retain the above copyright notice,
|
||||
* this list of conditions and the following disclaimer.
|
||||
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
||||
* this list of conditions and the following disclaimer in the documentation
|
||||
* and/or other materials provided with the distribution.
|
||||
* 3. Neither the name of SCM-Manager; nor the names of its
|
||||
* contributors may be used to endorse or promote products derived from this
|
||||
* software without specific prior written permission.
|
||||
*
|
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
||||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
||||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
||||
* DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
|
||||
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
||||
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
||||
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
|
||||
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
||||
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
||||
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
*
|
||||
* https://bitbucket.org/sdorra/scm-manager
|
||||
*
|
||||
*/
|
||||
|
||||
package sonia.scm.schedule;
|
||||
|
||||
import org.junit.Test;
|
||||
|
||||
import static org.mockito.Mockito.*;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.MockitoJUnitRunner;
|
||||
import org.quartz.JobKey;
|
||||
import org.quartz.SchedulerException;
|
||||
|
||||
/**
|
||||
* Unit tests for {@link QuartzTask}.
|
||||
*
|
||||
* @author Sebastian Sdorra <sebastian.sdorra@triology.de>
|
||||
*/
|
||||
@RunWith(MockitoJUnitRunner.class)
|
||||
public class QuartzTaskTest {
|
||||
|
||||
@Mock
|
||||
private org.quartz.Scheduler scheduler;
|
||||
|
||||
private final JobKey jobKey = new JobKey("sample");
|
||||
|
||||
private QuartzTask task;
|
||||
|
||||
@Before
|
||||
public void setUp(){
|
||||
task = new QuartzTask(scheduler, jobKey);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzTask#cancel()}.
|
||||
*
|
||||
* @throws SchedulerException
|
||||
*/
|
||||
@Test
|
||||
public void testCancel() throws SchedulerException
|
||||
{
|
||||
task.cancel();
|
||||
verify(scheduler).deleteJob(jobKey);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests {@link QuartzTask#cancel()} when the scheduler throws an exception.
|
||||
* @throws org.quartz.SchedulerException
|
||||
*/
|
||||
@SuppressWarnings("unchecked")
|
||||
@Test(expected = RuntimeException.class)
|
||||
public void testCancelWithException() throws SchedulerException
|
||||
{
|
||||
when(scheduler.deleteJob(jobKey)).thenThrow(SchedulerException.class);
|
||||
task.cancel();
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user