diff --git a/scm-ui-components/packages/ui-components/src/forms/Radio.js b/scm-ui-components/packages/ui-components/src/forms/Radio.js index 2b1c626d7b..6460e67070 100644 --- a/scm-ui-components/packages/ui-components/src/forms/Radio.js +++ b/scm-ui-components/packages/ui-components/src/forms/Radio.js @@ -22,8 +22,7 @@ class Radio extends React.Component { render() { return ( -
-
+ -
-
); } } diff --git a/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.js b/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.js index a3ba8616c9..46e68ad72f 100644 --- a/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.js +++ b/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.js @@ -2,7 +2,7 @@ import React from "react"; import { translate } from "react-i18next"; import type { Permission } from "@scm-manager/ui-types"; -import { confirmAlert, DeleteButton } from "@scm-manager/ui-components"; +import { confirmAlert } from "@scm-manager/ui-components"; type Props = { permission: Permission, @@ -54,18 +54,18 @@ class DeletePermissionButton extends React.Component { }; render() { - const { confirmDialog, loading, t } = this.props; + const { confirmDialog } = this.props; const action = confirmDialog ? this.confirmDelete : this.deletePermission; if (!this.isDeletable()) { return null; } return ( - + + + + + ); } } diff --git a/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.test.js b/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.test.js index 811c9dc335..03eebe3c50 100644 --- a/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.test.js +++ b/scm-ui/src/repos/permissions/components/buttons/DeletePermissionButton.test.js @@ -29,7 +29,7 @@ describe("DeletePermissionButton", () => { expect(navLink.text()).toBe(""); }); - it("should render the navLink", () => { + it("should render the delete icon", () => { const permission = { _links: { delete: { @@ -38,14 +38,14 @@ describe("DeletePermissionButton", () => { } }; - const navLink = mount( + const deleteIcon = mount( {}} />, options.get() ); - expect(navLink.text()).not.toBe(""); + expect(deleteIcon.html()).not.toBe(""); }); it("should open the confirm dialog on button click", () => { @@ -64,7 +64,7 @@ describe("DeletePermissionButton", () => { />, options.get() ); - button.find("button").simulate("click"); + button.find(".fa-trash").simulate("click"); expect(confirmAlert.mock.calls.length).toBe(1); }); @@ -91,7 +91,7 @@ describe("DeletePermissionButton", () => { />, options.get() ); - button.find("button").simulate("click"); + button.find(".fa-trash").simulate("click"); expect(calledUrl).toBe("/permission"); }); diff --git a/scm-ui/src/repos/permissions/containers/AdvancedPermissionsDialog.js b/scm-ui/src/repos/permissions/containers/AdvancedPermissionsDialog.js index 643e2150e5..cc662e5f06 100644 --- a/scm-ui/src/repos/permissions/containers/AdvancedPermissionsDialog.js +++ b/scm-ui/src/repos/permissions/containers/AdvancedPermissionsDialog.js @@ -50,18 +50,20 @@ class AdvancedPermissionsDialog extends React.Component { ) : null; + const body = <>{verbSelectBoxes}; - const body = ( - <> -
{verbSelectBoxes}
-
- {submitButton} -