From 281d8120657598c574f579b4fe37c73782863301 Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Fri, 27 Sep 2019 15:30:21 +0200
Subject: [PATCH] add rest api updateAllPlugins

---
 .../java/sonia/scm/plugin/PluginManager.java  |  8 ++++
 scm-ui/public/locales/de/admin.json           |  2 +
 scm-ui/public/locales/en/admin.json           |  2 +
 scm-ui/public/locales/es/admin.json           |  2 +
 .../components/MultiPluginActionModal.js      |  3 +-
 .../v2/resources/InstalledPluginResource.java | 15 ++++++++
 .../resources/PluginDtoCollectionMapper.java  |  4 ++
 .../scm/api/v2/resources/ResourceLinks.java   |  4 ++
 .../scm/plugin/DefaultPluginManager.java      | 16 +++++++-
 .../scm/plugin/DefaultPluginManagerTest.java  | 38 +++++++++++++++++++
 .../sonia/scm/plugin/PluginTestHelper.java    |  7 ++++
 11 files changed, 99 insertions(+), 2 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/plugin/PluginManager.java b/scm-core/src/main/java/sonia/scm/plugin/PluginManager.java
index 964ebf605b..f0719226ce 100644
--- a/scm-core/src/main/java/sonia/scm/plugin/PluginManager.java
+++ b/scm-core/src/main/java/sonia/scm/plugin/PluginManager.java
@@ -94,5 +94,13 @@ public interface PluginManager {
    */
   void executePendingAndRestart();
 
+  /**
+   * Cancel all pending plugins.
+   */
   void cancelPending();
+
+  /**
+   * Update all installed plugins.
+   */
+  void updateAll(boolean restartAfterInstallation);
 }
diff --git a/scm-ui/public/locales/de/admin.json b/scm-ui/public/locales/de/admin.json
index d4f3567059..3da907eb02 100644
--- a/scm-ui/public/locales/de/admin.json
+++ b/scm-ui/public/locales/de/admin.json
@@ -30,6 +30,8 @@
       "availableNavLink": "Verfügbar"
     },
     "executePending": "Ausstehende Plugin-Änderungen ausführen",
+    "updateAll": "Alle Plugins aktualisieren",
+    "cancelPending": "Ausstehende Plugin-Änderungen abbrechen",
     "noPlugins": "Keine Plugins gefunden.",
     "modal": {
       "title": {
diff --git a/scm-ui/public/locales/en/admin.json b/scm-ui/public/locales/en/admin.json
index c23a88a920..245d048684 100644
--- a/scm-ui/public/locales/en/admin.json
+++ b/scm-ui/public/locales/en/admin.json
@@ -30,6 +30,8 @@
       "availableNavLink": "Available"
     },
     "executePending": "Execute pending plugin changes",
+    "updateAll": "Update all plugins",
+    "cancelPending": "Cancel pending plugin changes",
     "noPlugins": "No plugins found.",
     "modal": {
       "title": {
diff --git a/scm-ui/public/locales/es/admin.json b/scm-ui/public/locales/es/admin.json
index db9fade43c..155313ed99 100644
--- a/scm-ui/public/locales/es/admin.json
+++ b/scm-ui/public/locales/es/admin.json
@@ -30,6 +30,8 @@
       "availableNavLink": "Disponibles"
     },
     "executePending": "Ejecutar los complementos pendientes",
+    "updateAll": "Actualizar todos los complementos",
+    "cancelPending": "Cancelar los complementos pendientes",
     "noPlugins": "No se han encontrado complementos.",
     "modal": {
       "title": {
diff --git a/scm-ui/src/admin/plugins/components/MultiPluginActionModal.js b/scm-ui/src/admin/plugins/components/MultiPluginActionModal.js
index 24a0f0d982..3c543bf5c2 100644
--- a/scm-ui/src/admin/plugins/components/MultiPluginActionModal.js
+++ b/scm-ui/src/admin/plugins/components/MultiPluginActionModal.js
@@ -155,13 +155,14 @@ class MultiPluginActionModal extends React.Component<Props, State> {
   };
 
   renderUpdatable = () => {
-    const { installedPlugins } = this.props;
+    const {installedPlugins, t} = this.props;
     return (
       <>
         {installedPlugins &&
           installedPlugins._embedded &&
           installedPlugins._embedded.plugins && (
             <>
+              <strong>{t("plugins.modal.updateQueue")}</strong>
               <ul>
                 {installedPlugins._embedded.plugins
                   .filter(plugin => plugin._links && plugin._links.update)
diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/InstalledPluginResource.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/InstalledPluginResource.java
index f0dff26757..e258aadd5d 100644
--- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/InstalledPluginResource.java
+++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/InstalledPluginResource.java
@@ -56,6 +56,21 @@ public class InstalledPluginResource {
     return Response.ok(collectionMapper.mapInstalled(plugins, available)).build();
   }
 
+  /**
+   * Updates all installed plugins.
+   */
+  @POST
+  @Path("/update")
+  @StatusCodes({
+    @ResponseCode(code = 200, condition = "success"),
+    @ResponseCode(code = 500, condition = "internal server error")
+  })
+  @TypeHint(CollectionDto.class)
+  public Response updateAll(@QueryParam("restart") boolean restartAfterInstallation) {
+    pluginManager.updateAll(restartAfterInstallation);
+    return Response.ok().build();
+  }
+
   /**
    * Returns the installed plugin with the given id.
    *
diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDtoCollectionMapper.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDtoCollectionMapper.java
index 3d817625c7..5da00184ed 100644
--- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDtoCollectionMapper.java
+++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDtoCollectionMapper.java
@@ -12,6 +12,7 @@ import sonia.scm.plugin.PluginPermissions;
 import java.util.List;
 
 import static de.otto.edison.hal.Embedded.embeddedBuilder;
+import static de.otto.edison.hal.Link.*;
 import static de.otto.edison.hal.Links.linkingTo;
 import static java.util.stream.Collectors.toList;
 
@@ -44,6 +45,9 @@ public class PluginDtoCollectionMapper {
 
     Links.Builder linksBuilder = linkingTo()
       .with(Links.linkingTo().self(baseUrl).build());
+
+    linksBuilder.single(link("update", resourceLinks.installedPluginCollection().update()));
+
     return linksBuilder.build();
   }
 
diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ResourceLinks.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ResourceLinks.java
index c36cfc09ad..4ad6b49bf7 100644
--- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ResourceLinks.java
+++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ResourceLinks.java
@@ -686,6 +686,10 @@ class ResourceLinks {
     String self() {
       return installedPluginCollectionLinkBuilder.method("installedPlugins").parameters().method("getInstalledPlugins").parameters().href();
     }
+
+    String update() {
+      return installedPluginCollectionLinkBuilder.method("installedPlugins").parameters().method("updateAll").parameters().href();
+    }
   }
 
   public AvailablePluginLinks availablePlugin() {
diff --git a/scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java b/scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java
index ed5e7f78db..547a8285d3 100644
--- a/scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java
+++ b/scm-webapp/src/main/java/sonia/scm/plugin/DefaultPluginManager.java
@@ -193,7 +193,6 @@ public class DefaultPluginManager implements PluginManager {
       .orElseThrow(() -> NotFoundException.notFound(entity(InstalledPlugin.class, name)));
     doThrow().violation("plugin is a core plugin and cannot be uninstalled").when(installed.isCore());
 
-
     markForUninstall(installed);
 
     if (restartAfterInstallation) {
@@ -279,4 +278,19 @@ public class DefaultPluginManager implements PluginManager {
     pendingUninstallQueue.forEach(PendingPluginUninstallation::cancel);
     pendingInstallQueue.forEach(PendingPluginInstallation::cancel);
   }
+
+  @Override
+  public void updateAll(boolean restartAfterInstallation) {
+    PluginPermissions.manage().check();
+
+    for (InstalledPlugin installedPlugin : getInstalled()) {
+      String pluginName = installedPlugin.getDescriptor().getInformation().getName();
+      if (isUpdatable(pluginName)) {
+        install(pluginName, false);
+      }
+      if (restartAfterInstallation) {
+        restart("update all plugin");
+      }
+    }
+  }
 }
diff --git a/scm-webapp/src/test/java/sonia/scm/plugin/DefaultPluginManagerTest.java b/scm-webapp/src/test/java/sonia/scm/plugin/DefaultPluginManagerTest.java
index 84bf843ca2..80137be203 100644
--- a/scm-webapp/src/test/java/sonia/scm/plugin/DefaultPluginManagerTest.java
+++ b/scm-webapp/src/test/java/sonia/scm/plugin/DefaultPluginManagerTest.java
@@ -474,6 +474,39 @@ class DefaultPluginManagerTest {
       Boolean lasUninstallMarkerSet = uninstallCaptor.getAllValues().get(uninstallCaptor.getAllValues().size() - 1);
       assertThat(lasUninstallMarkerSet).isFalse();
     }
+
+    @Test
+    void shouldUpdateAllPlugins() {
+      InstalledPlugin mailPlugin = createInstalled("scm-mail-plugin");
+      InstalledPlugin reviewPlugin = createInstalled("scm-review-plugin");
+
+      when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of(mailPlugin, reviewPlugin));
+
+      AvailablePlugin newMailPlugin = createAvailable("scm-mail-plugin", "2.0.0");
+      AvailablePlugin newReviewPlugin = createAvailable("scm-review-plugin", "2.0.0");
+
+      when(center.getAvailable()).thenReturn(ImmutableSet.of(newMailPlugin, newReviewPlugin));
+
+      manager.updateAll(false);
+
+      verify(installer).install(newMailPlugin);
+      verify(installer).install(newReviewPlugin);
+    }
+
+
+    @Test
+    void shouldNotUpdateToOldPluginVersions() {
+      InstalledPlugin scriptPlugin = createInstalled("scm-script-plugin");
+
+      when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of(scriptPlugin));
+      AvailablePlugin oldScriptPlugin = createAvailable("scm-script-plugin", "0.9");
+
+      when(center.getAvailable()).thenReturn(ImmutableSet.of(oldScriptPlugin));
+
+      manager.updateAll(false);
+
+      verify(installer, never()).install(oldScriptPlugin);
+    }
   }
 
   @Nested
@@ -533,5 +566,10 @@ class DefaultPluginManagerTest {
     void shouldThrowAuthorizationExceptionsForCancelPending() {
       assertThrows(AuthorizationException.class, () -> manager.cancelPending());
     }
+
+    @Test
+    void shouldThrowAuthorizationExceptionsForUpdateAll() {
+      assertThrows(AuthorizationException.class, () -> manager.updateAll(false));
+    }
   }
 }
diff --git a/scm-webapp/src/test/java/sonia/scm/plugin/PluginTestHelper.java b/scm-webapp/src/test/java/sonia/scm/plugin/PluginTestHelper.java
index 2bd3dce1c2..00549c360c 100644
--- a/scm-webapp/src/test/java/sonia/scm/plugin/PluginTestHelper.java
+++ b/scm-webapp/src/test/java/sonia/scm/plugin/PluginTestHelper.java
@@ -14,6 +14,13 @@ public class PluginTestHelper {
     return createAvailable(information);
   }
 
+  public static AvailablePlugin createAvailable(String name, String version) {
+    PluginInformation information = new PluginInformation();
+    information.setName(name);
+    information.setVersion(version);
+    return createAvailable(information);
+  }
+
   public static InstalledPlugin createInstalled(String name) {
     PluginInformation information = new PluginInformation();
     information.setName(name);