From 85502116158b0cefc5a09040d183e361e3e9f711 Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Thu, 18 Jun 2020 10:35:55 +0200
Subject: [PATCH 1/4] fix tooltip multiline view

---
 scm-ui/ui-components/src/Tooltip.tsx                 |  2 +-
 .../src/__snapshots__/storyshots.test.ts.snap        | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/scm-ui/ui-components/src/Tooltip.tsx b/scm-ui/ui-components/src/Tooltip.tsx
index 79f5c9f855..b358c6382f 100644
--- a/scm-ui/ui-components/src/Tooltip.tsx
+++ b/scm-ui/ui-components/src/Tooltip.tsx
@@ -38,7 +38,7 @@ class Tooltip extends React.Component<Props> {
 
   render() {
     const { className, message, location, children } = this.props;
-    const multiline = message.length > 60 ? "has-tooltip-multiline" : "";
+    const multiline = message.length > 60 ? "is-multiline" : "";
     return (
       <span className={classNames("tooltip", "has-tooltip-" + location, multiline, className)} data-tooltip={message}>
         {children}
diff --git a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
index 4ab1158583..79430a7441 100644
--- a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
+++ b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
@@ -17281,7 +17281,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top has-tooltip-multiline"
+                className="tooltip has-tooltip-top is-multiline"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -17862,7 +17862,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top has-tooltip-multiline"
+                className="tooltip has-tooltip-top is-multiline"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -18720,7 +18720,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top has-tooltip-multiline"
+                className="tooltip has-tooltip-top is-multiline"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -19174,7 +19174,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top has-tooltip-multiline"
+                className="tooltip has-tooltip-top is-multiline"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -19628,7 +19628,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top has-tooltip-multiline"
+                className="tooltip has-tooltip-top is-multiline"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -20689,7 +20689,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top has-tooltip-multiline"
+                className="tooltip has-tooltip-top is-multiline"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a

From 0eb534e820464a577e456985f2c210e6c7b29704 Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Thu, 18 Jun 2020 10:42:16 +0200
Subject: [PATCH 2/4] update CHANGELOG.md

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5034293255..e9b2d9a843 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed active state of sub navigation items, which are using activeWhenMatch ([#1199](https://github.com/scm-manager/scm-manager/pull/1199))
 - Handles repositories in custom directories correctly in migration from 1.x ([#1201](https://github.com/scm-manager/scm-manager/pull/1201))
 - Usage of short git commit ids in changeset urls ([#1200](https://github.com/scm-manager/scm-manager/pull/1200))
+- Fixes linebreaks in multiline tooltip ([#1207](https://github.com/scm-manager/scm-manager/pull/1207))
 
 ## [2.0.0] - 2020-06-04
 ### Added

From d2346278f1926424143caacb2873887e7481029e Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Fri, 19 Jun 2020 11:43:04 +0200
Subject: [PATCH 3/4] added some tooltip stories to test multiline

---
 scm-ui/ui-components/src/Tooltip.stories.tsx | 44 ++++++++++++++++++--
 1 file changed, 40 insertions(+), 4 deletions(-)

diff --git a/scm-ui/ui-components/src/Tooltip.stories.tsx b/scm-ui/ui-components/src/Tooltip.stories.tsx
index f6f4cbad5b..13cfb93228 100644
--- a/scm-ui/ui-components/src/Tooltip.stories.tsx
+++ b/scm-ui/ui-components/src/Tooltip.stories.tsx
@@ -32,24 +32,38 @@ import Button from "./buttons/Button";
 
 const Wrapper = styled.div`
   margin: 2rem;
-  max-width: 400px;
+  width: 100%;
 `;
 
 const Spacing = styled.div`
   padding: 2em 6em;
+  width: 50%;
+  margin: 0 auto;
 `;
 
 const positions = ["right", "top", "left", "bottom"];
 
 const message = "Heart of Gold";
 
+const mutltiline = `Characters:
+
+- Arthur Dent
+- Ford Prefect
+- Zaphod Beeblebrox
+- Marvin the Paranoid Android
+- Trillian
+- Slartibartfast`;
+
+const shortMultiline = `* a
+* b
+* c`;
+
 const RoutingDecorator = (story: () => ReactNode) => <MemoryRouter initialEntries={["/"]}>{story()}</MemoryRouter>;
 
 storiesOf("Tooltip", module)
   .addDecorator(RoutingDecorator)
-  .addDecorator(storyFn => <Wrapper>{storyFn()}</Wrapper>)
   .add("Default", () => (
-    <div>
+    <Wrapper>
       {positions.map(position => (
         <Spacing>
           <Tooltip message={message} location={position}>
@@ -57,5 +71,27 @@ storiesOf("Tooltip", module)
           </Tooltip>
         </Spacing>
       ))}
-    </div>
+    </Wrapper>
+  ))
+  .add("Multiline", () => (
+    <Wrapper>
+      {positions.map(position => (
+        <Spacing>
+          <Tooltip message={mutltiline} location={position}>
+            <Button label={position} color="info" />{" "}
+          </Tooltip>
+        </Spacing>
+      ))}
+    </Wrapper>
+  ))
+  .add("Short Multiline", () => (
+    <Wrapper>
+      {positions.map(position => (
+        <Spacing>
+          <Tooltip message={shortMultiline} location={position}>
+            <Button label={position} color="info" />{" "}
+          </Tooltip>
+        </Spacing>
+      ))}
+    </Wrapper>
   ));

From dcf1fd84c5948a8a95d1235fb3007616b117260d Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Mon, 22 Jun 2020 11:27:05 +0200
Subject: [PATCH 4/4] remove useless class

---
 scm-ui/ui-components/src/Tooltip.tsx          |   3 +-
 .../src/__snapshots__/storyshots.test.ts.snap | 328 ++++++++++++++----
 2 files changed, 261 insertions(+), 70 deletions(-)

diff --git a/scm-ui/ui-components/src/Tooltip.tsx b/scm-ui/ui-components/src/Tooltip.tsx
index b358c6382f..98dce960d2 100644
--- a/scm-ui/ui-components/src/Tooltip.tsx
+++ b/scm-ui/ui-components/src/Tooltip.tsx
@@ -38,9 +38,8 @@ class Tooltip extends React.Component<Props> {
 
   render() {
     const { className, message, location, children } = this.props;
-    const multiline = message.length > 60 ? "is-multiline" : "";
     return (
-      <span className={classNames("tooltip", "has-tooltip-" + location, multiline, className)} data-tooltip={message}>
+      <span className={classNames("tooltip", "has-tooltip-" + location, className)} data-tooltip={message}>
         {children}
       </span>
     );
diff --git a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
index 79430a7441..a1db5dadc0 100644
--- a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
+++ b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
@@ -17281,7 +17281,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top is-multiline"
+                className="tooltip has-tooltip-top"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -17862,7 +17862,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top is-multiline"
+                className="tooltip has-tooltip-top"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -18720,7 +18720,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top is-multiline"
+                className="tooltip has-tooltip-top"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -19174,7 +19174,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top is-multiline"
+                className="tooltip has-tooltip-top"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -19628,7 +19628,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top is-multiline"
+                className="tooltip has-tooltip-top"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -20689,7 +20689,7 @@ exports[`Storyshots Diff File Controls 1`] = `
               className="control"
             >
               <span
-                className="tooltip has-tooltip-top is-multiline"
+                className="tooltip has-tooltip-top"
                 data-tooltip="A skull and crossbones or death's head is a symbol consisting of a human skull and two long bones crossed together under or behind the skull. The design originates in the Late Middle Ages as a symbol of death and especially as a memento mori on tombstones."
               >
                 <a
@@ -43584,81 +43584,273 @@ exports[`Storyshots Toast Warning 1`] = `null`;
 
 exports[`Storyshots Tooltip Default 1`] = `
 <div
-  className="Tooltipstories__Wrapper-sc-1c34uq-0 kMYfDl"
+  className="Tooltipstories__Wrapper-sc-1c34uq-0 QoXmo"
 >
-  <div>
-    <div
-      className="Tooltipstories__Spacing-sc-1c34uq-1 loCuMv"
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-right"
+      data-tooltip="Heart of Gold"
     >
-      <span
-        className="tooltip has-tooltip-right"
-        data-tooltip="Heart of Gold"
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
       >
-        <button
-          className="button is-info"
-          onClick={[Function]}
-          type="button"
-        >
-          right
-           
-        </button>
+        right
          
-      </span>
-    </div>
-    <div
-      className="Tooltipstories__Spacing-sc-1c34uq-1 loCuMv"
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-top"
+      data-tooltip="Heart of Gold"
     >
-      <span
-        className="tooltip has-tooltip-top"
-        data-tooltip="Heart of Gold"
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
       >
-        <button
-          className="button is-info"
-          onClick={[Function]}
-          type="button"
-        >
-          top
-           
-        </button>
+        top
          
-      </span>
-    </div>
-    <div
-      className="Tooltipstories__Spacing-sc-1c34uq-1 loCuMv"
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-left"
+      data-tooltip="Heart of Gold"
     >
-      <span
-        className="tooltip has-tooltip-left"
-        data-tooltip="Heart of Gold"
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
       >
-        <button
-          className="button is-info"
-          onClick={[Function]}
-          type="button"
-        >
-          left
-           
-        </button>
+        left
          
-      </span>
-    </div>
-    <div
-      className="Tooltipstories__Spacing-sc-1c34uq-1 loCuMv"
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-bottom"
+      data-tooltip="Heart of Gold"
     >
-      <span
-        className="tooltip has-tooltip-bottom"
-        data-tooltip="Heart of Gold"
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
       >
-        <button
-          className="button is-info"
-          onClick={[Function]}
-          type="button"
-        >
-          bottom
-           
-        </button>
+        bottom
          
-      </span>
-    </div>
+      </button>
+       
+    </span>
+  </div>
+</div>
+`;
+
+exports[`Storyshots Tooltip Multiline 1`] = `
+<div
+  className="Tooltipstories__Wrapper-sc-1c34uq-0 QoXmo"
+>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-right"
+      data-tooltip="Characters:
+
+- Arthur Dent
+- Ford Prefect
+- Zaphod Beeblebrox
+- Marvin the Paranoid Android
+- Trillian
+- Slartibartfast"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        right
+         
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-top"
+      data-tooltip="Characters:
+
+- Arthur Dent
+- Ford Prefect
+- Zaphod Beeblebrox
+- Marvin the Paranoid Android
+- Trillian
+- Slartibartfast"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        top
+         
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-left"
+      data-tooltip="Characters:
+
+- Arthur Dent
+- Ford Prefect
+- Zaphod Beeblebrox
+- Marvin the Paranoid Android
+- Trillian
+- Slartibartfast"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        left
+         
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-bottom"
+      data-tooltip="Characters:
+
+- Arthur Dent
+- Ford Prefect
+- Zaphod Beeblebrox
+- Marvin the Paranoid Android
+- Trillian
+- Slartibartfast"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        bottom
+         
+      </button>
+       
+    </span>
+  </div>
+</div>
+`;
+
+exports[`Storyshots Tooltip Short Multiline 1`] = `
+<div
+  className="Tooltipstories__Wrapper-sc-1c34uq-0 QoXmo"
+>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-right"
+      data-tooltip="* a
+* b
+* c"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        right
+         
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-top"
+      data-tooltip="* a
+* b
+* c"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        top
+         
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-left"
+      data-tooltip="* a
+* b
+* c"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        left
+         
+      </button>
+       
+    </span>
+  </div>
+  <div
+    className="Tooltipstories__Spacing-sc-1c34uq-1 fFVjYs"
+  >
+    <span
+      className="tooltip has-tooltip-bottom"
+      data-tooltip="* a
+* b
+* c"
+    >
+      <button
+        className="button is-info"
+        onClick={[Function]}
+        type="button"
+      >
+        bottom
+         
+      </button>
+       
+    </span>
   </div>
 </div>
 `;