From 1b4b3315db700609c86ea2566ddf890fb9c6d658 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Sat, 11 Feb 2012 16:41:06 +0100 Subject: [PATCH] do not fail on wrong basic authorization header --- .../sonia/scm/web/filter/BasicAuthenticationFilter.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/scm-core/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java b/scm-core/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java index a3b6ef5465..342da39d0a 100644 --- a/scm-core/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java +++ b/scm-core/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java @@ -124,13 +124,10 @@ public class BasicAuthenticationFilter extends HttpFilter { user = securityContext.getUser(); } - else if (Util.isNotEmpty(authentication)) + else if (Util.isNotEmpty(authentication) + && authentication.toUpperCase().startsWith( + AUTHORIZATION_BASIC_PREFIX)) { - if (!authentication.toUpperCase().startsWith(AUTHORIZATION_BASIC_PREFIX)) - { - throw new ServletException("wrong basic header"); - } - user = authenticate(request, response, securityContext, authentication); }