From 1ad2ea61f57e0c3576330ec8ba971d68ac045fd0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= <rene.pfeuffer@cloudogu.com>
Date: Thu, 14 Mar 2019 13:42:13 +0100
Subject: [PATCH] Remove not implemented config options

---
 .../src/main/js/GitConfigurationForm.js       |  10 +-
 .../src/main/js/HgConfigurationForm.js        |   2 -
 .../src/main/js/SvnConfigurationForm.js       |  13 +-
 .../config/components/form/GeneralSettings.js | 151 ++++--------------
 4 files changed, 36 insertions(+), 140 deletions(-)

diff --git a/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js b/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js
index 363779c92b..692611510f 100644
--- a/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js
+++ b/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js
@@ -9,7 +9,6 @@ type Configuration = {
   repositoryDirectory?: string,
   gcExpression?: string,
   nonFastForwardDisallowed: boolean,
-  disabled: boolean,
   _links: Links
 }
 
@@ -42,7 +41,7 @@ class GitConfigurationForm extends React.Component<Props, State> {
   };
 
   render() {
-    const { gcExpression, nonFastForwardDisallowed, disabled } = this.state;
+    const { gcExpression, nonFastForwardDisallowed } = this.state;
     const { readOnly, t } = this.props;
 
     return (
@@ -61,13 +60,6 @@ class GitConfigurationForm extends React.Component<Props, State> {
                   onChange={this.handleChange}
                   disabled={readOnly}
         />
-        <Checkbox name="disabled"
-                  label={t("scm-git-plugin.config.disabled")}
-                  helpText={t("scm-git-plugin.config.disabledHelpText")}
-                  checked={disabled}
-                  onChange={this.handleChange}
-                  disabled={readOnly}
-        />
       </>
     );
   }
diff --git a/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js b/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js
index 8e370a70c6..b0935b238e 100644
--- a/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js
+++ b/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js
@@ -13,7 +13,6 @@ type Configuration = {
   "showRevisionInId": boolean,
   "disableHookSSLValidation": boolean,
   "enableHttpPostArgs": boolean,
-  "disabled": boolean,
   "_links": Links
 };
 
@@ -105,7 +104,6 @@ class HgConfigurationForm extends React.Component<Props, State> {
         {this.checkbox("showRevisionInId")}
         {this.checkbox("disableHookSSLValidation")}
         {this.checkbox("enableHttpPostArgs")}
-        {this.checkbox("disabled")}
       </>
     );
   }
diff --git a/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js b/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js
index 3fde8c7888..ac7576a3d1 100644
--- a/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js
+++ b/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js
@@ -7,7 +7,6 @@ import { InputField, Checkbox, Select } from "@scm-manager/ui-components";
 type Configuration = {
   compatibility: string,
   enabledGZip: boolean,
-  disabled: boolean,
   _links: Links
 };
 
@@ -23,7 +22,7 @@ type Props = {
 
 type State = Configuration;
 
-class HgConfigurationForm extends React.Component<Props, State> {
+class SvnConfigurationForm extends React.Component<Props, State> {
 
   constructor(props: Props) {
     super(props);
@@ -76,18 +75,10 @@ class HgConfigurationForm extends React.Component<Props, State> {
           onChange={this.handleChange}
           disabled={readOnly}
         />
-        <Checkbox
-          name="disabled"
-          label={t("scm-svn-plugin.config.disabled")}
-          helpText={t("scm-svn-plugin.config.disabledHelpText")}
-          checked={this.state.disabled}
-          onChange={this.handleChange}
-          disabled={readOnly}
-        />
       </>
     );
   }
 
 }
 
-export default translate("plugins")(HgConfigurationForm);
+export default translate("plugins")(SvnConfigurationForm);
diff --git a/scm-ui/src/config/components/form/GeneralSettings.js b/scm-ui/src/config/components/form/GeneralSettings.js
index b221eb4d6a..67de20ddc1 100644
--- a/scm-ui/src/config/components/form/GeneralSettings.js
+++ b/scm-ui/src/config/components/form/GeneralSettings.js
@@ -1,7 +1,7 @@
 // @flow
 import React from "react";
 import { translate } from "react-i18next";
-import { Checkbox, InputField} from "@scm-manager/ui-components";
+import { Checkbox, InputField } from "@scm-manager/ui-components";
 import type { NamespaceStrategies } from "@scm-manager/ui-types";
 import NamespaceStrategySelect from "./NamespaceStrategySelect";
 
@@ -23,17 +23,10 @@ type Props = {
 };
 
 class GeneralSettings extends React.Component<Props> {
-
   render() {
     const {
       t,
       realmDescription,
-      enableRepositoryArchive,
-      disableGroupingGrid,
-      dateFormat,
-      anonymousAccessEnabled,
-      skipFailedAuthenticators,
-      pluginUrl,
       enabledXsrfProtection,
       namespaceStrategy,
       hasUpdatePermission,
@@ -42,123 +35,45 @@ class GeneralSettings extends React.Component<Props> {
 
     return (
       <div>
-          <div className="columns">
-            <div className="column is-half">
-                <InputField
-                  label={t("general-settings.realm-description")}
-                  onChange={this.handleRealmDescriptionChange}
-                  value={realmDescription}
-                  disabled={!hasUpdatePermission}
-                  helpText={t("help.realmDescriptionHelpText")}
-                />
-                </div>
-                <div className="column is-half">
-                <InputField
-                  label={t("general-settings.date-format")}
-                  onChange={this.handleDateFormatChange}
-                  value={dateFormat}
-                  disabled={!hasUpdatePermission}
-                  helpText={t("help.dateFormatHelpText")}
-                />
-                </div>
-            </div>
-            <div className="columns">
-                <div className="column is-half">
-                <InputField
-                  label={t("general-settings.plugin-url")}
-                  onChange={this.handlePluginUrlChange}
-                  value={pluginUrl}
-                  disabled={!hasUpdatePermission}
-                  helpText={t("help.pluginRepositoryHelpText")}
-                />
-                </div>
-                <div className="column is-half">
-                  <NamespaceStrategySelect
-                    label={t("general-settings.namespace-strategy")}
-                    onChange={this.handleNamespaceStrategyChange}
-                    value={namespaceStrategy}
-                    disabled={!hasUpdatePermission}
-                    namespaceStrategies={namespaceStrategies}
-                    helpText={t("help.nameSpaceStrategyHelpText")}
-                  />
-                </div>
-            </div>
-            <div className="columns">
-                <div className="column is-half">
-                    <Checkbox
-                      checked={enabledXsrfProtection}
-                      label={t("general-settings.enabled-xsrf-protection")}
-                      onChange={this.handleEnabledXsrfProtectionChange}
-                      disabled={!hasUpdatePermission}
-                      helpText={t("help.enableXsrfProtectionHelpText")}
-                    />
-                </div>
-                <div className="column is-half">
-                    <Checkbox
-                      checked={enableRepositoryArchive}
-                      label={t("general-settings.enable-repository-archive")}
-                      onChange={this.handleEnableRepositoryArchiveChange}
-                      disabled={!hasUpdatePermission}
-                      helpText={t("help.enableRepositoryArchiveHelpText")}
-                    />
-                </div>
-            </div>
-            <div className="columns">
-                <div className="column is-half">
-                    <Checkbox
-                      checked={disableGroupingGrid}
-                      label={t("general-settings.disable-grouping-grid")}
-                      onChange={this.handleDisableGroupingGridChange}
-                      disabled={!hasUpdatePermission}
-                      helpText={t("help.disableGroupingGridHelpText")}
-                    />
-                </div>
-                <div className="column is-half">
-                    <Checkbox
-                      checked={anonymousAccessEnabled}
-                      label={t("general-settings.anonymous-access-enabled")}
-                      onChange={this.handleAnonymousAccessEnabledChange}
-                      disabled={!hasUpdatePermission}
-                      helpText={t("help.allowAnonymousAccessHelpText")}
-                    />
-                </div>
-            </div>
-            <div className="columns">
-                <div className="column is-half">
-                    <Checkbox
-                      checked={skipFailedAuthenticators}
-                      label={t("general-settings.skip-failed-authenticators")}
-                      onChange={this.handleSkipFailedAuthenticatorsChange}
-                      disabled={!hasUpdatePermission}
-                      helpText={t("help.skipFailedAuthenticatorsHelpText")}
-                    />
-                </div>
-            </div>
+        <div className="columns">
+          <div className="column is-half">
+            <InputField
+              label={t("general-settings.realm-description")}
+              onChange={this.handleRealmDescriptionChange}
+              value={realmDescription}
+              disabled={!hasUpdatePermission}
+              helpText={t("help.realmDescriptionHelpText")}
+            />
           </div>
+          <div className="column is-half">
+            <NamespaceStrategySelect
+              label={t("general-settings.namespace-strategy")}
+              onChange={this.handleNamespaceStrategyChange}
+              value={namespaceStrategy}
+              disabled={!hasUpdatePermission}
+              namespaceStrategies={namespaceStrategies}
+              helpText={t("help.nameSpaceStrategyHelpText")}
+            />
+          </div>
+        </div>
+        <div className="columns">
+          <div className="column is-half">
+            <Checkbox
+              checked={enabledXsrfProtection}
+              label={t("general-settings.enabled-xsrf-protection")}
+              onChange={this.handleEnabledXsrfProtectionChange}
+              disabled={!hasUpdatePermission}
+              helpText={t("help.enableXsrfProtectionHelpText")}
+            />
+          </div>
+        </div>
+      </div>
     );
   }
 
   handleRealmDescriptionChange = (value: string) => {
     this.props.onChange(true, value, "realmDescription");
   };
-  handleEnableRepositoryArchiveChange = (value: boolean) => {
-    this.props.onChange(true, value, "enableRepositoryArchive");
-  };
-  handleDisableGroupingGridChange = (value: boolean) => {
-    this.props.onChange(true, value, "disableGroupingGrid");
-  };
-  handleDateFormatChange = (value: string) => {
-    this.props.onChange(true, value, "dateFormat");
-  };
-  handleAnonymousAccessEnabledChange = (value: string) => {
-    this.props.onChange(true, value, "anonymousAccessEnabled");
-  };
-  handleSkipFailedAuthenticatorsChange = (value: string) => {
-    this.props.onChange(true, value, "skipFailedAuthenticators");
-  };
-  handlePluginUrlChange = (value: string) => {
-    this.props.onChange(true, value, "pluginUrl");
-  };
   handleEnabledXsrfProtectionChange = (value: boolean) => {
     this.props.onChange(true, value, "enabledXsrfProtection");
   };