From 0fdc458b9f9cd0f948298640dbe8d4e5caf7723f Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Fri, 3 Jan 2014 15:18:56 +0100 Subject: [PATCH] modified pathes should be private --- .../sonia/scm/repository/Modifications.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scm-core/src/main/java/sonia/scm/repository/Modifications.java b/scm-core/src/main/java/sonia/scm/repository/Modifications.java index 5ce5779031..88bdad679a 100644 --- a/scm-core/src/main/java/sonia/scm/repository/Modifications.java +++ b/scm-core/src/main/java/sonia/scm/repository/Modifications.java @@ -36,6 +36,7 @@ package sonia.scm.repository; //~--- non-JDK imports -------------------------------------------------------- import com.google.common.base.Objects; +import com.google.common.collect.Lists; import sonia.scm.util.Util; @@ -43,7 +44,6 @@ import sonia.scm.util.Util; import java.io.Serializable; -import java.util.ArrayList; import java.util.List; import javax.xml.bind.annotation.XmlAccessType; @@ -104,7 +104,7 @@ public class Modifications implements Serializable * @param removed */ public Modifications(List added, List modified, - List removed) + List removed) { this.added = added; this.modified = modified; @@ -137,8 +137,8 @@ public class Modifications implements Serializable final Modifications other = (Modifications) obj; return Objects.equal(added, other.added) - && Objects.equal(modified, other.modified) - && Objects.equal(removed, other.removed); + && Objects.equal(modified, other.modified) + && Objects.equal(removed, other.removed); } /** @@ -183,7 +183,7 @@ public class Modifications implements Serializable { if (added == null) { - added = new ArrayList(); + added = Lists.newArrayList(); } return added; @@ -199,7 +199,7 @@ public class Modifications implements Serializable { if (modified == null) { - modified = new ArrayList(); + modified = Lists.newArrayList(); } return modified; @@ -215,7 +215,7 @@ public class Modifications implements Serializable { if (removed == null) { - removed = new ArrayList(); + removed = Lists.newArrayList(); } return removed; @@ -261,15 +261,15 @@ public class Modifications implements Serializable /** list of added files */ @XmlElement(name = "file") @XmlElementWrapper(name = "added") - public List added; + private List added; /** list of modified files */ @XmlElement(name = "file") @XmlElementWrapper(name = "modified") - public List modified; + private List modified; /** list of removed files */ @XmlElement(name = "file") @XmlElementWrapper(name = "removed") - public List removed; + private List removed; }