From 0c138e46d623ba957cbeba4f5d954379c60153e5 Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Mon, 16 Sep 2019 17:39:22 +0200 Subject: [PATCH] use Tag component instead --- .../ui-components/src/repos/DiffFile.js | 32 ++++++++++--------- .../src/repos/changesets/ChangesetTag.js | 2 +- .../src/repos/changesets/ChangesetTagBase.js | 22 +++---------- .../changesets/ChangesetTagsCollapsed.js | 13 +++++--- 4 files changed, 31 insertions(+), 38 deletions(-) diff --git a/scm-ui-components/packages/ui-components/src/repos/DiffFile.js b/scm-ui-components/packages/ui-components/src/repos/DiffFile.js index 26582ed820..34762794ea 100644 --- a/scm-ui-components/packages/ui-components/src/repos/DiffFile.js +++ b/scm-ui-components/packages/ui-components/src/repos/DiffFile.js @@ -1,10 +1,18 @@ //@flow import React from "react"; -import {Change, Diff as DiffComponent, DiffObjectProps, File, getChangeKey, Hunk} from "react-diff-view"; +import { + Change, + Diff as DiffComponent, + DiffObjectProps, + File, + getChangeKey, + Hunk +} from "react-diff-view"; import injectSheets from "react-jss"; import classNames from "classnames"; -import {translate} from "react-i18next"; -import {Button, ButtonGroup} from "../buttons"; +import { translate } from "react-i18next"; +import { Button, ButtonGroup } from "../buttons"; +import Tag from "../Tag"; const styles = { panel: { @@ -183,24 +191,18 @@ class DiffFile extends React.Component { value = file.type; } const color = - value === "added" - ? "is-success" - : value === "deleted" - ? "is-danger" - : "is-info"; + value === "added" ? "success" : value === "deleted" ? "danger" : "info"; return ( - - {value} - + color={color} + label={value} + /> ); }; @@ -232,7 +234,7 @@ class DiffFile extends React.Component { ); } - const collapseIcon = collapsible? : null; + const collapseIcon = collapsible ? : null; const fileControls = fileControlFactory ? fileControlFactory(file, this.setCollapse) diff --git a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTag.js b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTag.js index 03c73a8e9f..656839cc8e 100644 --- a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTag.js +++ b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTag.js @@ -10,7 +10,7 @@ type Props = { class ChangesetTag extends React.Component { render() { const { tag } = this.props; - return ; + return ; } } diff --git a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagBase.js b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagBase.js index a62c6292a3..dd619b0cb6 100644 --- a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagBase.js +++ b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagBase.js @@ -1,31 +1,19 @@ //@flow import React from "react"; -import injectSheet from "react-jss"; -import classNames from "classnames"; - -const styles = { - spacing: { - marginRight: ".25rem" - } -}; +import Tag from "../../Tag"; type Props = { icon: string, - label: string, - - // context props - classes: Object + label: string }; class ChangesetTagBase extends React.Component { render() { - const { icon, label, classes } = this.props; + const { icon, label } = this.props; return ( - - {label} - + ); } } -export default injectSheet(styles)(ChangesetTagBase); +export default ChangesetTagBase; diff --git a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagsCollapsed.js b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagsCollapsed.js index 50b09d4d65..f0baf601af 100644 --- a/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagsCollapsed.js +++ b/scm-ui-components/packages/ui-components/src/repos/changesets/ChangesetTagsCollapsed.js @@ -1,24 +1,27 @@ //@flow import React from "react"; -import type { Tag } from "@scm-manager/ui-types"; -import ChangesetTagBase from "./ChangesetTagBase"; import { translate } from "react-i18next"; +import type { Tag } from "@scm-manager/ui-types"; import Tooltip from "../../Tooltip"; +import ChangesetTagBase from "./ChangesetTagBase"; type Props = { tags: Tag[], // context props - t: (string) => string + t: string => string }; class ChangesetTagsCollapsed extends React.Component { render() { const { tags, t } = this.props; - const message = tags.map((tag) => tag.name).join(", "); + const message = tags.map(tag => tag.name).join(", "); return ( - + ); }