2018-08-22 09:18:17 +02:00
|
|
|
/*
|
2020-03-23 15:35:58 +01:00
|
|
|
* MIT License
|
2018-08-22 09:18:17 +02:00
|
|
|
*
|
2020-03-23 15:35:58 +01:00
|
|
|
* Copyright (c) 2020-present Cloudogu GmbH and Contributors
|
2018-08-22 09:18:17 +02:00
|
|
|
*
|
2020-03-23 15:35:58 +01:00
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
|
* furnished to do so, subject to the following conditions:
|
2018-08-22 09:18:17 +02:00
|
|
|
*
|
2020-03-23 15:35:58 +01:00
|
|
|
* The above copyright notice and this permission notice shall be included in all
|
|
|
|
|
* copies or substantial portions of the Software.
|
2018-08-22 09:18:17 +02:00
|
|
|
*
|
2020-03-23 15:35:58 +01:00
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
|
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
|
|
|
* SOFTWARE.
|
2018-08-22 09:18:17 +02:00
|
|
|
*/
|
2020-03-23 15:35:58 +01:00
|
|
|
|
2018-08-22 09:18:17 +02:00
|
|
|
package sonia.scm.it;
|
|
|
|
|
|
|
|
|
|
import org.apache.http.HttpStatus;
|
2018-11-09 10:13:36 +01:00
|
|
|
import org.assertj.core.api.Assertions;
|
2018-08-22 09:18:17 +02:00
|
|
|
import org.junit.Before;
|
|
|
|
|
import org.junit.Rule;
|
|
|
|
|
import org.junit.Test;
|
|
|
|
|
import org.junit.rules.TemporaryFolder;
|
|
|
|
|
import org.junit.runner.RunWith;
|
|
|
|
|
import org.junit.runners.Parameterized;
|
|
|
|
|
import org.junit.runners.Parameterized.Parameters;
|
2018-09-19 15:54:24 +02:00
|
|
|
import sonia.scm.it.utils.RepositoryUtil;
|
|
|
|
|
import sonia.scm.it.utils.TestData;
|
2018-08-22 09:18:17 +02:00
|
|
|
import sonia.scm.repository.client.api.RepositoryClient;
|
2018-08-22 10:59:46 +02:00
|
|
|
import sonia.scm.repository.client.api.RepositoryClientException;
|
|
|
|
|
import sonia.scm.web.VndMediaType;
|
2018-08-22 09:18:17 +02:00
|
|
|
|
|
|
|
|
import java.io.IOException;
|
|
|
|
|
import java.util.Collection;
|
|
|
|
|
import java.util.List;
|
2018-11-09 10:13:36 +01:00
|
|
|
import java.util.Map;
|
2018-08-22 09:18:17 +02:00
|
|
|
import java.util.Objects;
|
|
|
|
|
|
2018-11-09 10:13:36 +01:00
|
|
|
import static java.util.Arrays.asList;
|
2018-08-22 10:59:46 +02:00
|
|
|
import static org.junit.Assert.assertEquals;
|
2018-08-22 12:20:09 +02:00
|
|
|
import static org.junit.Assert.assertNull;
|
2018-09-19 15:54:24 +02:00
|
|
|
import static sonia.scm.it.utils.RepositoryUtil.addAndCommitRandomFile;
|
|
|
|
|
import static sonia.scm.it.utils.RestUtil.given;
|
|
|
|
|
import static sonia.scm.it.utils.ScmTypes.availableScmTypes;
|
2019-01-23 09:47:38 +01:00
|
|
|
import static sonia.scm.it.utils.TestData.OWNER;
|
|
|
|
|
import static sonia.scm.it.utils.TestData.READ;
|
2018-09-19 15:54:24 +02:00
|
|
|
import static sonia.scm.it.utils.TestData.USER_SCM_ADMIN;
|
2019-01-23 09:47:38 +01:00
|
|
|
import static sonia.scm.it.utils.TestData.WRITE;
|
2018-09-19 15:54:24 +02:00
|
|
|
import static sonia.scm.it.utils.TestData.callRepository;
|
2018-08-22 09:18:17 +02:00
|
|
|
|
|
|
|
|
@RunWith(Parameterized.class)
|
|
|
|
|
public class PermissionsITCase {
|
|
|
|
|
|
|
|
|
|
public static final String USER_READ = "user_read";
|
|
|
|
|
public static final String USER_PASS = "pass";
|
|
|
|
|
private static final String USER_WRITE = "user_write";
|
|
|
|
|
private static final String USER_OWNER = "user_owner";
|
2018-08-22 11:19:19 +02:00
|
|
|
private static final String USER_OTHER = "user_other";
|
2018-08-22 09:18:17 +02:00
|
|
|
|
|
|
|
|
@Rule
|
|
|
|
|
public TemporaryFolder temporaryFolder = new TemporaryFolder();
|
|
|
|
|
|
|
|
|
|
private final String repositoryType;
|
2018-11-09 10:13:36 +01:00
|
|
|
private Collection<String> createdPermissions;
|
2018-08-22 09:18:17 +02:00
|
|
|
|
|
|
|
|
|
|
|
|
|
public PermissionsITCase(String repositoryType) {
|
|
|
|
|
this.repositoryType = repositoryType;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Parameters(name = "{0}")
|
|
|
|
|
public static Collection<String> createParameters() {
|
|
|
|
|
return availableScmTypes();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Before
|
|
|
|
|
public void prepareEnvironment() {
|
|
|
|
|
TestData.createDefault();
|
2018-10-12 11:06:53 +02:00
|
|
|
TestData.createNotAdminUser(USER_READ, USER_PASS);
|
2019-01-23 09:47:38 +01:00
|
|
|
TestData.createUserPermission(USER_READ, READ, repositoryType);
|
|
|
|
|
TestData.createNotAdminUser(USER_WRITE, USER_PASS);
|
|
|
|
|
TestData.createUserPermission(USER_WRITE, WRITE, repositoryType);
|
|
|
|
|
TestData.createNotAdminUser(USER_OWNER, USER_PASS);
|
|
|
|
|
TestData.createUserPermission(USER_OWNER, OWNER, repositoryType);
|
|
|
|
|
TestData.createNotAdminUser(USER_OTHER, USER_PASS);
|
2018-11-09 10:13:36 +01:00
|
|
|
createdPermissions = asList(USER_READ, USER_WRITE, USER_OWNER);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
2018-08-22 12:20:09 +02:00
|
|
|
public void readUserShouldNotSeePermissions() {
|
2018-08-27 13:04:05 +02:00
|
|
|
assertNull(callRepository(USER_READ, USER_PASS, repositoryType, HttpStatus.SC_OK)
|
2018-08-22 12:20:09 +02:00
|
|
|
.extract()
|
|
|
|
|
.body().jsonPath().getString("_links.permissions.href"));
|
2018-08-22 11:19:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
2018-08-22 12:20:09 +02:00
|
|
|
public void readUserShouldNotSeeBruteForcePermissions() {
|
2019-01-23 11:19:55 +01:00
|
|
|
given(VndMediaType.REPOSITORY_PERMISSION, USER_READ, USER_PASS)
|
2018-08-22 12:20:09 +02:00
|
|
|
.when()
|
|
|
|
|
.get(TestData.getDefaultPermissionUrl(USER_SCM_ADMIN, USER_SCM_ADMIN, repositoryType))
|
|
|
|
|
.then()
|
|
|
|
|
.statusCode(HttpStatus.SC_FORBIDDEN);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void writeUserShouldNotSeePermissions() {
|
|
|
|
|
assertNull(callRepository(USER_WRITE, USER_PASS, repositoryType, HttpStatus.SC_OK)
|
|
|
|
|
.extract()
|
|
|
|
|
.body().jsonPath().getString("_links.permissions.href"));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void writeUserShouldNotSeeBruteForcePermissions() {
|
2019-01-23 11:19:55 +01:00
|
|
|
given(VndMediaType.REPOSITORY_PERMISSION, USER_WRITE, USER_PASS)
|
2018-08-22 12:20:09 +02:00
|
|
|
.when()
|
|
|
|
|
.get(TestData.getDefaultPermissionUrl(USER_SCM_ADMIN, USER_SCM_ADMIN, repositoryType))
|
|
|
|
|
.then()
|
|
|
|
|
.statusCode(HttpStatus.SC_FORBIDDEN);
|
2018-08-22 11:19:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void ownerShouldSeePermissions() {
|
2018-11-09 10:13:36 +01:00
|
|
|
List<Map> userPermissions = TestData.getUserPermissions(USER_OWNER, USER_PASS, repositoryType);
|
|
|
|
|
Assertions.assertThat(userPermissions).extracting(e -> e.get("name")).containsAll(createdPermissions);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
2018-08-22 12:20:09 +02:00
|
|
|
public void otherUserShouldNotSeeRepository() {
|
|
|
|
|
callRepository(USER_OTHER, USER_PASS, repositoryType, HttpStatus.SC_FORBIDDEN);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void otherUserShouldNotSeeBruteForcePermissions() {
|
2019-01-23 11:19:55 +01:00
|
|
|
given(VndMediaType.REPOSITORY_PERMISSION, USER_OTHER, USER_PASS)
|
2018-08-22 12:20:09 +02:00
|
|
|
.when()
|
|
|
|
|
.get(TestData.getDefaultPermissionUrl(USER_SCM_ADMIN, USER_SCM_ADMIN, repositoryType))
|
|
|
|
|
.then()
|
|
|
|
|
.statusCode(HttpStatus.SC_FORBIDDEN);
|
2018-08-22 11:19:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void readUserShouldCloneRepository() throws IOException {
|
2018-08-22 09:18:17 +02:00
|
|
|
RepositoryClient client = RepositoryUtil.createRepositoryClient(repositoryType, temporaryFolder.newFolder(), USER_READ, USER_PASS);
|
|
|
|
|
assertEquals(1, Objects.requireNonNull(client.getWorkingCopy().list()).length);
|
2018-08-22 11:19:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void writeUserShouldCloneRepository() throws IOException {
|
|
|
|
|
RepositoryClient client = RepositoryUtil.createRepositoryClient(repositoryType, temporaryFolder.newFolder(), USER_WRITE, USER_PASS);
|
2018-08-22 09:18:17 +02:00
|
|
|
assertEquals(1, Objects.requireNonNull(client.getWorkingCopy().list()).length);
|
2018-08-22 11:19:19 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void ownerShouldCloneRepository() throws IOException {
|
|
|
|
|
RepositoryClient client = RepositoryUtil.createRepositoryClient(repositoryType, temporaryFolder.newFolder(), USER_OWNER, USER_PASS);
|
2018-08-22 09:18:17 +02:00
|
|
|
assertEquals(1, Objects.requireNonNull(client.getWorkingCopy().list()).length);
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-22 11:19:19 +02:00
|
|
|
@Test
|
|
|
|
|
public void otherUserShouldNotCloneRepository() {
|
|
|
|
|
TestData.callRepository(USER_OTHER, USER_PASS, repositoryType, HttpStatus.SC_FORBIDDEN);
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-22 10:59:46 +02:00
|
|
|
@Test(expected = RepositoryClientException.class)
|
|
|
|
|
public void userWithReadPermissionShouldBeNotAuthorizedToCommit() throws IOException {
|
|
|
|
|
createAndCommit(USER_READ);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void userWithOwnerPermissionShouldBeAuthorizedToCommit() throws IOException {
|
2018-08-22 10:59:46 +02:00
|
|
|
createAndCommit(USER_OWNER);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
|
|
|
|
public void userWithWritePermissionShouldBeAuthorizedToCommit() throws IOException {
|
2018-08-22 10:59:46 +02:00
|
|
|
createAndCommit(USER_WRITE);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private void createAndCommit(String username) throws IOException {
|
|
|
|
|
RepositoryClient client = RepositoryUtil.createRepositoryClient(repositoryType, temporaryFolder.newFolder(), username, PermissionsITCase.USER_PASS);
|
|
|
|
|
addAndCommitRandomFile(client, username);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
2018-08-22 10:59:46 +02:00
|
|
|
public void userWithOwnerPermissionShouldBeAuthorizedToDeleteRepository(){
|
|
|
|
|
assertDeleteRepositoryOperation(HttpStatus.SC_NO_CONTENT, HttpStatus.SC_NOT_FOUND, USER_OWNER, repositoryType);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
2018-08-22 10:59:46 +02:00
|
|
|
public void userWithReadPermissionShouldNotBeAuthorizedToDeleteRepository(){
|
|
|
|
|
assertDeleteRepositoryOperation(HttpStatus.SC_FORBIDDEN, HttpStatus.SC_OK, USER_READ, repositoryType);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
@Test
|
2018-08-22 10:59:46 +02:00
|
|
|
public void userWithWritePermissionShouldNotBeAuthorizedToDeleteRepository(){
|
|
|
|
|
assertDeleteRepositoryOperation(HttpStatus.SC_FORBIDDEN, HttpStatus.SC_OK, USER_WRITE, repositoryType);
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|
|
|
|
|
|
2018-08-22 10:59:46 +02:00
|
|
|
private void assertDeleteRepositoryOperation(int expectedDeleteStatus, int expectedGetStatus, String user, String repositoryType) {
|
|
|
|
|
given(VndMediaType.REPOSITORY, user, PermissionsITCase.USER_PASS)
|
|
|
|
|
|
|
|
|
|
.when()
|
|
|
|
|
.delete(TestData.getDefaultRepositoryUrl(repositoryType))
|
|
|
|
|
|
|
|
|
|
.then()
|
|
|
|
|
.statusCode(expectedDeleteStatus);
|
|
|
|
|
|
|
|
|
|
given(VndMediaType.REPOSITORY, user, PermissionsITCase.USER_PASS)
|
|
|
|
|
|
|
|
|
|
.when()
|
|
|
|
|
.get(TestData.getDefaultRepositoryUrl(repositoryType))
|
|
|
|
|
|
|
|
|
|
.then()
|
|
|
|
|
.statusCode(expectedGetStatus);
|
|
|
|
|
}
|
2018-08-22 09:18:17 +02:00
|
|
|
}
|