Commit Graph

3357 Commits

Author SHA1 Message Date
Go MAEDA
b5fc96cb74 Filter operator "doesn't contain" on custom fields ignores issues with no value (#38055).
Patch by Tomoko Shimizu (user:tomokosimi), Takashi Kato (user:tohosaku), Mizuki ISHIKAWA (user:ishikawa999) and Ko Nagase (user:sanak).


git-svn-id: https://svn.redmine.org/redmine/trunk@24432 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-19 03:24:36 +00:00
Go MAEDA
47e3c27e93 CSV import fails on CRLF files when first row has quoted field with newline (#41434).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24428 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-18 21:42:44 +00:00
Go MAEDA
755ae9424e Make first and last name field order follow Users display format setting (#4507).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24422 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-18 00:37:29 +00:00
Go MAEDA
bbcbfec138 Change default admin email to admin@dummy.invalid for clarity (#43808).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-16 08:51:46 +00:00
Go MAEDA
9af55cc312 Avoid updating updated_on when submitting the issue edit form without changes (#33610).
Patch by Yuichi HARADA (user:yui.har).


git-svn-id: https://svn.redmine.org/redmine/trunk@24415 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-02-16 08:40:52 +00:00
Marius Balteanu
1dfd165cbd Improve search filter in LDAP authentication (#43692).
git-svn-id: https://svn.redmine.org/redmine/trunk@24366 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-25 15:26:25 +00:00
Marius Balteanu
473270b63a Check issue visibility inside Journal#add_watcher (#2716).
git-svn-id: https://svn.redmine.org/redmine/trunk@24314 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-15 06:57:41 +00:00
Marius Balteanu
2d8ccf778d Add user option to auto-watch issues previously assigned to me (#2716).
git-svn-id: https://svn.redmine.org/redmine/trunk@24312 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-14 06:56:34 +00:00
Marius Balteanu
23a93e0e06 Use MIME type instead of the is_pdf flag to detect PDFs when generating thumbnails (#43451).
Patch by Go MAEDA (user:maeda).



git-svn-id: https://svn.redmine.org/redmine/trunk@24266 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-05 08:30:07 +00:00
Marius Balteanu
a2069c2982 Improve issue visibility checks in attachment related methods (#43635).
git-svn-id: https://svn.redmine.org/redmine/trunk@24262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-05 08:25:11 +00:00
Marius Balteanu
1b0307b02d Fix 500 error when saving a custom field with an invalid regular expression (#43521).
git-svn-id: https://svn.redmine.org/redmine/trunk@24259 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-05 08:21:44 +00:00
Go MAEDA
2bec5b6e36 Revert r24229 (#43619).
The change causes PG::GroupingError on PostgreSQL.


git-svn-id: https://svn.redmine.org/redmine/trunk@24230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-24 07:05:02 +00:00
Go MAEDA
947fe1fff2 Optimize Issue#recalculate_attributes_for by merging date queries (#43619).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24229 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-24 06:27:52 +00:00
Go MAEDA
a62c38037a Revert r24223 (#43607).
This change could prevent done ratio recalculation for higher-level parent issues when estimated hours change.


git-svn-id: https://svn.redmine.org/redmine/trunk@24228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-22 08:35:21 +00:00
Go MAEDA
812399e99a Optimize Issue#recalculate_attributes_for to avoid unnecessary saves and cascading callbacks (#43607).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24223 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-20 02:04:26 +00:00
Marius Balteanu
5141701b78 Temporary disable Lint/DuplicateBranch in webhook_payload.rb (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24208 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-08 09:27:57 +00:00
Marius Balteanu
28402ec9bd Use Time.now for news.updated webook event payload (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24207 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-08 08:50:01 +00:00
Marius Balteanu
fffed57cd7 Reverts unwanted change (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24205 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-08 08:35:17 +00:00
Marius Balteanu
c749dc2bd3 Adds webooks for versions (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24204 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-06 13:59:14 +00:00
Marius Balteanu
ea0a6dfbcb Adds webooks for news (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24203 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-06 13:58:51 +00:00
Marius Balteanu
6bc29c40fd Adds webhook events for time entries (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24202 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-06 12:38:39 +00:00
Marius Balteanu
8c229711d5 Adds webhook events for WikiPage (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-03 22:31:03 +00:00
Go MAEDA
157986c778 Fix RuboCop Rails/OrderArguments (#43438).
git-svn-id: https://svn.redmine.org/redmine/trunk@24125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-05 07:41:46 +00:00
Go MAEDA
73b81d4634 Fix RuboCop Layout/BeginEndAlignment (#43437).
git-svn-id: https://svn.redmine.org/redmine/trunk@24122 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-05 07:00:59 +00:00
Go MAEDA
48a0e9ade2 Fix RuboCop Style/RedundantRegexpEscape (#43437).
git-svn-id: https://svn.redmine.org/redmine/trunk@24120 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-05 06:56:50 +00:00
Go MAEDA
3a3194bbd5 Add copyright headers to webhook-related files (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-03 09:28:35 +00:00
Marius Balteanu
124ffa3e8b Removes to do and keep the original option (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24076 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-27 21:03:28 +00:00
Marius Balteanu
31ce3c99c2 Allow administrators to disable webhooks from settings (#29664).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-27 20:35:17 +00:00
Go MAEDA
36e083a7a6 Fix RuboCop offense: Style/CommentAnnotation (#29664).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24038 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-08 04:53:12 +00:00
Marius Balteanu
c0ee562c9f Temporary disable Rails/HasAndBelongsToMany offense,
git-svn-id: https://svn.redmine.org/redmine/trunk@24037 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-07 10:58:02 +00:00
Marius Balteanu
a524967fbc Adds the :use_webhooks permission in order to allow users to use webhooks only in projects where they have this permission. This is checked when a hook is saved, and before a hook runs (#29664).
Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-07 06:51:33 +00:00
Marius Balteanu
d90d192f48 Introduces issue webhooks (#29664):
* users can set up hooks for issue creation, update and deletion events, for any number of projects
* hooks run in the context of the creating user, and only if the object in question is visible to that user
* the actual HTTP call is done in ActiveJob
* webhook calls are optionally signed the same way GitHub does

Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24034 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-07 06:49:14 +00:00
Go MAEDA
be78fbb34c Replace multiple projects.status <> ... conditions with projects.status IN (...) for optimizer-friendliness in Project.allowed_to_condition (#43214).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23979 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-17 01:02:16 +00:00
Marius Balteanu
2d44c48657 Makes 'auto watch issues' default user settings configurable (#42880).
Patch by Jan Catrysse (user:jcatrysse).

git-svn-id: https://svn.redmine.org/redmine/trunk@23956 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 08:02:04 +00:00
Marius Balteanu
bd034751bf Clear non-editable custom fields when creating an issue (43161).
This ensures that only editable custom fields are saved on a new issue
when copying an existing one. 

Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23945 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:18:55 +00:00
Marius Balteanu
bffc7cce58 Removes undesired change introduced in r23903 (#29824).
git-svn-id: https://svn.redmine.org/redmine/trunk@23904 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-07 20:26:30 +00:00
Marius Balteanu
458072ab7d When the Gravatar service is disabled, display the user's initials as a fallback avatar. This provides a consistent user interface than the generic icon (#29824).
git-svn-id: https://svn.redmine.org/redmine/trunk@23903 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-07 19:07:33 +00:00
Marius Balteanu
ae3cb747bb Adds method @initials@ to @Principal@ and return @nil@ by default (#42623).
git-svn-id: https://svn.redmine.org/redmine/trunk@23888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-15 05:20:23 +00:00
Marius Balteanu
2d3b3b939e Add OAuth2 provider capability using doorkeeper gem (#24808).
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-12 07:09:03 +00:00
Marius Balteanu
e56d84b632 Reverts r23835 due to wrong issue ID (#40856).
git-svn-id: https://svn.redmine.org/redmine/trunk@23836 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-12 07:05:01 +00:00
Marius Balteanu
ebdd1a40f4 Add OAuth2 provider capability using doorkeeper gem (#40856).
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23835 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-11 20:30:44 +00:00
Go MAEDA
40ab48325e Replace nil check using ternary operator with safe navigation operator when accessing hashes (#41884).
Using the ternary operator for nil checking caused a runtime error in the Style/SafeNavigation cop during `rubocop --regenerate-todo` with RuboCop 1.76.0. Replacing it with the safe navigation operator avoids the error.


git-svn-id: https://svn.redmine.org/redmine/trunk@23824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-08 02:12:29 +00:00
Go MAEDA
ddd7beecf1 Fix RuboCop Lint/UselessOr (#41884).
git-svn-id: https://svn.redmine.org/redmine/trunk@23822 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-06 09:13:25 +00:00
Go MAEDA
e7703a0170 Show reaction counts and user names only for reactions visible to the logged-in user (#42630).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23768 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-15 05:01:54 +00:00
Marius Balteanu
66e2d1a9a9 Adds Initials to the list of default gratavar options (#42623).
git-svn-id: https://svn.redmine.org/redmine/trunk@23767 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-14 19:41:04 +00:00
Go MAEDA
403c10091f Introduce reactions feature (so-called "like button") to issues, notes, news, and forums (#42630).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23755 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-11 07:59:16 +00:00
Go MAEDA
7e4acb6b23 Optimize Version::FixedIssuesExtension#issues_progress by avoiding repeated Issue#closed? calls (#42673).
Since the issues are already filtered by open or closed status using the `open` argument through the `self.open(open)` scope, the call to expensive method `Issue#closed?` can be safely replaced with a check of the `open` argument.

Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-06 06:45:36 +00:00
Go MAEDA
9052d4d05b Optimize watchers list rendering by eager loading email addresses (#42589).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23722 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-27 08:27:08 +00:00
Go MAEDA
646bb36874 Joining both atom_token and api_token on the User model causes an error due to the ambiguous column name "action" (#42622).
Patch by Lorin Thwaits (user:lorint).


git-svn-id: https://svn.redmine.org/redmine/trunk@23712 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-25 04:37:30 +00:00
Go MAEDA
a1b5495e89 Fix Rubocop Style/ArgumentsForwarding (#42496).
git-svn-id: https://svn.redmine.org/redmine/trunk@23698 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-21 05:57:01 +00:00