Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2026-01-20 22:43:10 +01:00
Code Issues Packages Projects Releases Activity
19,237 Commits 35 Branches 225 Tags
661b05d9f32cc171b94de7d5313fa253d509ea50
Commit Graph

523 Commits

Author SHA1 Message Date
Marius Balteanu
a2069c2982 Improve issue visibility checks in attachment related methods (#43635). 
git-svn-id: https://svn.redmine.org/redmine/trunk@24262 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2026-01-05 08:25:11 +00:00
Go MAEDA
2bec5b6e36 Revert r24229 (#43619). 
The change causes PG::GroupingError on PostgreSQL.


git-svn-id: https://svn.redmine.org/redmine/trunk@24230 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-12-24 07:05:02 +00:00
Go MAEDA
947fe1fff2 Optimize Issue#recalculate_attributes_for by merging date queries (#43619). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24229 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-12-24 06:27:52 +00:00
Go MAEDA
a62c38037a Revert r24223 (#43607). 
This change could prevent done ratio recalculation for higher-level parent issues when estimated hours change.


git-svn-id: https://svn.redmine.org/redmine/trunk@24228 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-12-22 08:35:21 +00:00
Go MAEDA
812399e99a Optimize Issue#recalculate_attributes_for to avoid unnecessary saves and cascading callbacks (#43607). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24223 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-12-20 02:04:26 +00:00
Marius Balteanu
d90d192f48 Introduces issue webhooks (#29664): 
* users can set up hooks for issue creation, update and deletion events, for any number of projects
* hooks run in the context of the creating user, and only if the object in question is visible to that user
* the actual HTTP call is done in ActiveJob
* webhook calls are optionally signed the same way GitHub does

Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24034 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-10-07 06:49:14 +00:00
Marius Balteanu
bd034751bf Clear non-editable custom fields when creating an issue (43161). 
This ensures that only editable custom fields are saved on a new issue
when copying an existing one. 

Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23945 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:18:55 +00:00
Go MAEDA
ddd7beecf1 Fix RuboCop Lint/UselessOr (#41884). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23822 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-06 09:13:25 +00:00
Go MAEDA
403c10091f Introduce reactions feature (so-called "like button") to issues, notes, news, and forums (#42630). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23755 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-05-11 07:59:16 +00:00
Go MAEDA
a1b5495e89 Fix Rubocop Style/ArgumentsForwarding (#42496). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23698 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-04-21 05:57:01 +00:00
Go MAEDA
08ea4e0323 Fix RuboCop Style/RedundantCondition (#41884). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23627 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-04-11 09:21:17 +00:00
Marius Balteanu
472d2a2797 Fixes wrong condition added in r23586 (#13596). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23589 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-03-30 08:59:54 +00:00
Marius Balteanu
3c57eaffd4 Add administration setting to allow time logging on closed issues. By default, the setting is enabled (#13596). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23586 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-03-30 07:48:53 +00:00
Go MAEDA
09451a1df0 Fix RuboCop offense Lint/SafeNavigationConsistency (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23134 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-10-16 23:46:53 +00:00
Go MAEDA
94d9a2337b Add "Author / Previous assignee" group to assignee dropdown in issue form (#16045). 
Patch by Luka Lüdicke (user:dkd-luedicke), Mizuki ISHIKAWA (user:ishikawa999), and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23059 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-15 06:31:30 +00:00
Go MAEDA
68121841b5 Fix NoMethodError in Issue#blocked? due to invalid issue_from_id in Issue#relations_from (#8539). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23048 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-10 00:55:32 +00:00
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887). 
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 00:38:01 +00:00
Marius Balteanu
f9f486bdd0 Check view watchers permission when copying issues (#40946). 
Patch by Jens Kraemer (@jkraemer).


git-svn-id: https://svn.redmine.org/redmine/trunk@22914 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:30:36 +00:00
Go MAEDA
b5078e314a Creating a new issue fails with an internal error if no issue priorities are defined (#40860). 
Patch by Holger Just (@hjust).


git-svn-id: https://svn.redmine.org/redmine/trunk@22895 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-25 02:09:40 +00:00
Go MAEDA
ddde0ff47d Fix RuboCop offense Rails/ActiveRecordCallbacksOrder (#39889). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-17 03:11:08 +00:00
Marius Balteanu
d9ca32b9d1 Move logic for estimated remaining hours from @QueryColumn@ to @Issue@ (#37862). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22857 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-04 20:16:08 +00:00
Go MAEDA
4506524ea5 Revert r22764 (#33829). 
It breaks activities_controller_test.rb.


git-svn-id: https://svn.redmine.org/redmine/trunk@22770 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-03-06 14:09:21 +00:00
Go MAEDA
c94d7c5a57 Fix Atom feed for issues to correctly use the updated time for "updated" element instead of the created time (#33829). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22764 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-03-04 14:25:49 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975). 
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-01-23 11:52:38 +00:00
Go MAEDA
c13d597209 Optimize Issue#relations method to improve performance by fetching both relations_from and relations_to using a single database query (#39840). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22572 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-12-28 00:10:34 +00:00
Go MAEDA
380444f085 Fix RuboCop offense Performance/StringIdentifierArgument (#39888). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-12-20 09:23:05 +00:00
Go MAEDA
c51e4937e7 Fix RuboCop offense Style/SuperWithArgsParentheses (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22530 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-12-20 07:15:11 +00:00
Marius Balteanu
a54155d206 Moves create parent issue journal to after_commit hook to work around stale object errors on concurrency (#39437). 
Patch by Jens Krämer.

git-svn-id: https://svn.redmine.org/redmine/trunk@22459 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-11-18 14:40:25 +00:00
Go MAEDA
86c5d7814f Retry in case of stale issue during Issue.update_versions (#38820). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22279 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-08-23 07:40:25 +00:00
Go MAEDA
945a82b5c0 <=> operator should return nil when invoked with an incomparable object (#38772). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-06-29 14:42:54 +00:00
Go MAEDA
55408c480b Ability to disable the priority field (#38416). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22185 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-04-14 01:05:02 +00:00
Go MAEDA
555acea780 Check if the user has the permission to add notes or edit an issue when adding an issue attachments (#38297). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22122 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-03-02 04:32:34 +00:00
Go MAEDA
a499d68802 Show parent issues in notification email (#34302). 
Patch by Yuichi HARADA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22120 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-03-01 03:46:53 +00:00
Go MAEDA
41b4bc54a5 Disable auto watch for the anonymous user (#38238). 
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22116 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-02-26 07:48:19 +00:00
Go MAEDA
9a625f2610 Auto watch issues on issue creation (#38238). 
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22115 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-02-26 07:46:35 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-01 06:19:35 +00:00
Go MAEDA
0f2378c121 Reverts r21958 and r21959 (#1739). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21960 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-11-18 08:17:50 +00:00
Go MAEDA
b3e4214989 Add the ability to change the author of an issue (#1739). 
Patch by Vladimir Kovacik, Jiri Stepanek, Aighan Pacobilch, Olivier Houdas, Takenori TAKAKI, and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21958 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-11-16 09:24:17 +00:00
Go MAEDA
d4b7634cc6 Consider only roles with either add_issues or edit_issues permissions for any status transitions (#37635). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21817 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-17 06:14:27 +00:00
Marius Balteanu
68031b6544 Improved @fixed_version_id@ validation (#37171). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21638 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 15:13:09 +00:00
Marius Balteanu
e5550d5ed4 Ensure @category_id@ is valid within the issue's project (#37171). 
Patch by Holger Just. 


git-svn-id: https://svn.redmine.org/redmine/trunk@21637 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 15:10:25 +00:00
Go MAEDA
aef5983bdd The done ratio of a parent issue may not be 100% even if all subtasks have a done ratio of 100% (#37151). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21626 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-08 15:40:45 +00:00
Marius Balteanu
fcf792615a Issue#last_notes fallback does not respect notes visibility (#37155). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21613 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-05-28 09:52:48 +00:00
Marius Balteanu
ba74ba1c70 Allow users to be mentioned using @ in issues and wiki pages (#13919): 
* the user must have add watchers permission on that object in order to mention other users
* mentioned user will receive a notification email
* only visible users who can view the object can be mentioned



git-svn-id: http://svn.redmine.org/redmine/trunk@21435 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-02-23 21:16:18 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-01-02 05:29:10 +00:00
Go MAEDA
b6a26a60f3 Fixes for Performance/StringIdentifierArgument introduced in RuboCop Performance 1.13.0 (#35142). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21330 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-12-29 06:12:27 +00:00
Go MAEDA
91c00f51ec Fixes for Performance/BigDecimalWithNumericArgument introduced in RuboCop Performance 1.13.0 (#35142). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21326 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-12-25 08:59:22 +00:00
Go MAEDA
b4dbd821c9 Issue Summary: add statistics about issues without assignee, version or category (#13099). 
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@21309 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-12-12 04:40:32 +00:00
Go MAEDA
578e367c8c Allow addition/removal of subtasks to show in parent's history (#6033). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21273 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-11-08 14:22:06 +00:00