940 Commits

Author SHA1 Message Date
Marius Balteanu
11612e5174 Fixes error executing the include macro (Page not found) in projects list (#43526).
Patch by Mizuki ISHIKAWA (user:ishikawa999). 



git-svn-id: https://svn.redmine.org/redmine/trunk@24234 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-28 02:55:01 +00:00
Marius Balteanu
4898e01652 Includes project in wiki page API response (#43569).
git-svn-id: https://svn.redmine.org/redmine/trunk@24201 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-06 12:27:53 +00:00
Go MAEDA
4791d3801f Declare text direction on HTML element for better RTL/LTR styling support (#43506).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24151 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-20 23:51:55 +00:00
Go MAEDA
157986c778 Fix RuboCop Rails/OrderArguments (#43438).
git-svn-id: https://svn.redmine.org/redmine/trunk@24125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-05 07:41:46 +00:00
Marius Balteanu
2d1f1684a1 Explicitly don't cache sensitive 2FA actions (#43083).
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:58:49 +00:00
Marius Balteanu
8f002c297e Deny 2fa setup when 2fa already present (#43083).
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:57:21 +00:00
Marius Balteanu
d79fe0df9a Adds @Cache-Control: no-store@ header to login, lost password, change password and sudo pages (#42998).
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23908 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-10 13:23:14 +00:00
Marius Balteanu
458072ab7d When the Gravatar service is disabled, display the user's initials as a fallback avatar. This provides a consistent user interface than the generic icon (#29824).
git-svn-id: https://svn.redmine.org/redmine/trunk@23903 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-07 19:07:33 +00:00
Marius Balteanu
e940540e2e Refactor, refresh UI and unify the structure of journals, replies and comments (#42972, #40744).
git-svn-id: https://svn.redmine.org/redmine/trunk@23887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-14 21:33:33 +00:00
Go MAEDA
bc12a74a5c Update tests for rails-dom-testing 2.3.0 whitespace collapsing (#42756).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-23 05:44:05 +00:00
Marius Balteanu
de96d418b1 Add "editable" attribute in the custom fields API response (#41935).
git-svn-id: https://svn.redmine.org/redmine/trunk@23678 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-18 14:44:17 +00:00
Go MAEDA
1e9f1229e6 Skip repository tests when the SCM client command is unavailable (#42500).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23618 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-10 09:42:10 +00:00
Marius Balteanu
f4e5e36dec Update tests assertions after r23581 (#42394).
git-svn-id: https://svn.redmine.org/redmine/trunk@23582 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-29 13:05:08 +00:00
Marius Balteanu
62fee35f00 Force format to html for the download_named_attachment route (#42394).
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-28 07:48:48 +00:00
Marius Balteanu
4fd86cc7c1 Fixes the request method filtering in sudo mode (#42194),
Patch by Holger Just (user:hjust),


git-svn-id: https://svn.redmine.org/redmine/trunk@23520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-06 21:45:46 +00:00
Go MAEDA
4fb1e4bea0 Use fixtures :all to ensure consistent test data and improve test reliability (#41961).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 10:17:57 +00:00
Go MAEDA
4f761e34e8 Enable browser autocomplete for login input fields (#41937).
Contributed by Thomas Butz (user:otbutz).


git-svn-id: https://svn.redmine.org/redmine/trunk@23361 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-08 06:40:47 +00:00
Go MAEDA
d8cb8b20f4 Fix: Time entry API returning hours as Rational instead of Float (#41819).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23304 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-11-24 07:04:17 +00:00
Go MAEDA
0abf7105da Fix random test failures due to missing fixtures (#41623).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23246 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-11-11 01:46:04 +00:00
Go MAEDA
47c21fa217 Fix RuboCop offenses in ThemesTest#test_old_theme_compatibility introduced in r23173 (#39111).
git-svn-id: https://svn.redmine.org/redmine/trunk@23176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-11-02 04:07:22 +00:00
Marius Balteanu
88519264cf Adds asset path to default to support old style theme (#39111).
Patch by Takashi Kato (user:tohosaku).


git-svn-id: https://svn.redmine.org/redmine/trunk@23173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-10-31 08:15:57 +00:00
Go MAEDA
ffb78c12c3 Fix invalid "theme-*" CSS class in body element when theme name contains spaces (#26778).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-10-19 08:21:18 +00:00
Go MAEDA
d46ca0e46f Fix broken project list layout for projects scheduled for deletion (#41217).
Patch by Liane Hampe (user:liane_hampe).


git-svn-id: https://svn.redmine.org/redmine/trunk@23026 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-06 02:57:40 +00:00
Marius Balteanu
218218b783 Fix flacky test after Rails 7 update which fails occasionally because database records are not ordered, so it is necessary to specify the sort order when testing (#36320).
Patch by Takashi Kato (user:tohosaku).



git-svn-id: https://svn.redmine.org/redmine/trunk@22964 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-20 06:06:27 +00:00
Marius Balteanu
bfcddc2692 Ensures desired test adapter is used in Active Job tests (#36320).
Patch by Takashi Kato (user:tohosaku).


git-svn-id: https://svn.redmine.org/redmine/trunk@22963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-20 06:04:41 +00:00
Go MAEDA
6e21ae7209 Fix RuboCop offense Layout/SpaceAfterComma, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22953 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 08:36:05 +00:00
Go MAEDA
74e2262efb Fix RuboCop offense Layout/EmptyLinesAroundMethodBody, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22950 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 07:46:58 +00:00
Go MAEDA
de76bb3a4a Fix RuboCop offense Layout/EmptyLinesAroundClassBody, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 07:42:12 +00:00
Marius Balteanu
a08f31ca28 Update users routing test to include assertions for bulk actions (delete, lock and unlock) (#40913).
git-svn-id: https://svn.redmine.org/redmine/trunk@22931 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-14 10:43:31 +00:00
Marius Balteanu
c1eff66f68 Truncate git authors to 255 characters (#40948).
The committer column in the database allows max 255 characters. With longer authors, this would result in a schema violation. By manually truncating the author field, we can avoid this.

Patch by Holger Just (@hjust). 



git-svn-id: https://svn.redmine.org/redmine/trunk@22910 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 20:35:16 +00:00
Go MAEDA
b803bddb1f Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response (#39889).
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.

This fix is a follow-up to r22837.


git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-12 16:09:37 +00:00
Go MAEDA
a4e7d34cb7 Add updated_on and updated_by fields to Issues API journal response (#40449).
Contributed by Thomas Hoffmann (@ThomasHo).


git-svn-id: https://svn.redmine.org/redmine/trunk@22846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-27 07:41:57 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
473db7e83b Fixes failing tests caused by r22802 (#40652).
git-svn-id: https://svn.redmine.org/redmine/trunk@22807 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-03 07:31:17 +00:00
Marius Balteanu
466a8aa78e Fixes missing fixture: add :groups_users fixture to @Redmine::ApiTest::UsersTest@
git-svn-id: https://svn.redmine.org/redmine/trunk@22774 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-03-21 21:12:26 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
89e1d165a9 Adds @:user_preference@ fixture to @Redmine::ApiTest::IssuesTest@ (#40239).
Patch by Vincent Robert (@Nanego).

git-svn-id: https://svn.redmine.org/redmine/trunk@22734 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-25 23:22:02 +00:00
Marius Balteanu
eef8f625c8 Adds route for code highlighting languages page (#39111, #40137).
git-svn-id: https://svn.redmine.org/redmine/trunk@22732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-25 21:41:14 +00:00
Marius Balteanu
e002d26e55 Add tests for @/help/wiki_syntax@ route (#39111, #40137).
git-svn-id: https://svn.redmine.org/redmine/trunk@22730 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-25 20:12:27 +00:00
Marius Balteanu
17a0ec4c9a Fix ThemesTest may fail if a third-party theme having theme.js is installed (#40205).
git-svn-id: https://svn.redmine.org/redmine/trunk@22707 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-13 22:58:30 +00:00
Marius Balteanu
f486091b24 Fix one more failing test related to favicon after r22692 (#39111).
git-svn-id: https://svn.redmine.org/redmine/trunk@22706 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-13 22:54:36 +00:00
Marius Balteanu
437e46aa45 Fix failing tests related to favicon in themes after r22692 (#39111).
git-svn-id: https://svn.redmine.org/redmine/trunk@22705 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-13 22:14:34 +00:00
Go MAEDA
759bececdd Fix robots.txt route to enforce .txt format (#40208).
Contributed by Liane Hampe (@liane_hampe).


git-svn-id: https://svn.redmine.org/redmine/trunk@22698 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-09 04:46:13 +00:00
Go MAEDA
5c492560b5 Fix RuboCop offense Layout/SpaceAroundBlockParameters (#23307).
git-svn-id: https://svn.redmine.org/redmine/trunk@22668 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-01 11:45:48 +00:00
Marius Balteanu
c1fa75386c Include auth_source in /users API response if request includes auth_source (#23307).
git-svn-id: https://svn.redmine.org/redmine/trunk@22666 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-31 03:24:44 +00:00
Go MAEDA
4b1b6ce1db Fix RuboCop offense Layout/SpaceAfterComma (#40099).
git-svn-id: https://svn.redmine.org/redmine/trunk@22647 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-27 01:47:10 +00:00
Marius Balteanu
1e71db421a Adds user status to users list API (#38948).
git-svn-id: https://svn.redmine.org/redmine/trunk@22637 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 16:40:13 +00:00
Marius Balteanu
479c54bf1d Include @auth_source@ in /users/:id API response if auth_source is requested (include=auth_source) and request is made by an administrator (#23307).
Patch by Go MAEDA (@maeda) and Marius BĂLTEANU (@marius.balteanu).

git-svn-id: https://svn.redmine.org/redmine/trunk@22636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 16:13:08 +00:00
Marius Balteanu
5676499ceb Remove deprecated @status=@ param used to get all users. @status=*@ should be used now. (#40124).
git-svn-id: https://svn.redmine.org/redmine/trunk@22635 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 15:38:39 +00:00
Marius Balteanu
88a8234513 Fix tests after asset pipeline implementation (#39111).
Patch by Takashi Kato (@tohosaku).

git-svn-id: https://svn.redmine.org/redmine/trunk@22628 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 05:41:50 +00:00