2643 Commits

Author SHA1 Message Date
Marius Balteanu
b88b61444c Update Rails to 8.1.1 (#43428, #43205).
Patches by Takashi Kato (user:tohosaku).


git-svn-id: https://svn.redmine.org/redmine/trunk@24248 e93f8b46-1217-0410-a6f0-8f06a7374b81
2026-01-01 18:35:05 +00:00
Go MAEDA
e31e2a19e9 Delete link is missing from the context menu when using a relative URL root (#43603).
Patch by Kenta Kumojima (user:kumojima).


git-svn-id: https://svn.redmine.org/redmine/trunk@24216 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-12-18 11:18:21 +00:00
Go MAEDA
7b1083698b Locked users are not shown in gray in the user list (#43282).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24195 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-28 01:13:16 +00:00
Go MAEDA
f28c12a997 Fix wrong RuboCop's cop name (#43437).
git-svn-id: https://svn.redmine.org/redmine/trunk@24127 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-05 07:51:47 +00:00
Go MAEDA
157986c778 Fix RuboCop Rails/OrderArguments (#43438).
git-svn-id: https://svn.redmine.org/redmine/trunk@24125 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-05 07:41:46 +00:00
Go MAEDA
3a3194bbd5 Add copyright headers to webhook-related files (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-03 09:28:35 +00:00
Go MAEDA
42a8c0e38f Use require_relative to load test_helper so that tests can be run with the ruby command (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24108 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-11-03 03:07:38 +00:00
Go MAEDA
f245ddc280 Fix failing tests caused by r24087 (#29664).
git-svn-id: https://svn.redmine.org/redmine/trunk@24088 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-30 10:04:15 +00:00
Go MAEDA
53ac36c3b8 Add functional and system tests for current Gantt behaviour (#43397).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24084 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-29 01:32:48 +00:00
Marius Balteanu
31ce3c99c2 Allow administrators to disable webhooks from settings (#29664).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-27 20:35:17 +00:00
Go MAEDA
25d6a2d555 Column headers are slightly shifted to the right in tables in list views (#43378).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-24 06:19:15 +00:00
Go MAEDA
8ce553727d Remove unnecessary fixture declarations (#29664).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24039 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-08 04:56:24 +00:00
Marius Balteanu
a524967fbc Adds the :use_webhooks permission in order to allow users to use webhooks only in projects where they have this permission. This is checked when a hook is saved, and before a hook runs (#29664).
Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-07 06:51:33 +00:00
Marius Balteanu
d90d192f48 Introduces issue webhooks (#29664):
* users can set up hooks for issue creation, update and deletion events, for any number of projects
* hooks run in the context of the creating user, and only if the object in question is visible to that user
* the actual HTTP call is done in ActiveJob
* webhook calls are optionally signed the same way GitHub does

Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24034 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-07 06:49:14 +00:00
Marius Balteanu
724c4c0024 Fix tests when checking custom fields editability (#43161).
Patch by Holger Just  (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23961 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-08 21:02:44 +00:00
Marius Balteanu
f78c463043 Offer %done values in issue context menu based on Done ratio options interval setting (#43192).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23959 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-08 19:58:19 +00:00
Marius Balteanu
283a7ed07a Mark accounts#register with Cache-Control: no-store (#42998).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:21:11 +00:00
Marius Balteanu
66021a5be2 Reverts r23943 due to wrong commit message (#42998).
git-svn-id: https://svn.redmine.org/redmine/trunk@23946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:20:12 +00:00
Marius Balteanu
686f5b15c0 Mark sensitive repository forms with Cache-Control: no-store (#42998).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23944 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:16:45 +00:00
Marius Balteanu
ddc61d80d7 Mark sensitive repository forms with Cache-Control: no-store (#42998).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23943 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:16:09 +00:00
Marius Balteanu
e67680a694 Mark sensitive user forms with Cache-Control: no-store (#42998).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23942 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:15:43 +00:00
Marius Balteanu
5f4ce0fe0e Mark sensitive auth_source forms with Cache-Control: no-store (#42998).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-07 06:15:09 +00:00
Go MAEDA
e06b4a8435 CookieOverflow error when deleting a tracker used by many projects (#43174).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23939 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-05 06:45:30 +00:00
Go MAEDA
9b4f905c78 Show the "Delete" item in the context menu only when opened from Issues#index, Gantts#show, or Calendars#show. (#35616).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-04 05:31:22 +00:00
Go MAEDA
43ef62c0d3 Add back_url parameter to get requests in context menu tests and ensure all tests pass with back_url included (#35616).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-09-04 05:29:19 +00:00
Go MAEDA
aef12fbe49 Fix CookieOverflow error when deleting a role used by many projects (#42441, #43164).
Patch by Kenta Kumojima (user:kumojima).


git-svn-id: https://svn.redmine.org/redmine/trunk@23933 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-30 06:38:26 +00:00
Marius Balteanu
30880b861f Run Setting.clear_cache after each test in order to decrease the number of random failing tests (#43130).
Patch by Katsuya HIDAKA (user:hidakatsuya).

git-svn-id: https://svn.redmine.org/redmine/trunk@23915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:31:26 +00:00
Marius Balteanu
d79fe0df9a Adds @Cache-Control: no-store@ header to login, lost password, change password and sudo pages (#42998).
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23908 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-10 13:23:14 +00:00
Marius Balteanu
458072ab7d When the Gravatar service is disabled, display the user's initials as a fallback avatar. This provides a consistent user interface than the generic icon (#29824).
git-svn-id: https://svn.redmine.org/redmine/trunk@23903 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-07 19:07:33 +00:00
Marius Balteanu
e940540e2e Refactor, refresh UI and unify the structure of journals, replies and comments (#42972, #40744).
git-svn-id: https://svn.redmine.org/redmine/trunk@23887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-14 21:33:33 +00:00
Go MAEDA
69dde23d5c Downloading .js files from the repository browser fails with a 422 error due to ActionController::InvalidCrossOriginRequest (#42839).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23857 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-05 02:22:30 +00:00
Go MAEDA
a4a32179f6 Fix "Page not found" error when saving workflows with many statuses on Rack >= 3.1.14 (#42875).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23841 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-18 01:57:58 +00:00
Go MAEDA
bc12a74a5c Update tests for rails-dom-testing 2.3.0 whitespace collapsing (#42756).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-23 05:44:05 +00:00
Go MAEDA
e7703a0170 Show reaction counts and user names only for reactions visible to the logged-in user (#42630).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23768 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-15 05:01:54 +00:00
Go MAEDA
403c10091f Introduce reactions feature (so-called "like button") to issues, notes, news, and forums (#42630).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23755 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-11 07:59:16 +00:00
Go MAEDA
ce94a1d71a Adds interval ratio setting to progressbar custom field (#42335).
Patch by Marius BĂLTEANU (user:marius.balteanu) and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23686 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-19 08:46:02 +00:00
Marius Balteanu
33ce711f99 Fix tests after r23672 (#42545).
git-svn-id: https://svn.redmine.org/redmine/trunk@23675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-18 14:10:01 +00:00
Marius Balteanu
e0403f99b1 Fixes commit message in issue history might be rendered in incorrect context (#42545).
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23672 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-18 13:04:37 +00:00
Go MAEDA
630f2863ba Improve role deletion error message to display projects containing members under the role (#42441).
Patch by Mizuki ISHIKAWA (user:ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@23619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-10 10:14:30 +00:00
Go MAEDA
1e9f1229e6 Skip repository tests when the SCM client command is unavailable (#42500).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23618 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-10 09:42:10 +00:00
Go MAEDA
c447e12274 Configurable columns for related and sub issues lists (#42477).
Patch by Jens Krämer (user:jkraemer).


git-svn-id: https://svn.redmine.org/redmine/trunk@23596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-02 10:14:41 +00:00
Marius Balteanu
3c57eaffd4 Add administration setting to allow time logging on closed issues. By default, the setting is enabled (#13596).
git-svn-id: https://svn.redmine.org/redmine/trunk@23586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-30 07:48:53 +00:00
Go MAEDA
e0e0be4928 "For all projects" checkbox should be disabled when editing an existing query in which the checkbox is already checked (#42458).
Patch by [Agileware] nusohiro (user:nusohiro).


git-svn-id: https://svn.redmine.org/redmine/trunk@23573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-27 01:07:48 +00:00
Go MAEDA
bacdb72670 Missing thousands separator in Integer and Float custom field totals (#42342).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-26 02:38:56 +00:00
Marius Balteanu
1f46b0b236 Extract project query for admins to a separate ProjectAdminQuery model (#42352).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-09 23:25:12 +00:00
Marius Balteanu
028125e0f1 Fixes typo in query name fixture.
git-svn-id: https://svn.redmine.org/redmine/trunk@23521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-07 07:37:14 +00:00
Go MAEDA
7ccf349e36 Redirection after signing in fails when the back_url includes a port number (#41930).
Patch by Kenta Kumojima (user:kumojima) and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23465 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-28 05:49:12 +00:00
Go MAEDA
9fccf787a4 Remove navigation parameters from issue detail URLs after updates (#42073).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23433 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-07 07:18:32 +00:00
Go MAEDA
4fb1e4bea0 Use fixtures :all to ensure consistent test data and improve test reliability (#41961).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 10:17:57 +00:00
Marius Balteanu
7ae0427c9e Replaces warning icon with SVG in watcher list and workflow warnings (#41918).
Patch by Takenori TAKAKI (user:takenory).

git-svn-id: https://svn.redmine.org/redmine/trunk@23388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 06:37:58 +00:00