Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2026-01-18 13:33:04 +01:00
Code Issues Packages Projects Releases Activity
19,238 Commits 35 Branches 225 Tags
master
Commit Graph

2314 Commits

Author SHA1 Message Date
Go MAEDA
e31e2a19e9 Delete link is missing from the context menu when using a relative URL root (#43603). 
Patch by Kenta Kumojima (user:kumojima).


git-svn-id: https://svn.redmine.org/redmine/trunk@24216 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-12-18 11:18:21 +00:00
Go MAEDA
3a3194bbd5 Add copyright headers to webhook-related files (#29664). 
git-svn-id: https://svn.redmine.org/redmine/trunk@24113 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-11-03 09:28:35 +00:00
Marius Balteanu
31ce3c99c2 Allow administrators to disable webhooks from settings (#29664). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24073 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-10-27 20:35:17 +00:00
Marius Balteanu
a524967fbc Adds the :use_webhooks permission in order to allow users to use webhooks only in projects where they have this permission. This is checked when a hook is saved, and before a hook runs (#29664). 
Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24035 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-10-07 06:51:33 +00:00
Marius Balteanu
d90d192f48 Introduces issue webhooks (#29664): 
* users can set up hooks for issue creation, update and deletion events, for any number of projects
* hooks run in the context of the creating user, and only if the object in question is visible to that user
* the actual HTTP call is done in ActiveJob
* webhook calls are optionally signed the same way GitHub does

Patch by Jens Krämer (user:jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@24034 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-10-07 06:49:14 +00:00
Marius Balteanu
be07d4d01d Fixes "ArgumentError: wrong number of arguments (given 0, expected 1) in ApplicationController#find_model_object" in Rails 8 (#43205, #43230). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24017 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-28 21:20:39 +00:00
Marius Balteanu
283a7ed07a Mark accounts#register with Cache-Control: no-store (#42998). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:21:11 +00:00
Marius Balteanu
66021a5be2 Reverts r23943 due to wrong commit message (#42998). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23946 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:20:12 +00:00
Marius Balteanu
686f5b15c0 Mark sensitive repository forms with Cache-Control: no-store (#42998). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23944 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:16:45 +00:00
Marius Balteanu
ddc61d80d7 Mark sensitive repository forms with Cache-Control: no-store (#42998). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23943 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:16:09 +00:00
Marius Balteanu
e67680a694 Mark sensitive user forms with Cache-Control: no-store (#42998). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23942 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:15:43 +00:00
Marius Balteanu
5f4ce0fe0e Mark sensitive auth_source forms with Cache-Control: no-store (#42998). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23941 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-07 06:15:09 +00:00
Go MAEDA
e06b4a8435 CookieOverflow error when deleting a tracker used by many projects (#43174). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23939 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-05 06:45:30 +00:00
Go MAEDA
9b4f905c78 Show the "Delete" item in the context menu only when opened from Issues#index, Gantts#show, or Calendars#show. (#35616). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23938 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-04 05:31:22 +00:00
Go MAEDA
47bfd69f33 Add svg icons sample view accessible at /rails/info/svg_icons in development mode (#41725). 
Patch by Takashi Kato (user:tohosaku).


git-svn-id: https://svn.redmine.org/redmine/trunk@23934 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-08-30 07:45:27 +00:00
Go MAEDA
aef12fbe49 Fix CookieOverflow error when deleting a role used by many projects (#42441, #43164). 
Patch by Kenta Kumojima (user:kumojima).


git-svn-id: https://svn.redmine.org/redmine/trunk@23933 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-08-30 06:38:26 +00:00
Marius Balteanu
9b807267ac Add sudo-mode to all 2fa actions 
The sudo-mode window should ensure this does not impede users
currently setting up 2fa things, but adds protection when not
in 2fa activation/deactivation mode. (#43083).

Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23918 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-08-13 05:59:53 +00:00
Marius Balteanu
2d1f1684a1 Explicitly don't cache sensitive 2FA actions (#43083). 
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23917 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-08-13 05:58:49 +00:00
Marius Balteanu
8f002c297e Deny 2fa setup when 2fa already present (#43083). 
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23916 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-08-13 05:57:21 +00:00
Marius Balteanu
d79fe0df9a Adds @Cache-Control: no-store@ header to login, lost password, change password and sudo pages (#42998). 
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23908 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-08-10 13:23:14 +00:00
Go MAEDA
69dde23d5c Downloading .js files from the repository browser fails with a 422 error due to ActionController::InvalidCrossOriginRequest (#42839). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23857 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-07-05 02:22:30 +00:00
Go MAEDA
8cc3e1a5ac Fix N+1 query in Wiki history page by preloading the author of each Wiki content version (#42933). 
Patch by [Agileware]Kota Uchino (user:uchinokot).


git-svn-id: https://svn.redmine.org/redmine/trunk@23847 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-29 04:55:22 +00:00
Marius Balteanu
2d3b3b939e Add OAuth2 provider capability using doorkeeper gem (#24808). 
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23837 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-12 07:09:03 +00:00
Marius Balteanu
e56d84b632 Reverts r23835 due to wrong issue ID (#40856). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23836 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-12 07:05:01 +00:00
Marius Balteanu
ebdd1a40f4 Add OAuth2 provider capability using doorkeeper gem (#40856). 
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23835 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-11 20:30:44 +00:00
Go MAEDA
d2a9223c4a Improve method and variable naming for clarity and consistency (#42630). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23769 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-05-15 05:09:17 +00:00
Go MAEDA
403c10091f Introduce reactions feature (so-called "like button") to issues, notes, news, and forums (#42630). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23755 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-05-11 07:59:16 +00:00
Go MAEDA
3c0faad370 Optimize the rendering of versions on the roadmap by preloading the email addresses of issue assignees (#42682). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23749 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-05-07 04:39:24 +00:00
Go MAEDA
2d064e6952 Avoid unnecessary SQL query for subprojects in ProjectsController#show when project has no children (#42671). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23745 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-05-06 02:16:37 +00:00
Go MAEDA
113d7f50a9 Optimize autocomplete issue listing triggered by typing "##" by eager loading trackers (#42574). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23660 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-04-16 06:50:26 +00:00
Go MAEDA
08ea4e0323 Fix RuboCop Style/RedundantCondition (#41884). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23627 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-04-11 09:21:17 +00:00
Go MAEDA
630f2863ba Improve role deletion error message to display projects containing members under the role (#42441). 
Patch by Mizuki ISHIKAWA (user:ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@23619 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-04-10 10:14:30 +00:00
Marius Balteanu
3c57eaffd4 Add administration setting to allow time logging on closed issues. By default, the setting is enabled (#13596). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23586 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-03-30 07:48:53 +00:00
Marius Balteanu
8cd7d5bdf7 Fixes rubocop offense (#42352). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23533 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-03-10 00:33:48 +00:00
Marius Balteanu
1f46b0b236 Extract project query for admins to a separate ProjectAdminQuery model (#42352). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23531 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-03-09 23:25:12 +00:00
Marius Balteanu
10971361fa Allow query class to select layout for QueriesController (#42352). 
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23529 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-03-09 23:20:50 +00:00
Go MAEDA
55d6b59b61 Simplify URL components omission in ApplicationController#verify_back_url (#41930). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23469 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-28 08:24:52 +00:00
Go MAEDA
7ccf349e36 Redirection after signing in fails when the back_url includes a port number (#41930). 
Patch by Kenta Kumojima (user:kumojima) and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23465 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-28 05:49:12 +00:00
Go MAEDA
d480067439 Optimize IssuesController#show by skipping time tracking queries when disabled (#42144). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23463 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-25 08:18:26 +00:00
Go MAEDA
9fccf787a4 Remove navigation parameters from issue detail URLs after updates (#42073). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23433 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-07 07:18:32 +00:00
Marius Balteanu
d63678068a Fix random test failure by ensuring @WatchersController#find_objects_from_params@ returns results in consistent order (#41894). 
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23325 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-11-29 07:52:05 +00:00
Go MAEDA
071971131f Fix project links in tracker deletion error message to set the status_id filter to "all" (#12521). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23209 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-11-04 04:50:25 +00:00
Go MAEDA
e5867ffc8d Improve tracker deletion error message to display projects containing issues under the tracker (#12521). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23181 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-11-03 07:11:07 +00:00
Go MAEDA
8ca5d2fa1a Partial quoting feature for Issues and Forums (#41294). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23107 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-10-09 21:51:52 +00:00
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887). 
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 00:38:01 +00:00
Marius Balteanu
ffce07e785 Start working on replacing old icons with SVG icons (#23980): 
* Introduces IconsHelper with methods to render SVG icon from a sprite file.
* Adds SVG sprite file with icons mainly from Font Awesome, but also from Material Design Icons and Fluent UI System Icons (based on the work made by Takashi Kato (@tohosaku)).
* Replaces specific icons with new SVG icons.
* Temporarily keep all old CSS icon definitions for backard compatibility.



git-svn-id: https://svn.redmine.org/redmine/trunk@22988 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-29 21:46:40 +00:00
Go MAEDA
fdd90bab2b Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-25 08:44:33 +00:00
Marius Balteanu
fb37d2e4fa Upgrade to Rails 7.2.0 (#36320). 
Patch by Takashi Kato (user:tohosaku). 


git-svn-id: https://svn.redmine.org/redmine/trunk@22960 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-20 05:54:30 +00:00
Go MAEDA
6c8b04d6d5 Add configurable setting for copying attachments when copying an issue (#36197). 
Patch by Yuichi HARADA (user:yui.har).


git-svn-id: https://svn.redmine.org/redmine/trunk@22926 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-14 01:49:53 +00:00
Marius Balteanu
6322650728 Add bulk unlock to user list context menu (#40913). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22925 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-13 10:21:49 +00:00