Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2026-07-07 13:12:36 +02:00
Code Issues Packages Projects Releases Activity

Fixed: Custom field is rendered, even if its value is empty (for multiple) (#18654).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@13864 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2015-01-10 13:03:52 +00:00
parent a77d884157
commit a18c719fcc
4 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/functional/projects_controller_test.rb
View File

@@ -351,6 +351,18 @@ class ProjectsControllerTest < ActionController::TestCase
assert_select 'li', :text => /Development status/, :count => 0
end
def test_show_should_not_display_blank_custom_fields_with_multiple_values
f1 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Foo Bar), :multiple => true
f2 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Baz Qux), :multiple => true
project = Project.generate!(:custom_field_values => {f2.id.to_s => %w(Qux)})
get :show, :id => project.id
assert_response :success
assert_select 'li', :text => /#{f1.name}/, :count => 0
assert_select 'li', :text => /#{f2.name}/
end
def test_show_should_not_fail_when_custom_values_are_nil
project = Project.find_by_identifier('ecookbook')
project.custom_values.first.update_attribute(:value, nil)