Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2026-07-08 17:01:58 +02:00
Code Issues Packages Projects Releases Activity

Ensure unique attachment filenames (#35539).

Browse Source 
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21071 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2021-07-19 13:27:59 +00:00
parent 8f0d358533
commit 8e4d71adc9
2 changed files with 40 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
test/unit/attachment_test.rb
View File

@@ -275,12 +275,28 @@ class AttachmentTest < ActiveSupport::TestCase
assert_equal 'valid_[] invalid_chars', a.filename
end
def test_diskfilename
assert Attachment.disk_filename("test_file.txt") =~ /^\d{12}_test_file.txt$/
assert_equal 'test_file.txt', Attachment.disk_filename("test_file.txt")[13..-1]
assert_equal '770c509475505f37c2b8fb6030434d6b.txt', Attachment.disk_filename("test_accentué.txt")[13..-1]
assert_equal 'f8139524ebb8f32e51976982cd20a85d', Attachment.disk_filename("test_accentué")[13..-1]
assert_equal 'cbb5b0f30978ba03731d61f9f6d10011', Attachment.disk_filename("test_accentué.ça")[13..-1]
def test_create_diskfile
Attachment.create_diskfile("test_file.txt") do |f|
path = f.path
assert_match(/^\d{12}_test_file.txt$/, File.basename(path))
assert_equal 'test_file.txt', File.basename(path)[13..-1]
File.unlink f.path
end
Attachment.create_diskfile("test_accentué.txt") do |f|
assert_equal '770c509475505f37c2b8fb6030434d6b.txt', File.basename(f.path)[13..-1]
File.unlink f.path
end
Attachment.create_diskfile("test_accentué") do |f|
assert_equal 'f8139524ebb8f32e51976982cd20a85d', File.basename(f.path)[13..-1]
File.unlink f.path
end
Attachment.create_diskfile("test_accentué.ça") do |f|
assert_equal 'cbb5b0f30978ba03731d61f9f6d10011', File.basename(f.path)[13..-1]
File.unlink f.path
end
end
def test_title