Support for named route in project menu and a new :permission option (#6426).

git-svn-id: http://svn.redmine.org/redmine/trunk@13765 e93f8b46-1217-0410-a6f0-8f06a7374b81

test/unit/lib/redmine/menu_manager/menu_helper_test.rb

@@ -47,6 +47,20 @@ class Redmine::MenuManager::MenuHelperTest < ActionView::TestCase
     end
   end
 
+  def test_render_menu_node_with_symbol_as_url
+    node = Redmine::MenuManager::MenuItem.new(:testing, :issues_path)
+    @output_buffer = render_menu_node(node, nil)
+
+    assert_select "a[href=/issues]", "Testing"
+  end
+
+  def test_render_menu_node_with_symbol_as_url_and_project
+    node = Redmine::MenuManager::MenuItem.new(:testing, :project_issues_path)
+    @output_buffer = render_menu_node(node, Project.find(1))
+
+    assert_select "a[href=/projects/ecookbook/issues]", "Testing"
+  end
+
   def test_render_menu_node_with_nested_items
     parent_node = Redmine::MenuManager::MenuItem.new(:parent_node, '/test', { })
     parent_node << Redmine::MenuManager::MenuItem.new(:child_one_node, '/test', { })
@@ -216,6 +230,19 @@ class Redmine::MenuManager::MenuHelperTest < ActionView::TestCase
     assert_equal 2, items.size
   end
 
+  def test_menu_items_for_should_skip_items_that_fail_the_permission
+    menu_name = :test_menu_items_for_should_skip_items_that_fail_the_permission
+    Redmine::MenuManager.map menu_name do |menu|
+      menu.push(:a_menu, :project_issues_path)
+      menu.push(:unallowed, :project_issues_path, :permission => :unallowed)
+    end
+
+    User.current = User.find(2)
+
+    items = menu_items_for(menu_name, Project.find(1))
+    assert_equal 1, items.size
+  end
+
   def test_menu_items_for_should_skip_items_that_fail_the_conditions
     menu_name = :test_menu_items_for_should_skip_items_that_fail_the_conditions
     Redmine::MenuManager.map menu_name do |menu|

test/unit/lib/redmine/menu_manager/menu_item_test.rb

@@ -46,12 +46,6 @@ class Redmine::MenuManager::MenuItemTest < ActiveSupport::TestCase
     end
   end
 
-  def test_new_menu_item_should_require_the_options
-    assert_raises ArgumentError do
-      Redmine::MenuManager::MenuItem.new(:test_missing_options, '/test')
-    end
-  end
-
   def test_new_menu_item_with_all_required_parameters
     assert Redmine::MenuManager::MenuItem.new(:test_good_menu, '/test', {})
   end