diff --git a/lib/redmine/wiki_formatting/textile/formatter.rb b/lib/redmine/wiki_formatting/textile/formatter.rb index 4d4e4b240..2555479d4 100644 --- a/lib/redmine/wiki_formatting/textile/formatter.rb +++ b/lib/redmine/wiki_formatting/textile/formatter.rb @@ -120,9 +120,10 @@ module Redmine ## replace
content
text.gsub!(//) do
content = @pre_list[$1.to_i]
- if content.match(/\s?(.+)/m)
- language = $1
- text = $2
+ # This regex must match any data produced by RedCloth3#rip_offtags
+ if content.match(/\s?(.*)/m)
+ language = $1 || $2
+ text = $3
if Redmine::SyntaxHighlighting.language_supported?(language)
content = "" +
Redmine::SyntaxHighlighting.highlight_by_language(text, language)
diff --git a/test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb b/test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb
index 8920a6ae9..59273d409 100644
--- a/test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb
+++ b/test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb
@@ -536,9 +536,17 @@ STR
def test_should_not_allow_arbitrary_class_attribute_on_offtags
%w(code pre kbd).each do |tag|
assert_html_output({"<#{tag} class=\"foo\">test#{tag}>" => "<#{tag}>test#{tag}>"}, false)
+ assert_html_output({"<#{tag} class='foo'>test#{tag}>" => "<#{tag}>test#{tag}>"}, false)
+ assert_html_output({"<#{tag} class=\"ruby foo\">test#{tag}>" => "<#{tag}>test#{tag}>"}, false)
+ assert_html_output({"<#{tag} class='ruby foo'>test#{tag}>" => "<#{tag}>test#{tag}>"}, false)
+ assert_html_output({"<#{tag} class=\"ruby \"foo\" bar\">test#{tag}>" => "<#{tag}>test#{tag}>"}, false)
end
assert_html_output({"test " => "test"}, false)
+ assert_html_output({"test " => "test"}, false)
+ assert_html_output({"test " => "test"}, false)
+ assert_html_output({"test " => "test"}, false)
+ assert_html_output({"test " => "test"}, false)
end
def test_should_allow_valid_language_class_attribute_on_code_tags