12471 Commits

Author SHA1 Message Date
Julian Lam
55a197a7d7 fix: check for csrf token on /register/abort, + theme changes for v2.x branches of themes 2022-11-09 12:00:59 -05:00
Barış Soner Uşaklı
a31ba824ea fix: upgrade script to work from 0.x to 2.x 2022-11-05 14:44:12 -04:00
Barış Soner Uşaklı
06d1539137 test: fix tests again 2022-10-29 17:40:33 -04:00
Barış Soner Uşaklı
b5d38bc696 feat: new search hooks
filter:search.isAllowed, allow plugins to check if searching is allowed
filter:search.searchIn, allow searching in custom items
2022-10-29 16:57:03 -04:00
Barış Soner Uşaklı
673261ff98 fix: #10519, image height in emails 2022-10-23 19:46:54 -04:00
Barış Soner Uşaklı
6f673f806f fix: #10993, apply autoLocale middleware to guests only 2022-10-21 10:23:36 -04:00
Barış Soner Uşaklı
e3f2156202 feat: add search data to filter:search.inContent 2022-10-20 20:35:35 -04:00
Julian Lam
9ee30fe7d2 fix: revert breaking change, add back SocketUser.emailConfirm 2022-10-18 15:16:52 -04:00
Julian Lam
9c576a0758 Email confirmation QOL updates (#10987)
* breaking: remove `SocketUser.emailConfirm`, re: #10954

* chore: move email confirmation related configs to own section in Settings > Email

* feat: new user email method `getValidationExpiry`, returns expiration in ms.. probably.

* fix: bug where `user.email.isValidationPending` returned an u nexpected non-boolean value if there was no confirmation pending (only when checking email as well)

* fix: update getValidationExpiry to return ms

* test: use emailConfirmInterval for tests, for now

* fix: throw friendly error when attempting an email change within email confirmation window

* feat: new config option `emailConfirmExpiry` in days, governs how long the confirm link is good for

* test: additional tests for user email methods

* fix: add back missing handling of  option

* test: fix tests
2022-10-18 15:12:13 -04:00
Julian Lam
09f3ac6574 fix: in appropriately named language key email-confirm-email2 2022-10-17 16:49:15 -04:00
Julian Lam
7672194c7c fix: correctly pass dev flag to package installer 2022-10-17 16:13:04 -04:00
Julian Lam
09cfd0bd57 fix: use --omit=dev flag for npm instead of --production 2022-10-17 16:07:26 -04:00
Barış Soner Uşaklı
dd4e9cce09 perf: speed up build
run webpack as soon as js targets are done
this allows building js/css in parallel
2022-10-14 11:04:00 -04:00
Barış Soner Uşaklı
67efaeb4b8 fix active plugins (#10964) 2022-10-13 10:09:23 -04:00
Barış Soner Uşaklı
b879b6a0c2 fix: use admin:groups priv for groups (#10960) 2022-10-12 10:02:45 -04:00
Barış Soner Uşaklı
e35b0a869f fix: https://github.com/NodeBB/NodeBB/issues/10525 2022-10-11 20:30:54 -04:00
Barış Soner Uşaklı
ebd5dcc6d6 fix: EEXISTS error on linux if plugin/theme overrides core js file 2022-10-11 08:13:59 -04:00
Barış Soner Uşaklı
177d904812 fix: category ordering add test 2022-10-03 09:41:08 -04:00
Julian Lam
14515f6004 fix: add lru-cache to checked packages, to fix upgrade issue with lru-cache 2022-09-21 16:02:20 -04:00
Julian Lam
cf4f5447bb fix: #10906, allow middleware.checkAccountPermissions to be called with either uid or userslug in params
Previously, the middleware only worked with userslug params
2022-09-19 10:08:18 -04:00
Barış Soner Uşaklı
b5dd89e1c0 feat: store topic title and tags in diffs (#10900)
* feat: store topic title and tags in diffs

allow restoring post diff if tags didn't change

* test: fix tests, fast computer problems
2022-09-16 22:16:08 -04:00
Barış Soner Uşaklı
8aa1596d23 chore: bring back treding plugins 2022-09-04 12:59:03 -04:00
Barış Soner Uşaklı
3d5a6b39d6 lint: fix lint 2022-09-04 12:28:47 -04:00
Barış Soner Uşaklı
b392450c36 perf: disable trending plugins, too slow due to nbbpm 2022-09-04 12:00:27 -04:00
Julian Lam
67cb70352f fix: missing escape on ACP category backgroundImage property 2022-09-02 12:30:55 -04:00
Julian Lam
15b1561fd3 feat: introduce ACP defined option to rescind notif or do nothing on flag resolve/reject
/cc #10867
2022-08-26 16:05:45 -04:00
Julian Lam
d05705183f refactor: move export generation logic to v3 controller, GET/HEAD routes for exports
re: #10384
2022-08-22 17:03:43 -04:00
Julian Lam
0cda5aa3e3 feat: allow v3 api to handle 202 and 204 response codes as well. 2022-08-22 17:03:43 -04:00
Julian Lam
8b7cf48ade Merge remote-tracking branch 'origin/master' into develop 2022-08-19 15:36:08 -04:00
Julian Lam
9b96c33d5d fix: wrap passport.authenticate to pass in keepSessionInfo if not already set 2022-08-19 13:04:10 -04:00
Julian Lam
65b3996ac6 fix: removing duplicate session rerolling code (as it is in passport@^0.6 now) 2022-08-19 12:52:24 -04:00
Julian Lam
20ebf0a1e0 Merge remote-tracking branch 'origin/master' into develop 2022-08-19 10:50:59 -04:00
Barış Soner Uşaklı
bc37a5c516 fix: parseInt caller.uid closes #10849 2022-08-19 08:51:04 -04:00
Barış Soner Uşaklı
fc9b436f3e Merge branch 'master' of https://github.com/NodeBB/NodeBB 2022-08-18 09:27:48 -04:00
Barış Soner Uşaklı
489fb3a36f fix: missing req, closes #10847 2022-08-18 09:27:37 -04:00
Julian Lam
4dc7fa050f fix: #10845, disallow inline viewing of uploaded html files 2022-08-17 21:48:02 -04:00
Julian Lam
990ad6a11a Merge remote-tracking branch 'origin/master' into develop 2022-08-17 15:32:49 -04:00
Julian Lam
ec048a01ba fix: #10841, incorrect conditional in email interstitial partial 2022-08-17 15:32:36 -04:00
Barış Soner Uşaklı
aba420a3f3 feat: setting to show signatures only once in topics, closes #10071 2022-08-16 18:06:16 -04:00
Barış Soner Uşaklı
14c79763dd refactor: use group.slug on acp group urls closes #8277 2022-08-16 10:42:33 -04:00
Barış Soner Uşaklı
e06e526e54 fix: don't crash if post is undefined 2022-08-15 14:18:43 -04:00
Barış Soner Uşaklı
33458701c1 test: passport0.6 (#10638)
* test: passport0.6

* test: make logout async, fix lint

* test: keepSessionInfo flag

* revert: csrf load
2022-08-15 14:18:43 -04:00
Opliko
3975fa2e45 fix: return at least one in sizeCalculation (#10832)
if post content is empty post cache should still consider its size to be at least one. fixes #10831
2022-08-15 14:18:43 -04:00
Barış Soner Uşaklı
4a3e36a766 fix: don't crash if post is undefined 2022-08-14 20:18:18 -04:00
Opliko
a9bbb586fc feat: allow plugins to add to admin cache list (#10833)
* feat: allow plugins to add to admin cache list

resolves  #10820

plugins will have to use `filter:admin.cache.get` hook and just add their own cache to the object there.

* feat: add dump to ttlCache and expose properties

* feat: also expose properties under their current names

* feat: display TTL if set
2022-08-13 20:35:59 -04:00
Barış Soner Uşaklı
6b2a6f9006 test: passport0.6 (#10638)
* test: passport0.6

* test: make logout async, fix lint

* test: keepSessionInfo flag

* revert: csrf load
2022-08-13 20:24:42 -04:00
Opliko
15ca460c8f fix: return at least one in sizeCalculation (#10832)
if post content is empty post cache should still consider its size to be at least one. fixes #10831
2022-08-13 09:29:56 -04:00
Julian Lam
9b753d6d57 TTL Cache (#10816)
* refactor: move src/cacheCreate.js to src/cache/lru.js

* fix: call new library location for lru cache creator

* feat: add ttl cache

* fix: update upload throttler to use ttl cache instead of lru cache

* chore: add missing dependency

* fix: avoid pubsub conflicts

* fix: use get instead of peek, which is not available in ttl-cache
2022-08-10 15:26:07 -04:00
Julian Lam
c07d595662 Update to lru-cache@^7 (#10815)
* chore(deps): bump lru-cache from 6.0.0 to 7.13.1 in /install

Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 6.0.0 to 7.13.1.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-lru-cache/compare/v6.0.0...v7.13.1)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(lru-cache): remove unneeded `length` params for cache creation, as `maxSize` was not used in those init calls, also renamed some methods to match new method names in lru-cache [breaking]

Added deprecation notices for old params

* fix: replace three direct calls to lru-cache with call to cacheCreate, moved cache creation call in uploads to run on first init as config is not populated at lib init

* test: move configs init above cache reset calls in databasemock

* move some more code above cache clear

* refactor: remove unused

* test: lru

* test: more debug

* test: on more test

* use await helpers.uploadFile

* fix: tests remove logs

* fix: acp cache page

* fix: add in one more guard again cache instantiation with `length` prop but no `maxSize` prop

* fix(deps): bump markdown

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2022-08-10 13:24:16 -04:00
Opliko
b3a37a7f35 feat: support packageManager property in package.json
resolves #10714
2022-08-08 17:23:32 -04:00