Commit Graph

8214 Commits

Author SHA1 Message Date
Julian Lam
a716a5529c feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals (#8541)
* feat: privileges save button, #8537, WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes #8537 privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
2020-08-03 20:42:45 -04:00
Misty (Bot)
8da742e065 Latest translations and fallbacks 2020-08-03 09:06:00 +00:00
Misty (Bot)
903c407171 Latest translations and fallbacks 2020-08-02 09:05:38 +00:00
Barış Soner Uşaklı
e7a502e0aa feat: add ability to search groups in group details page 2020-07-31 21:21:15 -04:00
Barış Soner Uşaklı
519e665939 fix: #8538, go to first unread instead of last read 2020-07-31 10:34:10 -04:00
Misty (Bot)
029f477434 Latest translations and fallbacks 2020-07-31 09:06:17 +00:00
Barış Soner Uşaklı
9e80a9efdd fix: #8534, dont show modal on search 2020-07-30 22:33:11 -04:00
Barış Soner Uşaklı
fb7bb8d400 feat: use category selector in category page
fix privilege shortcuts in group page after search
2020-07-30 14:55:28 -04:00
Barış Soner Uşaklı
560f3eb173 feat: css fixes 2020-07-30 12:39:10 -04:00
Barış Soner Uşaklı
91411cc47c feat: add privileges shortcut to groups list
fix issues with escape group names
2020-07-30 12:26:37 -04:00
Misty (Bot)
caa78cc1f6 Latest translations and fallbacks 2020-07-30 09:06:18 +00:00
Julian Lam
c705e08a76 feat: allow direct link to flag from post tools, #8531 2020-07-29 16:55:18 -04:00
Barış Soner Uşaklı
8415d2f014 fix: api test 2020-07-29 14:29:07 -04:00
Barış Soner Uşaklı
c4829fd8c2 feat: allow changing requirejs base url 2020-07-29 14:14:45 -04:00
Barış Soner Uşaklı
bbc7737e14 feat: ability to clear cache from acp 2020-07-29 12:50:18 -04:00
Barış Soner Uşaklı
69fb15276c fix: tests 2020-07-29 12:19:07 -04:00
Barış Soner Uşaklı
8d8117ffa1 feat: reduce amount of data loaded on acp admin page
get rid of socket call and use ajaxify.data.categories
2020-07-29 11:57:20 -04:00
Misty (Bot)
d580cf01c3 Latest translations and fallbacks 2020-07-28 09:06:14 +00:00
Barış Soner Uşaklı
f48d155670 fix: tests 2020-07-27 21:50:07 -04:00
Barış Soner Uşaklı
fd4c3cda42 fix: #4695, remove new notif alert 2020-07-27 21:34:21 -04:00
Julian Lam
8473e165a6 fix: too small sortable handle for ACP>Manage>Categories
The handle was initially just the icon, but now it is the icon
and the category label itself.
2020-07-27 16:07:52 -04:00
Misty (Bot)
93d1ceccdd Latest translations and fallbacks 2020-07-27 17:18:47 +00:00
Misty (Bot)
43e9c25d26 Latest translations and fallbacks 2020-07-27 17:09:09 +00:00
Barış Soner Uşaklı
db07dd8565 fix: less fixes for category dropdown 2020-07-27 13:03:34 -04:00
Barış Soner Uşaklı
24535a62e7 feat: make category tools in acp a dropdown
add view category, view privileges into dropdown
2020-07-27 12:39:32 -04:00
Barış Soner Uşaklı
609e37a67b feat: remove deprecated utils.walk 2020-07-24 14:29:08 -04:00
Julian Lam
55b0e902fb feat: consolidation of flags to reduce flagspam, #8510
Squashed commit of the following:

commit c6d0939620
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 13:41:32 2020 -0400

    fix: more tests

commit 32f9af2a87
Merge: e50907535 4eae927d1
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:53:04 2020 -0400

    Merge remote-tracking branch 'origin/master' into singleton-flags

commit e509075351
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 24 10:52:46 2020 -0400

    fix: controllers-admin test

commit fd5af99e30
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:26:55 2020 -0400

    fix(tests): dummy commit to trigger travisCI

commit c452a6ffcf
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 17:05:09 2020 -0400

    fix(openapi): openapi spec changes

commit 8089a74e89
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:48:00 2020 -0400

    fix: reversing the order of reports for display purposes

commit a099892b37
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:45:44 2020 -0400

    refactor: run all flag creation calls in a single batch

commit b24999682f
Author: Julian Lam <julian@nodebb.org>
Date:   Fri Jul 17 15:08:23 2020 -0400

    feat: handling multiple reporters per flag, #8510

commit 08c75c0200
Author: Julian Lam <julian@nodebb.org>
Date:   Thu Jul 16 20:53:18 2020 -0400

    feat: upgrade script for #8510
2020-07-24 14:10:37 -04:00
psychobunny
4c90fac412 fix: cursor for category select 2020-07-24 01:30:16 -04:00
psychobunny
bc26883aed refactor: setting codeclimate to A 2020-07-23 23:23:35 -04:00
psychobunny
8769e28b28 fix: api docs for admin/manage/groups/x 2020-07-23 23:00:02 -04:00
psychobunny
a6ae69737b Merge branch 'master' of https://github.com/NodeBB/NodeBB 2020-07-23 18:34:20 -04:00
psychobunny
10e4ae629c feat: highlight privs row if group is added / navigating from group page 2020-07-23 18:34:07 -04:00
psychobunny
53f6139b8c feat: prevent navigation away from groups page if changes are unsaved 2020-07-23 18:06:55 -04:00
psychobunny
2c83278f97 feat: quick access dropdown on groups page to access privileges page 2020-07-23 17:59:52 -04:00
Barış Soner Uşaklı
42af4b572b fix: api tests 2020-07-23 16:54:36 -04:00
Barış Soner Uşaklı
844f2b4ed0 feat: #8524, allow editing category of queued topic 2020-07-23 16:43:56 -04:00
Barış Soner Uşaklı
ec05783507 feat: remove js-enabled.css 2020-07-22 10:38:52 -04:00
Barış Soner Uşaklı
a46adb3fd5 fix: more tests 2020-07-21 20:43:16 -04:00
Barış Soner Uşaklı
67ca5e3256 fix: tests 2020-07-21 18:26:26 -04:00
Barış Soner Uşaklı
23a9a334cd feat: short more info 2020-07-21 18:08:53 -04:00
Barış Soner Uşaklı
2485a55092 feat: #8521, allow editing title before posting from queue 2020-07-20 21:28:17 -04:00
Barış Soner Uşaklı
8ddc8dd10f refactor: make msg pretty 2020-07-20 17:58:42 -04:00
Barış Soner Uşaklı
764969ab29 feat: show language when key isn't found 2020-07-20 17:56:03 -04:00
Barış Soner Uşaklı
1e7397b1b8 feat: allow searching categories in ACP 2020-07-20 13:17:08 -04:00
Barış Soner Uşaklı
320008cd49 feat: #8509, don't scroll chat to bottom if user scrolled up 2020-07-19 14:34:31 -04:00
psychobunny
06143ca7d7 feat: added quick link to edit privileges on the category edit page 2020-07-17 16:27:47 -04:00
Julian Lam
1e14af4503 fix: composer textarea placeholder l10n /cc @pitaj 2020-07-16 16:25:36 -04:00
Julian Lam
9fb9185fa7 feat: hide some filters behind 'more filters' button 2020-07-16 09:32:20 -04:00
Julian Lam
d52d7bdb10 feat: collapsible daily flags graph 2020-07-16 09:03:03 -04:00
Julian Lam
e3e55f25d0 refactor: flag sanity checks, +feat: flag limits
- Added new config flag:limitPerTarget, to disallow flags after an item has
  already been flagged x times (default 0, or infinite)
- New zset flags:byTarget, score is the number of times a flag has been made
  against that item
- "already-flagged" translation key removed, now "post-already-flagged" or
  "user-already-flagged" -- this fixed bug where flagging a user you've already
  flagged would tell you you've already flagged this post already.
- Refactored Flags.canFlag to throw errors only, instead of returning boolean
- Updated ACP form inputs for reputation settings page to be more bootstrappy
- +1 upgrade script
2020-07-15 17:10:49 -04:00