Commit Graph

11491 Commits

Author SHA1 Message Date
Julian Lam
d41de481a4 chore: remove deprecated plugin hook methods [breaking]
Call plugins.hooks.fire() instead.
2021-01-27 16:18:19 -05:00
Julian Lam
cc0d562e9a chore: more removals of thumb specific backwards-compatibility [breaking] 2021-01-27 16:17:14 -05:00
Julian Lam
5f9f241e37 chore: remove deprecated filter:admin/header.build hook [breaking]
Use `filter:middleware.renderAdminHeader` instead.
2021-01-27 16:10:19 -05:00
Julian Lam
84dfdfe659 chore: remove deprecated v2 style responses for thumbs upload route [breaking] 2021-01-27 16:10:13 -05:00
Julian Lam
2ad0d0d0d8 chore: remove deprecated getObject routes [breaking]
`/api/post/pid/:pid`, `/api/topic/tid/:tid`, `/api/category/cid/:cid` have now been removed in favour of routes in the Write API (`/api/v3/(posts|topics|categories)/:id`)
2021-01-27 16:07:00 -05:00
Julian Lam
7b090c588b fix: incorrect return for Thumbs.get() if thumbs were disabled 2021-01-27 14:33:40 -05:00
Julian Lam
dc84559d0b feat(topic-events): topic events GET route in write API 2021-01-27 13:16:49 -05:00
Julian Lam
449c379d22 feat(topic-events): server-side tests for topic events 2021-01-27 13:16:49 -05:00
Julian Lam
0d4a377558 feat(topic-events): clear out topic events when a topic is purged 2021-01-27 13:16:49 -05:00
Julian Lam
8e93bf7362 feat(topic-events): client-side handling on topic event log 2021-01-27 13:16:49 -05:00
Julian Lam
df2fdd56ba fix(topic-events): repeated invocations of Posts.addTopicEvents caused dupes to be added to DOM 2021-01-27 13:16:49 -05:00
Julian Lam
cec3fc934d refactor(topic-events): break out some logic in events.get into local modifyEvent method
+ events.log now returns a complete event object
2021-01-27 13:16:49 -05:00
Julian Lam
611d1f872d feat(topic-events): support for uids in topic event payloads 2021-01-27 13:16:49 -05:00
Julian Lam
425eca145b refactor(topic-events): fire topic event logging in topics/tools instead, pass uid into payload 2021-01-27 13:16:49 -05:00
Julian Lam
ab2e1ecb40 feat(topic-events): work in progress topic events logic and client-side implementation 2021-01-27 13:16:49 -05:00
Julian Lam
8ff07bc196 fix: update js concatenation logic to bundle scripts.rjs into minfile regardless of build environment
The slowdown is fairly insignificant (< .1s), and the only change is the minified file is identical across environments, which is better from a debugging standpoint
2021-01-27 12:23:02 -05:00
Julian Lam
412d285850 fix(hooks): fallback handling for core invocations of hooks.fire
+ .on() which is the same as .register()
2021-01-27 12:23:02 -05:00
Julian Lam
f975063b7d fix: #7125, allow list for page route, configurable via plugin hook 2021-01-25 16:01:10 -05:00
Julian Lam
8b72479f62 fix: remove 'filters' and 'categories' from flag details API return [breaking]
These options were originally used when the flag filters were shown in the sidebar. This has seen been removed, and so the information is now superfluous
2021-01-25 12:13:09 -05:00
Julian Lam
1603566bcc fix: filtering logic of flags [breaking]
When combining filters, the old logic assumed that every filter was
exclusive, unless that filter contained multiple items, in which
case it was added to a list of "or" filters that returned all
matching flags.

A fault was discovered in that if you passed in multiple "or"
states, it did not return flags with the expected filtering.

e.g. open flags, closed flags, flags of cid 1, flags of cid 2

This could return open flags of cid 3, since all of the filters
were "OR"'d.

This logic change updates the behaviour so disparate OR sets are
intersected (ANDed).
2021-01-25 11:29:00 -05:00
Julian Lam
942d924779 fix: error on flag list if no flag filters were saved in session 2021-01-25 11:19:16 -05:00
Julian Lam
6b1c97db79 feat: feature flag for auto-resolving a user's flags on ban [breaking]
The default behaviour has now been changed to 'off'. Going forward, a user's flags will no longer automatically resolve on ban.
2021-01-25 11:07:29 -05:00
Julian Lam
35c92d0cff fix: mod cid filter accidentally saved in session 2021-01-24 14:23:00 -05:00
Julian Lam
27cae0d5d8 fix: missing return for #9217 2021-01-24 14:01:16 -05:00
Julian Lam
b2b1450e5d fix: #9217, render 400 error page on bad access to /register 2021-01-24 13:59:16 -05:00
Barış Soner Uşaklı
78896fc623 fix: redis check compat tests 2021-01-23 00:04:48 -05:00
Barış Soner Uşaklı
fdfbc90255 feat: async/await redis connection 2021-01-22 23:59:52 -05:00
Barış Soner Uşaklı
33bf1b0e2c feat: async/await psql connection 2021-01-22 22:10:34 -05:00
Barış Soner Uşaklı
672959c13f feat: add group name to csv event 2021-01-22 13:14:14 -05:00
Julian Lam
a186ea0fe3 fix: registration completion overriding returnTo if it was already set 2021-01-22 10:01:42 -05:00
Julian Lam
280285cda9 feat: allow interstitial callbacks to be async functions [breaking]
This change is breaking in the sense that if you have written
interstitial callbacks before that are async functions _with_ a
callback, those are no longer allowed. You will not need to call
next() as that argument will no longer be passed in to async
functions.
2021-01-22 10:01:42 -05:00
Barış Soner Uşaklı
5c1b742979 fix: add missing user delete event types 2021-01-20 20:16:32 -05:00
Barış Soner Uşaklı
7fb583dcfd Merge branch 'master' of https://github.com/NodeBB/NodeBB 2021-01-18 19:31:14 -05:00
Barış Soner Uşaklı
c608b0e8a3 fix: https://github.com/NodeBB/nodebb-plugin-webhooks/issues/3 2021-01-18 19:31:07 -05:00
Julian Lam
d85ad10d34 fix: restored sanity checks for post move socket calls 2021-01-18 15:47:15 -05:00
Julian Lam
966c4117ec refactor(api): post move to write API 2021-01-18 15:31:14 -05:00
Julian Lam
e118e59ce0 refactor(api): post diffs to use write API 2021-01-18 14:26:22 -05:00
Barış Soner Uşaklı
c2e2370655 feat: add filter:email.cancel to allow plugins to cancel sending emails 2021-01-18 13:34:28 -05:00
Julian Lam
f5fcd232f6 fix: regression caused by 77ab46686d
Access checks were added for topic GET route, but occasionally a post_uuid is passed in, which is available to everyone, and so checks should be skipped
2021-01-17 15:43:29 -05:00
Barış Soner Uşaklı
4fb907875e fix: don't crash if fullname is not a string
https://community.nodebb.org/topic/15291/upgrade-error-fullname-substr-is-not-a-function
2021-01-17 13:10:28 -05:00
Barış Soner Uşaklı
1374e0eeba refactor: change var to const 2021-01-16 12:54:11 -05:00
Barış Soner Uşaklı
00ba89b6d6 fix: #9204, bypass groupname length check for system group in upgrade script 2021-01-16 09:37:32 -05:00
Barış Soner Uşaklı
9938a139fe fix: add missing await 2021-01-15 14:42:19 -05:00
Barış Soner Uşaklı
25ab99b91d refactor: single remove call 2021-01-15 14:41:45 -05:00
Julian Lam
ab11435ed5 feat: grant plugins the ability to specify options to the SSO handler
... to be handled in the plugin itself (overriding the passport prototype's authorizationParams method)

+ new hook filter:auth.options
2021-01-13 16:57:48 -05:00
Julian Lam
9b289eca9d fix: ssoState passed to strategies even if not called for 2021-01-13 16:25:19 -05:00
Julian Lam
77ab46686d fix: access checks for tags and thumbs get route 2021-01-12 17:38:35 -05:00
Julian Lam
c0fb1cb59c fix: #9194 global mods unable to pin or unpin topics 2021-01-12 14:02:12 -05:00
Barış Soner Uşaklı
ef16cd2e6f fix: #9192, exit after logging error 2021-01-12 10:46:55 -05:00
gasoved
69419571a9 fix: make sure inviter user exists 2021-01-11 17:00:17 -05:00