Commit Graph

15 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
9ebfdeb7ee fix: #9580, proper 404 when ajaxifying 2021-05-25 12:44:17 -04:00
Julian Lam
2fef462782 fix: awaiting res.render in send404 controller
>
> A plugin wanted to use `response:rotuer.page` to 404 a specific page on some condition. res.render returns early in send404 and so must be awaited otherwise multiple responses will be sent
2021-02-17 11:57:12 -05:00
Barış Soner Uşaklı
b6493f896f fix: tests, only generate csrf_token on 404 gets 2021-02-09 12:40:29 -05:00
Barış Soner Uşaklı
94f72d6093 fix: #9287, generate csrf_token on 404 2021-02-09 12:23:55 -05:00
Peter Jaszkowiak
707b55b6a5 chore: eslint prefer-template 2021-02-08 18:06:44 -05:00
Julian Lam
6e2da9966e refactor: move plugin hook methods to plugin.hooks.* 2020-11-20 16:32:39 -05:00
Julian Lam
9f3b78118a fix: send hard 404 instead of soft 404 for missing modules
We used to send a soft 404 because require.js would error out on
a 404, but it seems years ago, error handling was added to the
require() call, so a hard 404 will not throw errors to the console
2020-08-07 11:32:07 -04:00
Barış Soner Uşaklı
842b8abb84 feat: add buildHeaderAsync (#8367)
* feat: add buildHeaderAsync

make helphers.notAllowed async

* fix: remove csrf from buildHeader

* fix: remove unused method, use middleware

* fix: /post/pid redirect doesn't need buildHeader

use buildHeaderAsync
2020-06-04 01:14:46 -04:00
Barış Soner Uşaklı
ec3b5dd95a refactor: async/await routes/feeds 2019-09-16 23:05:59 -04:00
Julian Lam
831d079512 fix: #7274 incorrect handling of client script 404s 2019-01-21 11:39:53 -05:00
Baris Usakli
0d409610c4 fix: #7181 2019-01-02 13:33:15 -05:00
Barış Soner Uşaklı
ae0fe5e880 feat: more naming 2018-12-17 16:56:38 -05:00
Barış Soner Uşaklı
26d4e0852f use includes instead of indexOf
use _.uniq instead of filter&indexOf
2018-10-20 14:40:48 -04:00
Barış Soner Uşaklı
a4ba88dc60 more feed tests 2017-05-21 19:45:29 -04:00
barisusakli
bc8d297377 move out error and 404 controllers 2017-03-02 14:57:33 +03:00