Commit Graph

685 Commits

Author SHA1 Message Date
Julian Lam
9cbe9389f5 fix: use promises in privilege save
... instead of jQuery Deferreds
2020-08-21 12:02:53 -04:00
Barış Soner Uşaklı
4216c277d5 feat: focus username when modal is shown 2020-08-04 13:39:27 -04:00
Julian Lam
2ee6248316 refactor: for codeclimate 2020-08-03 21:01:36 -04:00
Julian Lam
a7071bb808 fix: map instead of forEach in privileges save 2020-08-03 20:50:17 -04:00
Julian Lam
a716a5529c feat: more discrete commit-on-save instead of commit-on-change w/ confirm modals (#8541)
* feat: privileges save button, #8537, WIP

* fix: disable firefox autocomplete on privilege form fields

* feat: closes #8537 privilege changes commit on save

- new language strings for confirmation and success modals/toasts
- indeterminate privilege handling (/cc @psychobunny)
- added new discard button
- both discard and save buttons now have confirmation dialogs

* fix(tests): remove duplicate template helper test

* fix(tests): broken template helper test

* feat: confirm dialogs for all privilege copy actions

Also, ability to add user to a privilege table without needing
to refresh the privilege table.

* feat: group row addition w/o table refresh

breaking: helpers.getUserPrivileges and helpers.getGroupPrivileges
no longer make socket calls to the following hooks:

- filter:privileges.list, filter:privileges.admin.list,
  filter:privileges.global.list, filter:privileges.groups.list,
  filter:privileges.admin.groups.list,
  filter:privileges.gloval.groups.list

The filters are still called, but done before the helper method
is called, and the results are passed in instead. This change
should only affect you if you directly call the helper methods,
otherwise the change is transparent.

* fix: stale ajaxify data on privilege category switch

* fix: implicit privileges not showing for user privs

* fix: groups, not group, also fix tests

* fix(tests): again

* fix: wrong tpl rendered when adding group to global priv table
2020-08-03 20:42:45 -04:00
Barış Soner Uşaklı
e7a502e0aa feat: add ability to search groups in group details page 2020-07-31 21:21:15 -04:00
Barış Soner Uşaklı
9e80a9efdd fix: #8534, dont show modal on search 2020-07-30 22:33:11 -04:00
Barış Soner Uşaklı
fb7bb8d400 feat: use category selector in category page
fix privilege shortcuts in group page after search
2020-07-30 14:55:28 -04:00
Barış Soner Uşaklı
91411cc47c feat: add privileges shortcut to groups list
fix issues with escape group names
2020-07-30 12:26:37 -04:00
Barış Soner Uşaklı
bbc7737e14 feat: ability to clear cache from acp 2020-07-29 12:50:18 -04:00
Barış Soner Uşaklı
8d8117ffa1 feat: reduce amount of data loaded on acp admin page
get rid of socket call and use ajaxify.data.categories
2020-07-29 11:57:20 -04:00
Julian Lam
8473e165a6 fix: too small sortable handle for ACP>Manage>Categories
The handle was initially just the icon, but now it is the icon
and the category label itself.
2020-07-27 16:07:52 -04:00
Barış Soner Uşaklı
24535a62e7 feat: make category tools in acp a dropdown
add view category, view privileges into dropdown
2020-07-27 12:39:32 -04:00
psychobunny
bc26883aed refactor: setting codeclimate to A 2020-07-23 23:23:35 -04:00
psychobunny
a6ae69737b Merge branch 'master' of https://github.com/NodeBB/NodeBB 2020-07-23 18:34:20 -04:00
psychobunny
10e4ae629c feat: highlight privs row if group is added / navigating from group page 2020-07-23 18:34:07 -04:00
psychobunny
53f6139b8c feat: prevent navigation away from groups page if changes are unsaved 2020-07-23 18:06:55 -04:00
psychobunny
2c83278f97 feat: quick access dropdown on groups page to access privileges page 2020-07-23 17:59:52 -04:00
Barış Soner Uşaklı
844f2b4ed0 feat: #8524, allow editing category of queued topic 2020-07-23 16:43:56 -04:00
Barış Soner Uşaklı
2485a55092 feat: #8521, allow editing title before posting from queue 2020-07-20 21:28:17 -04:00
Barış Soner Uşaklı
1e7397b1b8 feat: allow searching categories in ACP 2020-07-20 13:17:08 -04:00
Barış Soner Uşaklı
00d39fb32c feat: #8460, export groups members as csv 2020-07-10 13:12:14 -04:00
Barış Soner Uşaklı
3dcf538773 feat: #8023, allow wildcard search for uid/email 2020-07-09 23:57:54 -04:00
Barış Soner Uşaklı
4adbf87c6c feat: warn user if whitelisted tags are less than minTags 2020-07-08 21:36:48 -04:00
Julian Lam
f3441fce4f fix: admin privileges client-side regression 2020-07-03 11:39:34 -04:00
Barış Soner Uşaklı
2355d9d5dd fix: escape navigation item fields, theme:id, category fields 2020-06-26 15:19:18 -04:00
Barış Soner Uşaklı
ed4b5caf2c fix: copy settings showing empty category selection 2020-06-24 16:02:01 -04:00
Julian Lam
2515aa77ba fix: bug where category privs page thought it was on admin 2020-06-15 16:33:38 -04:00
Barış Soner Uşaklı
8591f5d2cc fix: return false 2020-06-10 08:02:07 -04:00
Julian Lam
67aca822e6 feat: account content deletion, closes #8381 2020-06-08 08:43:31 -04:00
Julian Lam
a82e9bd7f6 feat: privileges for Admin Control Panel (#8355)
* feat: acp privileges (WIP)

* fix: restore global privilege hooks

* refactor: using cid 0 in admin privs

* fix: no need for zebrastripe-reset

* feat: manage:categories privilege WIP

* feat: renamed prefix to admin:, settigns and dashboard privs

* fix: nofocus on acp privs group find modal

* refactor: privileges.x.get() to not used hardcoded privs

* fix: crash if unable to get latest version

* feat: setting acp priv

* Revert "fix: crash if unable to get latest version"

This reverts commit afdb235f48.

* feat: user/privilege acp privs

* fix: category selector in manage/privileges

* fix: guests potentially becoming admins

* fix: bug in setting admin privs

* fix: some last minute things + api docs

* fix: some more last minute fixes
2020-06-05 15:26:51 -04:00
Barış Soner Uşaklı
30cc83c033 fix: #8374, revert event delete 2020-06-05 12:56:20 -04:00
Julian Lam
922d49be0b fix(style): switch..case 2020-06-03 11:26:08 -04:00
Julian Lam
a51fff8bd1 refactor: remove general menu from ACP (#8347)
* refactor: remove general menu from ACP

* fix: incorrect translation keys, fixed tests
2020-05-29 09:59:22 -04:00
Barış Soner Uşaklı
5781a2dc65 feat: fix session mismatch errors by clearing cookie on logout (#8338)
* feat: fix session mismatch errors by clearing cookie on logout

* feat: remove app.upateHeader

ported from 2.0

* feat: handle if user doesn't click button and just refreshes page
2020-05-27 12:15:02 -04:00
Opliko
4855f1deca fix:#8274 Don't escape HTML in manage users (#8275)
Perhaps the HTML for managing groups should ba actually rendered as HTML to serve its function. fixes #8274
2020-04-28 20:32:15 -04:00
Julian Lam
1b425ef108 fix: no focus on find user modal 2020-04-14 10:18:20 -04:00
Julian Lam
bcbf98aa4c fix: accidental fp precision on flag and acp dash graphs 2020-04-14 10:16:02 -04:00
Barış Soner Uşaklı
080317300a fix: #8221, fix parent selection 2020-03-22 12:32:12 -04:00
Barış Soner Uşaklı
2f9c7c626f fix: #8203, fix user invites refreshing page 2020-03-11 12:21:46 -04:00
Barış Soner Uşaklı
bc93b5676c fix: #8175 2020-02-22 16:01:04 -05:00
Julian Lam
14655f8745 fix: no decimal places for category analytics 2020-02-07 10:22:13 -05:00
yossizahn
09d55581d8 Fix: ACP > manage > group: save disableLeave (#8123)
* Fix: ACP > manage > group: save disableLeave

* Fix eslint comma-dangle
2020-01-17 09:38:23 -05:00
Opliko
879acc85ae Add disable/enable category to category edit page (#8118) 2020-01-14 17:30:56 -05:00
Barış Soner Uşaklı
5a8217de01 fix: #8105, fix export json on page load 2020-01-04 10:34:20 -05:00
Barış Soner Uşaklı
c1b1ee61f3 fix: create user modal instantly closing 2019-12-27 09:51:41 -05:00
Barış Soner Uşaklı
05c9fe2735 feat: #5272, allow changing user groups from manage users page 2019-12-04 11:14:01 -05:00
Baris Usakli
c2cd7de891 fix: #8069, dont show hidden groups in search 2019-11-29 13:35:50 -05:00
Julian Lam
645d647248 feat: wip, better digest handling (+ eventual digest resend logic) (#7995)
* feat: wip, better digest handling (+ eventual digest resend logic)

- await emailer.send call in digest.send method
- save send success to a new sorted set digest:{interval}:byUid

* feat: continuing work on digest tools

- Added ACP page to view digest settings and delivery times per user

* feat: added paginator and stub buttons for resending digest

* feat: wrapping up digest revamp

- New language strings in ACP digest page
- Client-side ACP script for digest ACP page
- Websocket call for ACP page to execute digests
- Broke out logic to retrieve user digest settings to getUsersInterval

* fix: minor cleanup

* fix: #8010 and some style suggestions from baris

* fix: resolve confusing comment
2019-11-02 13:11:02 -04:00
Baris Usakli
554e67116f feat: remove ability to delete events from acp 2019-10-11 11:32:11 -04:00