Commit Graph

664 Commits

Author SHA1 Message Date
psychobunny
771a8955a4 fix: #9362 best not to check file exists on every page load; copying favicon to uploads/system folder instead 2021-03-09 22:46:43 -05:00
psychobunny
ad5654952a fix: #9362 2021-03-09 22:32:34 -05:00
psychobunny
e5133a78f8 feat: add $.deserialize to client side 2021-03-04 20:48:29 -05:00
Barış Soner Uşaklı
902a88c25e feat: remove promise-pollyfil 2021-03-04 13:27:02 -05:00
Peter Jaszkowiak
5c2f0f0557 chore: eslint no-restricted-syntax 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
115d19e289 chore: eslint prefer-rest-params, prefer-spread 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
23f212a4c0 chore: eslint prefer-destructuring 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
dab3b23575 chore: eslint no-var, vars-on-top 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
b56d9e12b5 chore: eslint prefer-arrow-callback 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
707b55b6a5 chore: eslint prefer-template 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
4ee0f1459d chore: eslint import/newline-after-import 2021-02-08 18:06:44 -05:00
Julian Lam
d6f60f4502 fix: broken test after sorted-lists logic change 2021-02-01 14:51:16 -05:00
Julian Lam
d5d24594e8 feat: allow sorted-lists on multiple pages
If multiple sorted-lists were on separate pages, saving one page would erase the sorted-lists saved on the other page. This was caused by naive deletion of the sorted-lists index on settings save.

At the same time, a bug was found where if fewer items were passed in, only that many items were removed from the database, leaving leftover orphan data in the database.

The logic now:

- Only removes sorted-lists if they are passed in (and empty)
- Deletes all sorted list items, not just the items passed in.
2021-02-01 11:47:26 -05:00
Julian Lam
a8be6fb8fb fix: regression where filter:settings.set no longer received sorted-lists 2021-01-31 16:59:03 -05:00
Julian Lam
473d5f4aba fix: full settings hash not passed through to action:settings.set
The sorted lists were being filtered out
2021-01-29 15:18:57 -05:00
Julian Lam
eb96046e97 Revert "refactor: use Map to track sorted lists in Settings.set()"
This reverts commit 65de2e76b4.
2021-01-29 15:07:09 -05:00
Julian Lam
65de2e76b4 refactor: use Map to track sorted lists in Settings.set() 2021-01-29 15:00:14 -05:00
Julian Lam
8ff07bc196 fix: update js concatenation logic to bundle scripts.rjs into minfile regardless of build environment
The slowdown is fairly insignificant (< .1s), and the only change is the minified file is identical across environments, which is better from a debugging standpoint
2021-01-27 12:23:02 -05:00
Julian Lam
412d285850 fix(hooks): fallback handling for core invocations of hooks.fire
+ .on() which is the same as .register()
2021-01-27 12:23:02 -05:00
Peter Jaszkowiak
a51c5698c7 fix: --help usage info
yargs (via nconf) would exit when detecting a help flag

also improves the speed of `./nodebb help build`
2021-01-06 20:43:07 -05:00
Barış Soner Uşaklı
bb6cc49c16 perf: dont build identical langs 2020-12-06 19:10:56 -05:00
Barış Soner Uşaklı
4a0d883359 breaking: #8808, remove utils.slugify 2020-12-06 13:18:09 -05:00
Peter Jaszkowiak
ba3981e270 fix: use package.name for theme.id (#8965)
Prevents cases like #8953
2020-11-26 16:59:23 -05:00
Barış Soner Uşaklı
3af4d13fa5 fix: basepath for r.js modules 2020-11-25 12:46:09 -05:00
Julian Lam
6e2da9966e refactor: move plugin hook methods to plugin.hooks.* 2020-11-20 16:32:39 -05:00
Peter Jaszkowiak
d30ea25629 feat(deps): benchpressjs@2.2.1 (#8887)
Better warnings, faster template compiles
2020-11-16 11:55:24 -05:00
Tudor-Dan Ravoiu
452d7f2b17 Create verified/unverified user groups (#8889)
Co-authored-by: Tudor-Dan Ravoiu <tudor-dan.ravoiu@ubisoft.com>
2020-11-16 10:10:28 -05:00
Barış Soner Uşaklı
6255874e32 feat: move mkdirp to beforeBuild so it doesnt get called twice 2020-11-06 13:44:29 -05:00
Barış Soner Uşaklı
74951f5967 fix: #8846, possible fix 2020-11-06 12:46:27 -05:00
Barış Soner Uşaklı
a05905f196 performance improvements (#8795)
* perf: nconf/winston/render

cache nconf.get calls
modify middleware.pageView to call next earlier
don't call winston.verbose on every hook see https://github.com/winstonjs/winston/issues/1669
translate header/footer separately and cache results for guests

* fix: copy paste fail

* refactor: style and fire hook only log in dev mode

* fix: cache key, header changes based on template

* perf: change replace

* fix: add missing await

* perf: category

* perf: lodash clone

* perf: remove escapeRegexChars
2020-10-26 10:43:18 -04:00
Barış Soner Uşaklı
156e1396f2 fix: #8789,cache meta.settings 2020-10-23 14:20:47 -04:00
Julian Lam
ff4fcc23b6 Update bundled logos with new branding (#8702)
* feat: updating logo assets, square logos missing still

* fix: squared logo for touch icon and notification fallback

* fix: update link to favicon

* feat: add default touch icon sizes, if one isn't uploaded

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2020-10-18 01:41:04 -04:00
Barış Soner Uşaklı
bae0f343e1 fix: module build 2020-10-14 23:32:30 -04:00
Barış Soner Uşaklı
1fd2eba6f2 refactor: async/await
src/cli/manage.js
src/meta/build.js
src/meta/css.js
src/meta/js.js
2020-10-14 22:49:39 -04:00
Barış Soner Uşaklı
dc29f4dca2 refactor: switch to using slugify module 2020-10-11 21:49:37 -04:00
Barış Soner Uşaklı
bddfcb5867 feat: #8734, add slugify module, deprecate utils.slugify 2020-10-11 21:25:31 -04:00
Barış Soner Uşaklı
f16c8268cf feat: #8734, move bootstrap-tagsinput to package.json 2020-10-11 19:52:01 -04:00
Barış Soner Uşaklı
eab7489ec5 feat: #8734, move deserialize/serialize to package.json 2020-10-11 19:28:46 -04:00
Barış Soner Uşaklı
948f26143c feat: #5964, #8734 remove colorpicker 2020-10-11 16:05:52 -04:00
Barış Soner Uşaklı
aedd28e0a6 fix: module name 2020-10-10 23:45:58 -04:00
Barış Soner Uşaklı
cc705e5e2b feat: #8734, move sortable to package.json 2020-10-10 23:24:13 -04:00
Barış Soner Uşaklı
300a87559f feat: #8734, move bootbox to package.json 2020-10-10 22:15:34 -04:00
Barış Soner Uşaklı
420a312982 Merge branch 'master' of https://github.com/NodeBB/NodeBB 2020-10-10 21:55:03 -04:00
Barış Soner Uşaklı
3b231360d3 feat: load jquery-form before using 2020-10-10 21:54:32 -04:00
Barış Soner Uşaklı
fda2aedfd8 feat: #8734, jquery-ui, jquery-form, timeago (#8748)
* feat: #8734, jquery-ui, jquery-form, timeago

get rid of forum/footer.js move that code to app.js & wait for app to load before calling ajaxify.end
make sockets.js a requirejs module
move jquery-ui to node_modules and load via requirejs
move jquery-form to node_modules and load via requirejs
move timeago to node_modules and load via requirejs
only include the css for needed jquery-ui widgets

* feat: keep socket/io global for backwards compat

* refactor: move socket listener to chat
2020-10-10 21:47:27 -04:00
Barış Soner Uşaklı
ae3a231fce feat: #8734, remove semver.browser
use compare-versions as a module
2020-10-09 14:10:38 -04:00
Barış Soner Uşaklı
2c1897b373 feat: #8734, move slideout to package.json 2020-10-09 12:20:09 -04:00
Barış Soner Uşaklı
9c157de05d feat: #8734, move tinycon to package.json 2020-10-09 12:01:51 -04:00
Barış Soner Uşaklı
45e8a4d588 fix: #8734 make nprogress module 2020-10-09 11:48:52 -04:00
Barış Soner Uşaklı
43589a744d feat: #8734, move visibilityjs to package.json 2020-10-09 11:35:52 -04:00