Mats
2b42e7edb0
chore: lint
2021-06-07 10:54:07 -04:00
Mats
6f73261186
fix: extra ')'
2021-06-07 10:54:07 -04:00
Mats
d07229aa6b
chore: fix indentation
2021-06-07 10:54:07 -04:00
Mats
edcba61aa9
fix: disallow editing of other users' notes
...
Feel free to close this if it is intentional, but as you are not allowed to delete other users notes I expect you shouldn't be able to edit them. Editing another users post also changes ownership, allowing you to then delete it.
I also added `error:` to the errormessage so that they display properly.
2021-06-07 10:54:07 -04:00
Barış Soner Uşaklı
ca72aa93d7
Locks bug failing test ( #9595 )
...
* test: failing test for issue
* fix : #9593 , don't lock if email is identical to username
* fix: lock calls after first call
* fix: add back email check
* test: remove invalid test
Co-authored-by: Julian Lam <julian@nodebb.org >
2021-06-07 10:26:00 -04:00
Julian Lam
816856b0c6
feat: introduce boolean res.locals flag to bypass session reroll (used by session-sharing)
...
The session reroll logic is still standard practice, but in some cases, it is not necessary or causes UX issues. An issue opened in session sharing (julianlam/nodebb-plugin-session-sharing#95 ) brought this to attention in that parsing the cookie to log in the user caused a reroll (as expected), but caused the session open on other tabs to be mismatched. If "re-validate" was turned on, it basically meant that it was not possible to use NodeBB with multiple tabs.
Session sharing now sets `reroll` to `false` if re-validate is enabled.
2021-06-04 11:37:06 -04:00
Barış Soner Uşaklı
286644d0b8
fix : #9592 , check session
2021-06-04 09:41:23 -04:00
Barış Soner Uşaklı
3717df610a
fix: don't crash if session doesn't exist
2021-06-03 17:11:25 -04:00
Barış Soner Uşaklı
66cae54ee3
fix: lint
2021-06-01 11:26:18 -04:00
Barış Soner Uşaklı
57e46e41e3
feat: allow modifying default category privileges
2021-06-01 11:21:15 -04:00
Julian Lam
16e0bca570
fix: improper use of filename extensions
2021-05-28 14:05:30 -04:00
Barış Soner Uşaklı
d8d6c98970
fix: return null
2021-05-28 12:32:52 -04:00
Barış Soner Uşaklı
ac7b093f99
feat: add filter:notifications.create
2021-05-28 12:31:49 -04:00
Barış Soner Uşaklı
3fb7444580
fix: returnOriginal deprecation
...
https://github.com/mongodb/node-mongodb-native/pull/2808
2021-05-28 11:12:21 -04:00
Barış Soner Uşaklı
3d5fef6e80
feat: pass req.query to getUnreadData
2021-05-27 10:02:54 -04:00
Julian Lam
d2960aeb09
feat: added GET user route for api v3
2021-05-26 12:35:37 -04:00
Julian Lam
48b8e3bb3f
fix: error when trying to trim an object
2021-05-26 12:32:06 -04:00
Barış Soner Uşaklı
9ebfdeb7ee
fix : #9580 , proper 404 when ajaxifying
2021-05-25 12:44:17 -04:00
Barış Soner Uşaklı
09f5179216
fix: lint
2021-05-25 12:04:34 -04:00
Barış Soner Uşaklı
77dde41f7b
feat: keep query string when redirecting category
2021-05-25 11:57:10 -04:00
Barış Soner Uşaklı
951e71a0e5
fix : #9567 fix tests
2021-05-20 11:20:19 -04:00
Barış Soner Uşaklı
5215c30ade
fix : #9567 , use regular 404
2021-05-20 10:41:47 -04:00
Barış Soner Uşaklı
3d6bdeb3df
feat: add req.query to flags.list/getCount
2021-05-19 10:01:33 -04:00
Barış Soner Uşaklı
d35c64b1a2
feat: add filter:flags.getFlagIdsWithFilters
2021-05-18 10:54:43 -04:00
Barış Soner Uşaklı
1ec9739629
switch to request-promise-native ( #9561 )
...
* refactor: cli/upgrade async/await
async/await cli/upgrade-plugins
remove unused payload.files
* fix: add missing await
* refactor: use request-promise-native
2021-05-17 17:24:23 -04:00
Barış Soner Uşaklı
ac86937c88
refactor: cli/upgrade async/await ( #9558 )
...
* refactor: cli/upgrade async/await
async/await cli/upgrade-plugins
remove unused payload.files
* fix: add missing await
2021-05-17 17:08:00 -04:00
Barış Soner Uşaklı
1ce595083a
fix: ioredis upgrade fix, maybe
2021-05-17 13:59:11 -04:00
Barış Soner Uşaklı
4afca6900b
feat: add filter:user.getWatchedCategories
2021-05-17 12:12:16 -04:00
Julian Lam
1d9cfe1e96
fix: bug where interstitial errors were not properly passed to the front-end via req.flash
2021-05-17 10:50:58 -04:00
Barış Soner Uşaklı
518157d9fa
feat: pass req.query to getUserDataByUserSlug
2021-05-17 10:26:32 -04:00
Barış Soner Uşaklı
0551642a35
fix : #9553 , use same fields for user search results in acp
2021-05-14 13:00:56 -04:00
Barış Soner Uşaklı
94c12e3771
feat: #9508 , add cluster support
2021-05-14 10:56:03 -04:00
Barış Soner Uşaklı
a3d6c56ec3
feat: #9551
2021-05-13 12:16:53 -04:00
Barış Soner Uşaklı
ffa8016355
fix: lint
2021-05-12 10:41:38 -04:00
Barış Soner Uşaklı
fad5988ed6
fix: tests
2021-05-12 10:38:11 -04:00
Barış Soner Uşaklı
074ee859c4
fix: tests
2021-05-12 10:28:35 -04:00
Barış Soner Uşaklı
1f3e660108
feat: add template to hook
2021-05-12 10:22:51 -04:00
Barış Soner Uşaklı
a2442ee914
feat: add filter:account.getPostsFromUserSet
2021-05-12 10:20:45 -04:00
Peter Jaszkowiak
dd81dd03e0
fix( #9508 ): switch to ioredis ( #9545 )
...
* switch to ioredis
also need this fix in redisearch:
redis-search.js:98
```
redisClient.multi(cmds).exec(function(err, ids) {
if (err) {
return callback(err);
}
var errRes = ids[resultIndex];
if (errRes[0]) {
return callback(errRes[0]);
}
callback(null, errRes[1]);
});
```
* dbsearch compatible with ioredis
* fixed dbsearch?
2021-05-11 14:18:45 -04:00
Barış Soner Uşaklı
0096cf178a
refactor: bubble other errors
2021-05-10 11:34:54 -04:00
Julian Lam
a9bb108802
fix: wrong error message checked
2021-05-10 11:33:20 -04:00
Julian Lam
ec6d1e2321
fix : #9507 session reroll causes socket.io to become confused ( #9534 )
...
* fix : #9507 session reroll causes socket.io to become confused
* fix: added return
* fix: simpler logic for error handling
* fix: overly sensitive catch
2021-05-10 11:22:37 -04:00
Barış Soner Uşaklı
f6b583bb9d
feat: #9533 , allow redirect in build hooks
2021-05-07 09:32:06 -04:00
Barış Soner Uşaklı
2c22b06feb
fix: isObjectField(s) empty field
2021-05-06 12:44:01 -04:00
Barış Soner Uşaklı
7c1e163d82
Revert "feat: add _hooks metadata object to all hooks that have object-type params"
...
This reverts commit 46899ccadb
2021-04-30 12:16:30 -04:00
Julian Lam
46899ccadb
feat: add _hooks metadata object to all hooks that have object-type params
2021-04-30 11:23:07 -04:00
Barış Soner Uşaklı
d8e4fd4cdd
feat: add filter:categories.copySettingsFrom
2021-04-30 10:06:19 -04:00
Barış Soner Uşaklı
084c985117
feat: guard against multiple resolves
2021-04-29 10:47:23 -04:00
Barış Soner Uşaklı
5fe97b9c2e
revert: sync hooks
2021-04-28 15:00:43 -04:00
Barış Soner Uşaklı
6ed8890c2e
fix : #9512 , fix chat icon if no privileges
2021-04-27 10:00:52 -04:00
