Commit Graph

107 Commits

Author SHA1 Message Date
Peter Jaszkowiak
2be396ff6e fix: email testing and settings change from ACP
- changing email SMTP settings wouldn't apply the first time
- "Send Test Email" now will report emailer errors in most cases
2020-12-18 16:39:09 -05:00
Julian Lam
6e2da9966e refactor: move plugin hook methods to plugin.hooks.* 2020-11-20 16:32:39 -05:00
Julian Lam
512f6de6de feat: allow passwords with length > 73 characters (#8818)
* feat: allow passwords longer than 73 characters

Context: A bcrypt/blowfish limitation means that password length is capped at 72 characters. We can get around this without compromising on security
by hashing all incoming passwords with SHA512, and then sending that to bcrypt.

https://dropbox.tech/security/how-dropbox-securely-stores-your-passwords

* feat: add additional test for passwords > 73 chars

* fix: remove 'password-too-long' error message and all invocations

* test: added test to show that a super long password won't bring down NodeBB

* fix: remove debug log

* Revert "fix: remove 'password-too-long' error message and all invocations"

This reverts commit 1e312bf7ef.

* fix: added back password length checks, but at 512 chars

As processing a large string still uses a lot of memory
2020-11-06 08:40:00 -05:00
Barış Soner Uşaklı
872bacf1c4 Admin/users (#8762)
* feat: wip admin/users

* feat: more work

* feat: more fixes

* feat: #8662, verified/unverified user groups

* feat: add filter

* feat: change user search to use filters array

* refactor: remove unused search call

* fix: tests

* fix: cant join system groups

* fix: upgrade script
2020-10-13 22:42:50 -04:00
Julian Lam
30b3fedca4 fix: password reset to invalidate all existing reset tokens for that uid 2020-10-13 11:48:32 -04:00
Barış Soner Uşaklı
dc29f4dca2 refactor: switch to using slugify module 2020-10-11 21:49:37 -04:00
Barış Soner Uşaklı
ac43cd8b6f fix: #8665, trim email before checking validity 2020-09-21 20:50:56 -04:00
Barış Soner Uşaklı
38d3982bf1 fix: #8418
allow updating other profile fields when username isnt being changed
2020-09-12 21:48:56 -04:00
Barış Soner Uşaklı
4be693f2e7 feat: fullname search (#8641)
* feat: fullname search

* fix: take last element

* fix: attempt to fix psql like query

* feat: upgrade sript, another fix attempt

* fix: psql test

* fix: psql scan

* feat: add debug for test

* feat: test collate

* feat: cleanup

* fix: upgrade script
2020-09-11 23:20:49 -04:00
Barış Soner Uşaklı
846b7d2430 refactor: change pwd change logic
add one more test
2020-08-12 22:09:22 -04:00
Julian Lam
16cee1b03b fix: improper targetUid check during password change 2020-08-12 13:23:58 -04:00
Barış Soner Uşaklı
1d3fa3bc4e feat: throw error if uid is missing for update 2020-05-15 15:23:01 -04:00
Barış Soner Uşaklı
00e299e93e feat: closes #8229, add targetUid to action:password.change 2020-04-01 00:11:55 -04:00
Barış Soner Uşaklı
14e7866745 fix: #8179, limit length of location/website/fullname, check grouptitle 2020-02-24 16:58:51 -05:00
Barış Soner Uşaklı
f4381ba366 fix: add missing await to sendValidationEmail 2019-11-07 18:10:30 -05:00
Barış Soner Uşaklı
625b0815bb refactor: shorter, new Date doesnt throw 2019-09-23 23:51:45 -04:00
Barış Soner Uşaklı
babb9d7c55 fix: #7913, dont allow urls in fullname/location, validate birthday 2019-09-23 23:50:04 -04:00
Barış Soner Uşaklı
a7d2b8a1fe refactor: async/await socket.io 2019-09-15 02:14:51 -04:00
Barış Soner Uşaklı
22f8011686 refactor: remove async from isPasswordValid, function is sync 2019-09-11 00:28:42 -04:00
Barış Soner Uşaklı
6fea46b6e2 feat: #7743
user/posts
user/profile
2019-07-16 15:29:58 -04:00
Barış Soner Uşaklı
198d05875f feat: cleanup, use bulk 2019-06-24 21:36:20 -04:00
Julian Lam
80c0d579e3 fix: #7593, unable to set account password if no password set 2019-05-22 13:40:00 -04:00
Andrew Rodrigues
e114b16d7a fix: if editing password is disabled in ACP, prevent direct access via route/socket (related: #7576) 2019-05-09 15:50:51 -04:00
Barış Soner Uşaklı
e17c4b2766 uid fixes 2018-11-17 22:31:39 -05:00
Barış Soner Uşaklı
9c022afae1 Parse int (#6853)
* Store config fields as JSON in the db

Fewer parseInts

* Remove unnecessary parseInts

* remove some dupe code add tests

* remove console.log

* remove more parseInts

* WIP: read meta.configs defaults from defaults.json

remove more parseInts

* more work

* add log for failing test

* update admin pwd

* fix tests, dont require posts/cache before configs are initialized

* handle saves

* Test boolean conditions

* remove more parseInts

* Fix boolean values

* remove lots more parseInts

* removed json parsing

* renamed var to number

* categories dont have timestamp
2018-10-21 16:47:51 -04:00
Barış Soner Uşaklı
d996ea27be closes #6763 2018-09-15 17:59:57 -04:00
Julian Lam
f9d3484ec6 fixes #6543 2018-08-10 16:07:25 -04:00
Julian Lam
b6a5419ca1 closes #6674 2018-07-27 11:54:32 -04:00
Barış Soner Uşaklı
cfb9784527 closes #6641 2018-07-09 14:26:21 -04:00
Julian Lam
7e6007e146 revoke all sessions on email change 2018-06-29 14:23:25 -04:00
Julian Lam
be0ef799ee closes #6592 2018-06-29 14:16:28 -04:00
Barış Soner Uşaklı
6eea11a4fd closes #6529 2018-05-28 13:30:11 -04:00
Barış Soner Uşaklı
72140e5338 closes #5991, closes #5884 2018-01-12 17:29:47 -05:00
Barış Soner Uşaklı
caaa72b752 closes #6124 2017-11-27 12:52:08 -05:00
Peter Jaszkowiak
46fafb20b9 Remove string.js dependency 2017-10-13 21:02:41 -06:00
Baris Usakli
753f1576ce processSortedSet 2017-08-16 16:47:52 -04:00
Julian Lam
f56578ab50 remove reset tokens if target user email changes 2017-08-16 14:37:00 -04:00
psychobunny
228e9ab8e3 proof of concept for #5740 2017-06-20 16:12:55 -04:00
Julian Lam
d2b5b53cb4 refactor for sendValidationEmail, and sending better dummy data for welcome email template 2017-05-30 13:09:30 -04:00
Barış Soner Uşaklı
8920523e06 more tests 2017-05-13 21:45:54 -04:00
Julian Lam
d18cfced96 Merge remote-tracking branch 'origin/master' into develop 2017-04-12 23:57:14 -04:00
Peter Jaszkowiak
1ed571189c Make utils and translator easier to require
Move utils.walk to file.walk, backwards compatible
2017-04-08 20:27:52 -06:00
Julian Lam
1ebbbdd3f9 Merge remote-tracking branch 'origin/master' into develop 2017-03-15 10:01:00 -04:00
barisusakli
6a4b082080 closes #5524 2017-03-15 12:19:09 +03:00
Julian Lam
af2d9fb85b Merge branch 'master' into develop 2017-03-06 09:51:11 -05:00
barisusakli
b060bda8a0 some more refactors 2017-03-02 17:25:32 +03:00
Julian Lam
72e77772db Merge branch 'master' into develop 2017-02-24 12:46:40 -05:00
Peter Jaszkowiak
896c8c7343 ESlint object-curly-spacing 2017-02-18 12:30:49 -07:00
Peter Jaszkowiak
3b0dd2d1ef ESlint padded-blocks 2017-02-18 02:32:24 -07:00
Peter Jaszkowiak
604358ecc4 ESlint keyword-spacing, no-multi-spaces 2017-02-18 01:52:56 -07:00