Commit Graph

11394 Commits

Author SHA1 Message Date
Julian Lam
75b1bbd09f feat: explicitly add filter:admin/header.build hook
As it is not fired during middleware.processRender
2020-12-21 09:59:19 -05:00
Julian Lam
05d8b3c339 chore: add deprecation notice to topic thumb tpl value 2020-12-21 09:59:19 -05:00
Julian Lam
da4f91186b fix: #9113, wrong path separator used in thumbs.get 2020-12-18 16:50:31 -05:00
Peter Jaszkowiak
2be396ff6e fix: email testing and settings change from ACP
- changing email SMTP settings wouldn't apply the first time
- "Send Test Email" now will report emailer errors in most cases
2020-12-18 16:39:09 -05:00
Julian Lam
713f029dc8 fix: removing ability to specify deprecated topic 'thumb' on topic creation 2020-12-18 15:25:37 -05:00
Julian Lam
600807fbe1 fix: don't return deleted: 0 for ephemeral groups 2020-12-18 14:01:41 -05:00
Julian Lam
438fa5c88f fix: send fewer items to client-side for ACP settings/email page 2020-12-18 14:01:41 -05:00
Julian Lam
878ee06715 refactor: schema backreference test to use map instead of reduce, properly check write-api routes 2020-12-18 14:01:41 -05:00
Barış Soner Uşaklı
a2152dd100 feat: update html-to-text closes https://github.com/NodeBB/NodeBB/pull/8810 2020-12-18 11:18:49 -05:00
Barış Soner Uşaklı
4404e32ed9 fix: #9117, lower query before search 2020-12-16 10:41:45 -05:00
Barış Soner Uşaklı
ab96f526d6 feat: remove max age since cache is cleared when thumbs change 2020-12-15 19:15:10 -05:00
Barış Soner Uşaklı
2d5a224b06 perf: don't load thumbs if disabled globally, cache thumb results 2020-12-14 21:24:46 -05:00
gasoved
d28581eb6a feat: show alt text instead of images in teasers (#9107)
* feat: show alt text instead of images in teasers

* refactor: from utils to local function
2020-12-14 14:24:48 -05:00
Barış Soner Uşaklı
8f938eba19 fix: #9074, fix svg uploads 2020-12-11 22:50:42 -05:00
Julian Lam
ab98740821 fix: #9100 topic thumbs in OG image tags 2020-12-11 15:38:40 -05:00
Julian Lam
74d73313fd feat: migration of old topic thumbs to new format
closes #9099
2020-12-11 15:00:20 -05:00
Julian Lam
378a3a6945 fix: update version removal comments to 1.17 for some features 2020-12-11 12:26:53 -05:00
Julian Lam
4c87f30184 feat: allow plugins to override ACP relogin challenge
- used in 2factor
2020-12-11 11:50:24 -05:00
Barış Soner Uşaklı
80de572aa1 feat: add user.email.confirmByUid for sso plugins 2020-12-10 20:25:48 -05:00
Julian Lam
05dd859714 fix: postgres is slow™️ 2020-12-09 19:23:23 -05:00
Julian Lam
9f62df15bd chore: appease codeclimate 2020-12-09 18:45:37 -05:00
Julian Lam
24e754d120 feat: add thumbs to category data return 2020-12-09 18:41:46 -05:00
Julian Lam
edf67f349f fix: use getSortedSetRange instead of getSortedSetsMembers 2020-12-09 17:12:59 -05:00
Julian Lam
bd5c4a5cff fix: tests 2020-12-09 16:46:19 -05:00
Julian Lam
e83baa97a0 fix: bad topic thumbs logic on local thumb upload 2020-12-09 16:30:11 -05:00
Julian Lam
3e54b70c06 fix: #9092, Topic thumbnails do not work with third-party uploaders 2020-12-09 15:47:58 -05:00
Julian Lam
2170c40007 fix: iteration logic bug 2020-12-09 10:42:41 -05:00
Julian Lam
9342d611be fix: enable topic thumbnails across the board [breaking] 2020-12-09 10:42:41 -05:00
Julian Lam
a30c8ab5c8 feat: clent-side modal for managing topic thumbs
closes #9087
2020-12-09 10:42:41 -05:00
Julian Lam
67cf5e83b7 fix: changes to thumb resizing logic
- Resized thumb no longer skews aspect ratio
- Thumbs resized down to maximum thumb size by WIDTH only
- image.checkDimensions() now returns dimensions
2020-12-09 10:42:41 -05:00
Julian Lam
37c367d6ff feat: raise maximum thumb size to 512 2020-12-09 10:42:41 -05:00
Julian Lam
1c5cdb5121 feat: associate topic thumbs with post uploads (for the mainPid) 2020-12-09 10:42:41 -05:00
Julian Lam
08736b1812 fix: use file lib instead of direct fs module access 2020-12-09 10:42:41 -05:00
Julian Lam
c043cfebd6 fix: added back missing topic thumb tests that were removed in last commit 2020-12-09 10:42:41 -05:00
Julian Lam
340387c18a fix: #9055, non-standard API response from addThumbs route
Also removed old thumb upload router handler, and updated uploadPost handling in composer to match new response schema
2020-12-09 10:42:41 -05:00
Julian Lam
c09c238e3f fix: do not allow thumb deletion route to arbitrarily delete other files in uploads folder 2020-12-09 10:42:41 -05:00
Julian Lam
5950683316 feat: closes #9048, tests for topic thumbs routes, write API schema 2020-12-09 10:42:41 -05:00
Julian Lam
4152aa552e feat: tests for topic thumbs
Also added some error checking to addThumbs controller
2020-12-09 10:42:41 -05:00
Julian Lam
ef7d6db912 feat: server-side work for #9047
- rename Thumbs.commit to Thumbs.migrate
- new PUT method that calls Thumbs.migrate
- `checkThumbPrivileges` now takes a single object parameter (ins. of req/res)
2020-12-09 10:42:41 -05:00
Julian Lam
b5d910f53b feat: core work for #9042, thumb deletion now accepts uuids
+ common data validation for thumb addition and deletion
2020-12-09 10:42:41 -05:00
Julian Lam
1f0c1cd229 fix: references to since-removed Topics.thumbs.resizeAndUpload 2020-12-09 10:42:41 -05:00
Julian Lam
90497e3ef5 feat: more work on topic thumbs refactor
- addThumb and deleteThumb are now protected routes (duh)
- new getThumbs route GET /api/v3/topics/<tid>/thumbs
- Updated `assert.path` middleware to better handle if relative paths are received with upload_url
- Slight refactor of thumbs lib to use validator to differentiate between tid and UUID
2020-12-09 10:42:41 -05:00
Julian Lam
43dc3e3e48 fix: #9041, remove Topics.thumbs.resizeAndUpload() 2020-12-09 10:42:41 -05:00
Julian Lam
708b1c338f fix: #9040 2020-12-09 10:42:41 -05:00
Julian Lam
1257aa981e feat: expose uploaded thumbnails to client-side via API
+ plugin hook: filter:topics.getThumbs
2020-12-09 10:42:41 -05:00
Julian Lam
7e9e08f718 feat: server-side routes for handling multiple topic thumbnails
closes #8994, requires 'topic-thumb-refactor' branch of composer-default
2020-12-09 10:42:41 -05:00
Julian Lam
98cd9e3549 feat: allow uploadThumb controller to be called in code
it, and uploadsController.upload() now return the results of their operation
2020-12-09 10:42:41 -05:00
Julian Lam
4fc9da81a9 refactor: topic thumbs lib to topics.thumbs 2020-12-09 10:42:41 -05:00
Barış Soner Uşaklı
0f480be658 fix: #9085, dont prevent admins from deleting other users 2020-12-09 10:15:30 -05:00
Julian Lam
efa4eca0fe fix: #9045, no post usage info if '/files/' path received 2020-12-08 08:58:19 -05:00