Commit Graph

571 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
69bb3293ee misc fixes
handle spider uids properly
2018-11-12 00:20:44 -05:00
Barış Soner Uşaklı
b6771836cf closes #6937 2018-11-10 20:51:07 -05:00
Julian Lam
a5022ce425 fix: #6922, skin assets not including plugin LESS files 2018-11-07 19:18:11 -05:00
renovate[bot]
64b9dabff8 chore(deps): update dependency eslint-config-airbnb-base to v13 (#6599)
* chore(deps): update dependency eslint-config-airbnb-base to v13

* chore: #6599, linting 😬
2018-11-07 15:53:14 -05:00
Julian Lam
501b3a79ca Refactor skins to be built on server-side (#6849)
* WIP

* using bootswatch from npm instead of bootswatch CDN url

* feat: on-demand client css building for skins

* added ability for client-side to select a skin

* updated loading and saving logic of bootstrapSkin on client side user settings

* fix: broken test for #6849
2018-11-07 13:44:35 -05:00
Julian Lam
84433f29ab Do not require a full refresh on login/logout (#6841)
* no-refresh login as well, plus lots of fixes for missing config on login

* replace config with new set on logout as well

* passing new payload data into new action:app.loggedIn hook, and old action:app.loggedOut hook

* fixed issues with socket.io not properly representing uid on server

* some light refactoring and cleanup

* minor cleanup, fixed spa logout not working after login

* have reconnection handler for socket.io wait 2s to confirm disconnection before reporting -- stops flicker if reconnecting immediately

* Dynamically replace chat and slideout menu on updateHeader()

... instead of just the menu items.

* more efficient calls to Benchpress and translator /cc @pitaj

* fix: chats and notification handlers not working after login

* fix: accidentally calling cb multiple times
2018-11-07 12:34:12 -05:00
Barış Soner Uşaklı
f3a679e268 remove parseInts 2018-10-25 17:02:59 -04:00
Barış Soner Uşaklı
9c022afae1 Parse int (#6853)
* Store config fields as JSON in the db

Fewer parseInts

* Remove unnecessary parseInts

* remove some dupe code add tests

* remove console.log

* remove more parseInts

* WIP: read meta.configs defaults from defaults.json

remove more parseInts

* more work

* add log for failing test

* update admin pwd

* fix tests, dont require posts/cache before configs are initialized

* handle saves

* Test boolean conditions

* remove more parseInts

* Fix boolean values

* remove lots more parseInts

* removed json parsing

* renamed var to number

* categories dont have timestamp
2018-10-21 16:47:51 -04:00
Barış Soner Uşaklı
26d4e0852f use includes instead of indexOf
use _.uniq instead of filter&indexOf
2018-10-20 14:40:48 -04:00
Barış Soner Uşaklı
702be3f6de https://github.com/NodeBB/nodebb-theme-persona/issues/363 2018-10-10 22:46:36 -04:00
Julian Lam
ebabcc5e3c if authenticate middleware is overridden by plugin, check for req.user and return notAllowed helper otherwise
/cc @LudwikJaniuk
2018-09-27 13:46:16 -04:00
Barış Soner Uşaklı
cf75c79611 Unread changes closes #6781 (#6783)
* WIP

* more unread work

* faster teaser block handling

if user doesn't have anyone blocked don't check

* much faster filtering of blocked posts

* add missing uid

* add tidsByFilter to return

* dont load all pids to find previous non-blocked teaser

* fix unread filters

they no longer use unread/new unread/watched etc they are query strings now

* shorter nav item code

* add unreplied to filters

fix icons not clearing to 0
dont increment unread counters if there is a reply in a topic where you ignored the topic creator
2018-09-24 12:58:59 -04:00
LudwikJaniuk
c7f3b76b4e DRY req props that depend on auth (fix #6727) (#6731)
* DRY req props that depend on auth (fix #6727)

authentication leads to req.loggedIn and req.uid being set. However, a
later authentication event might outdate them. Here, I create one
function for setting those properties, and make sure it also is called
on the `action:middleware.authenticate` hook, which would be such an
authentication event. If there are other places, those should be added
as well.

* fix lint errors

* fix lint error

* change exports
2018-09-04 09:43:33 -04:00
Julian Lam
3522ad0e05 Revert "closes #6664"
This reverts commit f27a0d252c.
2018-07-24 16:05:05 -04:00
Julian Lam
f27a0d252c closes #6664 2018-07-24 15:43:54 -04:00
Peter Jaszkowiak
04d31fe1d4 Precompile all templates
- Benchpress compilation is 33x faster now
- Native module with JS fallback and pre-built binaries
- Dev template build is <1sec now
- Minified template build is ~5sec (uglify accounts for almost all)
2018-07-15 00:12:37 -06:00
Barış Soner Uşaklı
85a55d1740 closes 2018-07-09 14:57:42 -04:00
Julian Lam
7a53fa9469 Added block and unblock button to profile dropdown menu, #6560 2018-07-05 14:20:33 -04:00
Barış Soner Uşaklı
5287c2ea08 #6554 2018-06-06 15:46:43 -04:00
Barış Soner Uşaklı
14f6e74bad closes #6556 2018-06-06 13:11:48 -04:00
Barış Soner Uşaklı
d5e85c2eb3 closes #6476, closes #6546 2018-06-02 15:54:32 -04:00
Barış Soner Uşaklı
d31d8fa806 move category pageview to controllers
so topic views are tracked as category views
2018-06-01 14:57:59 -04:00
Barış Soner Uşaklı
4f893d2aff closes #6535 2018-06-01 08:23:25 -04:00
Julian Lam
99f1a5380e closes #6483 2018-05-02 13:02:18 -04:00
Barış Soner Uşaklı
beadcd7857 fix tests, remove dupe exposeUid 2018-04-28 10:25:17 -04:00
Julian Lam
dc386b5b23 Merge branch 'master' into user-blocking 2018-04-27 15:58:04 -04:00
Julian Lam
bfee23adee basic methods and initial integration for #6463 2018-04-20 12:20:48 -04:00
Barış Soner Uşaklı
0070f5c1b2 Merge remote-tracking branch 'refs/remotes/origin/master' into develop 2018-04-05 12:34:38 -04:00
Barış Soner Uşaklı
e1df8bd0f0 closes #6390 2018-03-23 09:48:24 -04:00
Barış Soner Uşaklı
ae0f1847ae allow multiple origins for access-control-allow-origin header
add access-control-allow-credentials header to acp
2018-03-20 12:25:00 -04:00
Peter Jaszkowiak
eaae5b52cd ACP quick actions (#6374)
* ACP quick actions

- Moved restart, build & restart, and logout into separate buttons
- Moved buttons on mobile into the side menu
- Added version and upgrade alert to header / mobile menu
- Moved version checking to server-side with a cache for rate limiting
- Changed "reload" translations to "rebuild and restart"

* Change info alert to black-on-white to match focused search bar

* Fix tests

* Fallback for failed fetch of latest version
2018-03-20 08:32:17 -04:00
Baris Usakli
52ab0a00d9 use the acp config for homePageTitle 2018-03-12 13:24:16 -04:00
Barış Soner Uşaklı
245e1a9159 closes #6334 2018-02-28 16:32:39 -05:00
Barış Soner Uşaklı
5069892b97 pass correct uid to client side
-1 spider,0 guest, >0 regular user
2018-02-23 15:34:31 -05:00
Julian Lam
c25d752573 Merge remote-tracking branch 'origin/master' into develop 2018-02-23 14:48:38 -05:00
Julian Lam
98b0bdc7e1 added helmet for better standard of protection across the board 2018-02-21 14:13:29 -05:00
Julian Lam
7edc58b727 stricter Referrer-Policy to reduce unintended information leakage 2018-02-20 16:11:07 -05:00
Julian Lam
9a1f722a05 appending X-Upstream-Hostname header in dev mode 2018-02-20 14:51:41 -05:00
Barış Soner Uşaklı
c707e98423 closes #6331 2018-02-19 11:45:06 -05:00
Barış Soner Uşaklı
e36657d48c add tpl path to error messages 2018-02-19 11:17:15 -05:00
Julian Lam
1ce448f2a1 Merge remote-tracking branch 'origin/master' into develop 2018-02-16 21:23:25 -05:00
Barış Soner Uşaklı
575b70b5ab add some checks to templatesOnDemand 2018-02-14 16:29:33 -05:00
Barış Soner Uşaklı
379a156328 add status code to body 2018-02-13 14:49:30 -05:00
Barış Soner Uşaklı
7b6282f530 closes #6308 2018-02-12 17:12:24 -05:00
Barış Soner Uşaklı
d16667a5fb closes #6304 2018-02-05 10:04:19 -05:00
Barış Soner Uşaklı
ac1f7eefe5 closes #2304 2018-01-31 15:20:17 -05:00
Barış Soner Uşaklı
18ba08183c fix test 2018-01-26 19:26:48 -05:00
Baris Usakli
c090ec301b fix lint 2018-01-25 12:31:43 -05:00
Barış Soner Uşaklı
f7aa32cd05 dont crash if res.session.meta is not set 2018-01-25 09:16:08 -05:00
Barış Soner Uşaklı
ff6c6a54c1 make upload permissions global
give upload image permission to registered users on install
add global privileges to app.user.privileges for client side use
2018-01-03 13:27:34 -05:00