Commit Graph

2390 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
3a77e71443 lint: fix semicolon 2022-05-12 20:58:14 -04:00
Barış Soner Uşaklı
a583141252 feat: add button to see category children, closes #10606 2022-05-12 20:48:57 -04:00
Barış Soner Uşaklı
0e60a704a5 fix: 'unread' postIndex regression closes #10607 2022-05-12 11:33:11 -04:00
Julian Lam
0c19b1e57c feat: send back missing parameters as array of missing properties, in API response 2022-05-05 14:16:10 -04:00
Barış Soner Uşaklı
23175110a2 feat: post queue bulk actions closes #10520, fix #10555, 2022-04-30 19:07:49 -04:00
Barış Soner Uşaklı
d20b07cfea Webpack5 (#10311)
* feat: webpack 5 part 1

* fix: gruntfile fixes

* fix: fix taskbar warning

add app.importScript
copy public/src/modules to build folder

* refactor: remove commented old code

* feat: reenable admin

* fix: acp settings pages, fix sortable on manage categories

embedded require in html not allowed

* fix: bundle serialize/deserizeli so plugins dont break

* test: fixe util tests

* test: fix require path

* test: more test fixes

* test: require correct utils module

* test: require correct utils

* test: log stack

* test: fix db require blowing up tests

* test: move and disable bundle test

* refactor: add aliases

* test: disable testing route

* fix: move webpack modules necessary for build, into `dependencies`

* test: fix one more test

remove 500-embed.tpl

* fix: restore use of assets/nodebb.min.js, at least for now

* fix: remove unnecessary line break

* fix: point to proper ACP bundle

* test: maybe fix build test

* test: composer

* refactor: dont need dist

* refactor: more cleanup

use everything from build/public folder

* get rid of conditional import in app.js

* fix: ace

* refactor: cropper alias

* test: lint and test fixes

* lint: fix

* refactor: rename function to app.require

* refactor: go back to using app.require

* chore: use github branch

* chore: use webpack branch

* feat: webpack webinstaller

* feat: add chunkFile name with contenthash

* refactor: move hooks to top

* refactor: get rid of template500Function

* fix(deps): use webpack5 branch of 2factor plugin

* chore: tagging v2.0.0-beta.0 pre-release version 💥 :shipit: 🎉 🚀

* refactor: disable cache on templates

loadTemplate is called once by benchpress and the result is cache internally

* refactor: add server side helpers.js

* feat: deprecate /plugins shorthand route, closes #10343

* refactor: use build/public for webpack

* test: fix filename

* fix: more specific selector

* lint: ignore

* refactor: fix comments

* test: add debug for random failing test

* refactor: cleanup

remove test page, remove dupe functions in utils.common

* lint: use relative path  for now

* chore: bump prerelease version

* feat: add translateKeys

* fix: optional params

* fix: get rid of extra timeago files

* refactor: cleanup, require timeago locale earlier

remove translator.prepareDOM, it is in header.tpl html tag

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* feat: allow app.require('bootbox'/'benchpressjs')

* refactor: require server side utils

* test: jquery ready

* change istaller to use build/public

* test: use document.addEventListener

* refactor: closes #10301

* refactor: generateTopicClass

* fix: column counts for other privileges

* fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking]

* fix: typo in hook name

* refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags)

* fix: crash if `delay` not passed in (as it cannot be destructured)

* refactor: replace substr

* feat: set --panel-offset style in html element based on stored value in localStorage

* refactor: addDropupHandler() logic to be less naive

- Take into account height of the menu
- Don't apply dropUp logic if there's nothing in the dropdown
- Remove 'hidden' class (added by default in Persona for post tools) when menu items are added

closes #10423

* refactor: simplify utils.params [breaking]

Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do.

* feat: add support for returning full URLSearchParams for utils.params

* fix: utils.params() fallback handling

* fix: default empty obj for params()

* fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end

* fix: utils.params() not allowing relative paths to be passed in

* refactor(DRY): new assertPasswordValidity utils method

* fix: incorrect error message returned on insufficient privilege on flag edit

* fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate

- added failing tests and patched up middleware.assert.flags to fix

* refactor: flag api v3 tests to create new post and flags on every round

* fix: missing error:no-flag language key

* refactor: flags.canView to check flag existence, simplify middleware.assert.flag

* feat: flag deletion API endpoint, #10426

* feat: UI for flag deletion, closes #10426

* chore: update plugin versions

* chore: up emoji

* chore: update markdown

* chore: up emoji-android

* fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check

Co-authored-by: Julian Lam <julian@nodebb.org>
2022-04-29 21:39:33 -04:00
Barış Soner Uşaklı
e8058ca35c feat: add response:helpers.notAllowed 2022-04-04 17:34:52 -04:00
CommanderRoot
200f0b2e4f refactor: replace deprecated String.prototype.substr() (#10432)
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-03-31 13:49:56 -04:00
Julian Lam
38ca73c493 fix(security): explicitly declare cache-control header instead of using middleware
This commit reverts 1f6f389ff2
2022-03-18 11:56:16 -04:00
Julian Lam
1f6f389ff2 fix(security): cache-control on all pages using setupPageRoute or setupApiRoute, and 404 controllers.
This commit also reverts e39cdd490b
2022-03-17 21:42:26 -04:00
Barış Soner Uşaklı
7c946570d5 feat: on online users page override timeago cutoff to 24 hours 2022-03-11 23:42:46 -05:00
Barış Soner Uşaklı
be6bbabd0e feat: ability to mute users
new mute privilege
2022-03-11 23:07:20 -05:00
Barış Soner Uşaklı
371b46581a fix: #10366, remove dupe /files
dont display duplicate thumb og:image items
2022-03-07 18:44:31 -05:00
Barış Soner Uşaklı
56345777ce fix: always show self on /users?online 2022-03-04 13:28:54 -05:00
Barış Soner Uşaklı
21cd1e612f fix: db call 2022-03-03 18:16:24 -05:00
Barış Soner Uşaklı
cc665fd614 fix: lastonline timestamps and display for guests 2022-03-03 18:16:05 -05:00
Barış Soner Uşaklı
eac9cd03ca feat: closes #10324, show recently online users as well 2022-03-02 18:29:17 -05:00
Barış Soner Uşaklı
50ed3a324c test: possible fix random psql test failure 2022-03-02 17:51:07 -05:00
Barış Soner Uşaklı
7ee4e4e004 fix: #10357 2022-03-02 15:00:27 -05:00
Julian Lam
5479f36443 fix: #10358, bad uploads path 2022-03-02 11:41:15 -05:00
Barış Soner Uşaklı
58b5781cea feat: closes #10296
asset_base_url in nconf
keep assetBaseUrl in config for backwards compat
2022-02-15 19:22:34 -05:00
Julian Lam
5d7e1ebc68 style: linting errors 2022-02-14 15:02:07 -05:00
Julian Lam
6489e9fd9e refactor: change the post uploads' hash seeds to have the files/ prefix 2022-02-14 15:02:07 -05:00
Barış Soner Uşaklı
350052ec50 fix: language keys 2022-02-09 17:50:08 -05:00
Barış Soner Uşaklı
d70ce3a937 fix: #10273, properly calculate item count for best/controversial 2022-02-09 17:42:41 -05:00
Barış Soner Uşaklı
6be330f2d6 lint: remove unused require 2022-02-04 21:56:58 -05:00
Barış Soner Uşaklı
079c487dcb fix: controversial posts/bests posts not showing anything
fix upgrade script so posts with negative votes are stored, a post can have 10 upvotes and 2 downvotes
fix missing negative votes checks
remove unnecessary pids flters since the cids are only already filtered by topics:read
2022-02-04 21:52:44 -05:00
Julian Lam
5cff6e3f95 fix: bug where .reduce() exploded due to no initial value, if input value was an empty array 2022-02-04 14:33:58 -05:00
Julian Lam
5afd5de07d feat: new accounts route to show most downvoted ('controversial') posts 2022-02-04 14:33:58 -05:00
Julian Lam
ad63517511 fix: missing early return 2022-02-04 10:20:46 -05:00
Julian Lam
936562c3cb fix: handle case where email is explicitly passed into user.create, and thus is set in user hash, but confirmation request may have expired 2022-02-04 10:20:46 -05:00
Julian Lam
0322e984e0 fix: #10236, don't check email:uid, instead verify an email confirmation is active 2022-02-04 10:20:46 -05:00
Julian Lam
cf8f62aed9 feat: remove colors in favour of chalk (#10142)
* feat: remove colors in favour of chalk

* fix: bad conversion from colors to chalk in src/cli/index.js

* fix: padWidth calculation to account for control characters

* fix: termWidth calculation, but swapped one problem for another

* fix: formatItem, implement my own padRight to take control characters into account
2022-02-01 21:43:09 -05:00
Barış Soner Uşaklı
1d01741ae7 fix: #10208, don't use leading slash in directory names
change to use decodeURIComponent in utils.params
2022-01-30 18:51:28 -05:00
Barış Soner Uşaklı
2a89ad8288 fix: use escaped group names in invite modal 2022-01-27 16:00:01 -05:00
Julian Lam
d098e26f82 User Email and email validation API (#10160)
* feat: wip user emails api

* fix: allow admins with manage-users access to email confirmation api as well

* fix: wrong route path

* docs: openapi spec
2022-01-21 11:20:39 -05:00
Barış Soner Uşaklı
2835966518 fix: urls used when recent/unread/popular/top is used as the homepage
if recent is used as the homepage then changing the selected category or filters was redirecting the user to forum.com/recent?cid=1 instead of staying at forum.com/?cid=1

also fix unread page mark read button showing the selected category
2022-01-19 21:48:49 -05:00
Barış Soner Uşaklı
3e8cb732c5 fix: multiple cid filter on flags page
if multiple categories were selected it wasnt applied because of typeof string check
2022-01-19 20:30:31 -05:00
Julian Lam
31ea2266a6 feat: nicer error handling for bad jwt in unsubscribe template 2022-01-14 15:34:46 -05:00
Barış Soner Uşaklı
c9fabb0e1d refactor: add method to error messages 2022-01-14 14:34:08 -05:00
Julian Lam
e9ee843b27 fix: CSRF handler to go back to saving in session (#10159) 2022-01-14 13:38:24 -05:00
Julian Lam
2fe53cf849 feat: GET /api/v3/chats/:roomId/messages 2021-12-22 15:19:37 -05:00
Julian Lam
fe17c94c35 feat: DELETE /api/v3/chats/:roomId/users and DELETE /api/v3/chats/:roomId/users/:uid 2021-12-22 10:59:36 -05:00
Julian Lam
d62ee84637 feat: POST /chats/:roomId/users 2021-12-22 10:59:36 -05:00
Julian Lam
6eea6451d2 feat: GET /chats/:roomId/users [breaking] 2021-12-22 10:59:36 -05:00
Julian Lam
d5fd098ecf feat: POST /chats/:roomId/:mid and DELETE /chats/:roomId/:mid 2021-12-22 10:59:36 -05:00
Julian Lam
b292960594 feat: GET /chats/:roomId/:mid 2021-12-22 10:59:36 -05:00
Julian Lam
f48ed3658a feat: PUT /chats/:roomId/:mid 2021-12-22 10:59:36 -05:00
Julian Lam
9a4fd5dc7e feat: PUT /api/v3/chats/:roomId 2021-12-22 10:59:36 -05:00
Julian Lam
eeffb9d978 feat: POST /api/v3/chats/:roomId 2021-12-22 10:59:36 -05:00