1397 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
fc09f6c4f9 fix: escape flag filters 2025-05-12 11:00:38 -04:00
Barış Soner Uşaklı
7a26672872 fix: sql injection in sortedSetScan 2025-05-12 10:59:53 -04:00
Barış Soner Uşaklı
62e162cf1e fix: backport ws token fix 2023-05-15 11:55:18 -04:00
Barış Soner Uşaklı
de2669a2c6 fix: only remove deleted tag, closes #11515 2023-04-24 15:39:00 -04:00
Barış Soner Uşaklı
21fb8590e5 test: remove old comment 2023-04-23 18:59:18 -04:00
Veronikya
c931183287 fix: NodeBB#11482 thumbs Post Can not upload a thumbnail, only multip… (#11483)
* fix: NodeBB#11482 thumbs Post Can not upload a thumbnail, only multiple uploads

* Modify upload thumbnail test

* Modify upload thumbnail test +,

* Get rid of v2 uploads test

* edit times

* Modify amount of files associated post test

* edit post file amount
2023-04-15 17:56:36 -04:00
Barış Soner Uşaklı
e0b2065802 test: update socket.io test 2023-03-28 08:15:42 -04:00
Barış Soner Uşaklı
1aff9cad91 lint: fix arrow 2023-03-27 10:47:15 -04:00
Barış Soner Uşaklı
37b48b82a4 fix: don't crash if event name is not a string 2023-03-27 10:38:53 -04:00
Barış Soner Uşaklı
767c1d1faf fix: thumb remove on windows, closes #11357 2023-03-14 15:09:12 -04:00
Barış Soner Uşaklı
56427e4f9d fix: closes #11343, don't crash if tags array is empty 2023-03-10 11:40:02 -05:00
Julian Lam
1b29dbb69d test: add dummy emailer hook in authentication test 2023-02-13 12:15:45 -05:00
Barış Soner Uşaklı
845c8013b6 fix: #11259, clean old emails when updating via admin (#11260)
when admin is changing users emails check if its avaiable and remove old email of user first
upgrade script to cleanup email:uid, email:sorted, will remove entries if user doesn't exist or doesn't have email or if entry in user hash doesn't match entry in email:uid
fix missing ! in email interstitial
fix missing await in canSendValidation,
fix broken tests
dont pass sessionId to email.remove if admin is changing/removing email
2023-02-06 10:45:01 -05:00
Julian Lam
fecd84d1a0 revert: a788bd1344 2023-01-23 15:19:47 -05:00
Julian Lam
a788bd1344 revert: 9c250b78b0, fix: comment out broken test for now 2023-01-23 12:51:42 -05:00
Julian Lam
f295174e07 test: fix broken test 2023-01-23 09:58:51 -05:00
Julian Lam
459bc52338 fix: #11136, tests, and returning the proper number of arrays 2023-01-18 15:08:35 -05:00
Barış Soner Uşaklı
586eed1407 fix: vulnerability in socket.io nested namespaces (#11117) 2022-12-30 09:49:22 -05:00
Barış Soner Uşaklı
1ea9481af6 fix: lock post/reply similar to user.create 2022-12-25 15:05:15 -05:00
Barış Soner Uşaklı
c2bb2b30be test: dont try to load admin upload routes 2022-12-07 10:08:16 -05:00
Julian Lam
10ba7b9ced Merge branch 'master' into develop 2022-11-16 12:16:26 -05:00
Barış Soner Uşaklı
abcfb63126 fix: #11044, allow banned users to post
if given privileges
2022-11-15 17:53:15 -05:00
Barış Soner Uşaklı
3c85b944e3 feat: allow groups to be exempt from maintenance mode
closes #11030
2022-11-11 16:23:00 -05:00
Julian Lam
892ac2eb20 Merge branch 'master' into develop 2022-11-09 13:31:31 -05:00
Julian Lam
2f9d8c350e fix: pass csrf_token into calls to /register/abort, #11017 2022-11-09 13:20:28 -05:00
Julian Lam
97d8b53fd3 Merge branch 'master' into develop 2022-11-09 12:15:24 -05:00
Barış Soner Uşaklı
06d1539137 test: fix tests again 2022-10-29 17:40:33 -04:00
Barış Soner Uşaklı
c833d3cdc4 test: fix test 2022-10-29 17:05:16 -04:00
Julian Lam
96b46411b1 Merge branch 'master' into develop 2022-10-18 15:38:36 -04:00
Julian Lam
9c576a0758 Email confirmation QOL updates (#10987)
* breaking: remove `SocketUser.emailConfirm`, re: #10954

* chore: move email confirmation related configs to own section in Settings > Email

* feat: new user email method `getValidationExpiry`, returns expiration in ms.. probably.

* fix: bug where `user.email.isValidationPending` returned an u nexpected non-boolean value if there was no confirmation pending (only when checking email as well)

* fix: update getValidationExpiry to return ms

* test: use emailConfirmInterval for tests, for now

* fix: throw friendly error when attempting an email change within email confirmation window

* feat: new config option `emailConfirmExpiry` in days, governs how long the confirm link is good for

* test: additional tests for user email methods

* fix: add back missing handling of  option

* test: fix tests
2022-10-18 15:12:13 -04:00
Barış Soner Uşaklı
61d32bdebb fix: category ordering add test 2022-10-03 09:41:40 -04:00
Barış Soner Uşaklı
177d904812 fix: category ordering add test 2022-10-03 09:41:08 -04:00
Julian Lam
6391f77b01 Merge remote-tracking branch 'origin/master' into develop 2022-09-20 14:04:02 -04:00
Barış Soner Uşaklı
b5dd89e1c0 feat: store topic title and tags in diffs (#10900)
* feat: store topic title and tags in diffs

allow restoring post diff if tags didn't change

* test: fix tests, fast computer problems
2022-09-16 22:16:08 -04:00
Barış Soner Uşaklı
c039a699bd sharp test fix 2022-09-13 12:36:13 -04:00
Barış Soner Uşaklı
1c9c39a8c8 test: add back /admin/extend/plugins test 2022-09-04 19:42:12 -04:00
Barış Soner Uşaklı
b45e241390 lint: fix lint error 2022-09-04 10:36:57 -04:00
Barış Soner Uşaklı
1dc79d76a0 test: disable nbbpm test temporarily 2022-09-04 10:32:22 -04:00
Julian Lam
15b1561fd3 feat: introduce ACP defined option to rescind notif or do nothing on flag resolve/reject
/cc #10867
2022-08-26 16:05:45 -04:00
Julian Lam
b3b48fa62f Merge remote-tracking branch 'origin/master' into develop 2022-08-25 16:42:53 -04:00
Julian Lam
7c5a915dc9 test: have some build tests not pollute build folder 2022-08-23 11:23:49 -04:00
gasoved
b424ba4637 test: User.hidePrivateData 2022-08-22 13:47:33 -04:00
Julian Lam
c07d595662 Update to lru-cache@^7 (#10815)
* chore(deps): bump lru-cache from 6.0.0 to 7.13.1 in /install

Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 6.0.0 to 7.13.1.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-lru-cache/compare/v6.0.0...v7.13.1)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(lru-cache): remove unneeded `length` params for cache creation, as `maxSize` was not used in those init calls, also renamed some methods to match new method names in lru-cache [breaking]

Added deprecation notices for old params

* fix: replace three direct calls to lru-cache with call to cacheCreate, moved cache creation call in uploads to run on first init as config is not populated at lib init

* test: move configs init above cache reset calls in databasemock

* move some more code above cache clear

* refactor: remove unused

* test: lru

* test: more debug

* test: on more test

* use await helpers.uploadFile

* fix: tests remove logs

* fix: acp cache page

* fix: add in one more guard again cache instantiation with `length` prop but no `maxSize` prop

* fix(deps): bump markdown

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2022-08-10 13:24:16 -04:00
Julian Lam
59f3ae201a Merge remote-tracking branch 'origin/master' into develop 2022-08-10 09:52:49 -04:00
Barış Soner Uşaklı
961be70725 fix test on redis 2022-08-09 18:26:46 -04:00
Julian Lam
65c59cc16a test: additional tests for password challenge on email update 2022-08-05 14:39:36 -04:00
Julian Lam
8e1a4bb5df test: add dummy emailer hook to suppress sendmail error logging 2022-08-05 14:39:36 -04:00
Julian Lam
68bcd7f48e test: fix one last failing test 2022-08-05 14:39:36 -04:00
Julian Lam
342cca35c1 chore: re-order interstitial tests so email and gdpr tests are in sub-blocks 2022-08-05 14:39:36 -04:00
Julian Lam
9ee1afbb0f Merge branch 'master' into develop 2022-08-04 16:04:09 -04:00