Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-10 01:23:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: properly unregister hooks in emailer tests

Browse Source
This commit is contained in:
Julian Lam
2022-01-28 15:46:28 -05:00
parent dee9cca3c8
commit fc2c755c64
1 changed files with 24 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
test/emailer.js
View File

@@ -49,22 +49,23 @@ describe('emailer', () => {
it('plugin hook should work', (done) => {
const error = new Error();
const method = function (data, next) {
assert(data);
assert.equal(data.to, email);
assert.equal(data.subject, `[NodeBB] ${params.subject}`);
next(error);
};
Plugins.hooks.register('emailer-test', {
hook: 'filter:email.send',
method: function (data, next) {
assert(data);
assert.equal(data.to, email);
assert.equal(data.subject, `[NodeBB] ${params.subject}`);
next(error);
},
method,
});
Emailer.sendToEmail(template, email, language, params, (err) => {
assert.equal(err, error);
Plugins.hooks.unregister('emailer-test', 'filter:email.send');
Plugins.hooks.unregister('emailer-test', 'filter:email.send', method);
done();
});
});
@@ -152,37 +153,40 @@ describe('emailer', () => {
});
it('should not send email to a banned user', async () => {
const method = async () => {
assert(false); // if thrown, email was sent
};
Plugins.hooks.register('emailer-test', {
hook: 'filter:email.send',
method: async () => {
assert(false); // if thrown, email was sent
},
method,
});
await user.bans.ban(recipientUid);
await Emailer.send('test', recipientUid, {});
Plugins.hooks.unregister('emailer-test', 'filter:email.send');
Plugins.hooks.unregister('emailer-test', 'filter:email.send', method);
});
it('should return true if the template is "banned"', async () => {
const method = async () => {
assert(true); // if thrown, email was sent
};
Plugins.hooks.register('emailer-test', {
hook: 'filter:email.send',
method: async () => {
assert(true); // if thrown, email was sent
},
method,
});
await Emailer.send('banned', recipientUid, {});
Plugins.hooks.unregister('emailer-test', 'filter:email.send');
Plugins.hooks.unregister('emailer-test', 'filter:email.send', method);
});
it('should return true if system settings allow sending to banned users', async () => {
const method = async () => {
assert(true); // if thrown, email was sent
};
Plugins.hooks.register('emailer-test', {
hook: 'filter:email.send',
method: async () => {
assert(true); // if thrown, email was sent
},
method,
});
meta.config.sendEmailToBanned = 1;
@@ -190,7 +194,7 @@ describe('emailer', () => {
meta.config.sendEmailToBanned = 0;
await user.bans.unban(recipientUid);
Plugins.hooks.unregister('emailer-test', 'filter:email.send');
Plugins.hooks.unregister('emailer-test', 'filter:email.send', method);
});
});
});