From fad0d2fbb45fc48212f10d489f2e4fcac07c6587 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Mon, 24 Mar 2025 14:15:37 -0400 Subject: [PATCH] fix: tag whitelist check socket call for remote categories --- src/socket.io/topics/tags.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/socket.io/topics/tags.js b/src/socket.io/topics/tags.js index ebcbfd405a..e0cf1a1075 100644 --- a/src/socket.io/topics/tags.js +++ b/src/socket.io/topics/tags.js @@ -9,13 +9,13 @@ const utils = require('../../utils'); module.exports = function (SocketTopics) { SocketTopics.isTagAllowed = async function (socket, data) { - if (!data || !utils.isNumber(data.cid) || !data.tag) { + if (!data || !data.tag) { throw new Error('[[error:invalid-data]]'); } const systemTags = (meta.config.systemTags || '').split(','); const [tagWhitelist, isPrivileged] = await Promise.all([ - categories.getTagWhitelist([data.cid]), + utils.isNumber(data.cid) ? categories.getTagWhitelist([data.cid]) : [], user.isPrivileged(socket.uid), ]); return isPrivileged ||