Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-20 03:11:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: make a single round trip for set(s)Remove

Browse Source 
use bulkWrite
This commit is contained in:
Barış Soner Uşaklı
2026-03-09 18:33:24 -04:00
parent 92fcdd09ca
commit f6f51f83c4
3 changed files with 33 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/database/mongo/sets.js
View File

@@ -94,44 +94,31 @@ module.exports = function (module) {
}; };
module.setRemove = async function (key, value) { module.setRemove = async function (key, value) {
if (!Array.isArray(value)) { await bulkSetRemove(key, value);
value = [value];
}
value = value.map(v => helpers.valueToString(v));
const coll = module.client.collection('objects');
await coll.updateMany({
_key: Array.isArray(key) ? { $in: key } : key,
}, {
$pullAll: { members: value },
});
await coll.deleteMany({
_key: Array.isArray(key) ? { $in: key } : key,
members: { $size: 0 },
});
}; };
module.setsRemove = async function (keys, value) { module.setsRemove = async function (keys, value) {
if (!Array.isArray(keys) || !keys.length) { if (!Array.isArray(keys) || !keys.length) {
return; return;
} }
value = helpers.valueToString(value); await bulkSetRemove(keys, value);
const coll = module.client.collection('objects');
await coll.updateMany({
_key: { $in: keys },
}, {
$pull: { members: value },
});
await coll.deleteMany({
_key: { $in: keys },
members: { $size: 0 },
});
}; };
async function bulkSetRemove(key, values) {
const isKeyArray = Array.isArray(key);
if (!key || (isKeyArray && !key.length)) return;
const filterKey = isKeyArray ? { $in: key } : key;
const update = Array.isArray(values) ?
{ $pullAll: { members: values.map(helpers.valueToString) } } :
{ $pull: { members: helpers.valueToString(values) } };
await module.client.collection('objects').bulkWrite([
{ updateMany: { filter: { _key: filterKey }, update: update } },
{ deleteMany: { filter: { _key: filterKey, members: { $size: 0 } } } },
], { ordered: true });
}
module.isSetMember = async function (key, value) { module.isSetMember = async function (key, value) {
if (!key) { if (!key) {
return false; return false;

3
src/database/redis/sets.js
View File

@@ -57,6 +57,9 @@ module.exports = function (module) {
}; };
module.setsRemove = async function (keys, value) { module.setsRemove = async function (keys, value) {
if (!Array.isArray(keys) || !keys.length) {
return;
}
const batch = module.client.batch(); const batch = module.client.batch();
keys.forEach(k => batch.sRem(String(k), String(value))); keys.forEach(k => batch.sRem(String(k), String(value)));
await helpers.execBatch(batch); await helpers.execBatch(batch);

25
test/database/sets.js
View File

@@ -278,20 +278,21 @@ describe('Set methods', () => {
}); });
describe('setsRemove()', () => { describe('setsRemove()', () => {
before((done) => { it('should remove a element from multiple sets', async () => {
db.setsAdd(['set1', 'set2'], 'value', done); await db.setsAdd(['set1', 'set2'], 'value');
await db.setRemove(['set1', 'set2'], 'value');
const members = await db.isMemberOfSets(['set1', 'set2'], 'value');
assert.deepStrictEqual(members, [false, false]);
}); });
it('should remove a element from multiple sets', (done) => { it('should remove the sets if they are empty', async () => {
db.setsRemove(['set1', 'set2'], 'value', function (err) { await db.setAdd('setsRemoveSet3', ['a']);
assert.equal(err, null); await db.setAdd('setsRemoveSet4', ['a']);
assert.equal(arguments.length, 1); await db.setsRemove(['setsRemoveSet3', 'setsRemoveSet4'], 'a');
db.isMemberOfSets(['set1', 'set2'], 'value', (err, members) => { assert.deepStrictEqual(
assert.equal(err, null); await db.exists(['setsRemoveSet3', 'setsRemoveSet4']),
assert.deepEqual(members, [false, false]); [false, false]
done(); );
});
});
}); });
}); });