Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-03-06 20:41:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: update logic so that purging a post does not remove toPid fields from children, updated addParentPosts so that post existence is checked

Browse Source
This commit is contained in:
Julian Lam
2025-10-29 14:49:53 -04:00
parent 728184dab6
commit f6219d0026
2 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/posts/delete.js
View File

@@ -197,20 +197,15 @@ module.exports = function (Posts) {
} }
async function deleteFromReplies(postData) { async function deleteFromReplies(postData) {
const arrayOfReplyPids = await db.getSortedSetsMembers(postData.map(p => `pid:${p.pid}:replies`)); // Any replies to deleted posts will retain toPid reference (gh#13527)
const allReplyPids = _.flatten(arrayOfReplyPids); await db.deleteAll(postData.map(p => `pid:${p.pid}:replies`));
const promises = [
db.deleteObjectFields(
allReplyPids.map(pid => `post:${pid}`), ['toPid']
),
db.deleteAll(postData.map(p => `pid:${p.pid}:replies`)),
];
// Remove post(s) from parents' replies zsets
const postsWithParents = postData.filter(p => parseInt(p.toPid, 10)); const postsWithParents = postData.filter(p => parseInt(p.toPid, 10));
const bulkRemove = postsWithParents.map(p => [`pid:${p.toPid}:replies`, p.pid]); const bulkRemove = postsWithParents.map(p => [`pid:${p.toPid}:replies`, p.pid]);
promises.push(db.sortedSetRemoveBulk(bulkRemove)); await db.sortedSetRemoveBulk(bulkRemove);
await Promise.all(promises);
// Recalculate reply count
const parentPids = _.uniq(postsWithParents.map(p => p.toPid)); const parentPids = _.uniq(postsWithParents.map(p => p.toPid));
const counts = await db.sortedSetsCard(parentPids.map(pid => `pid:${pid}:replies`)); const counts = await db.sortedSetsCard(parentPids.map(pid => `pid:${pid}:replies`));
await db.setObjectBulk(parentPids.map((pid, index) => [`post:${pid}`, { replies: counts[index] }])); await db.setObjectBulk(parentPids.map((pid, index) => [`post:${pid}`, { replies: counts[index] }]));

3
src/topics/posts.js
View File

@@ -184,6 +184,9 @@ module.exports = function (Topics) {
.filter(p => p && p.hasOwnProperty('toPid') && (activitypub.helpers.isUri(p.toPid) || utils.isNumber(p.toPid))) .filter(p => p && p.hasOwnProperty('toPid') && (activitypub.helpers.isUri(p.toPid) || utils.isNumber(p.toPid)))
.map(postObj => postObj.toPid); .map(postObj => postObj.toPid);
const exists = await posts.exists(parentPids);
parentPids = parentPids.filter((_, idx) => exists[idx]);
if (!parentPids.length) { if (!parentPids.length) {
return; return;
} }