From f449fafccfcf95c6021c72f54845b72e0f54bc66 Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Thu, 14 Nov 2024 15:07:42 -0500
Subject: [PATCH] fix: don't chop off colons when generating titles as they
 could interfere with emoji

---
 src/activitypub/helpers.js | 3 ---
 test/activitypub.js        | 5 +----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/activitypub/helpers.js b/src/activitypub/helpers.js
index 5165a9c166..9a311c7dd4 100644
--- a/src/activitypub/helpers.js
+++ b/src/activitypub/helpers.js
@@ -343,9 +343,6 @@ Helpers.generateTitle = (html) => {
 		title = sentences.shift();
 	}
 
-	// Trim certain punctuation marks
-	title = title.trim().replace(/[:]$/, '');
-
 	// Truncate down if too long
 	if (title.length > meta.config.maximumTitleLength) {
 		title = `${title.slice(0, meta.config.maximumTitleLength - 3)}...`;
diff --git a/test/activitypub.js b/test/activitypub.js
index 44557e0656..c470ca74ef 100644
--- a/test/activitypub.js
+++ b/test/activitypub.js
@@ -127,11 +127,8 @@ describe('ActivityPub integration', () => {
 					// other sentence ending symbols
 					['Lorem ipsum dolor sit amet, consectetur adipiscing elit? Etiam a ex pellentesque, fringilla lorem non, blandit est. Nulla facilisi. Curabitur cursus neque vel enim semper, id lacinia elit facilisis. Vestibulum turpis orci, efficitur ut semper eu, faucibus eu turpis. Praesent eu odio non libero gravida tempor. Ut porta pellentesque orci. In porta nunc eget tincidunt interdum. Curabitur vel dui nec libero tempus porttitor. Phasellus tincidunt, diam id viverra suscipit, est diam maximus purus, in vestibulum dui ligula vel libero. Sed tempus finibus ante, sit amet consequat magna facilisis eget. Proin ullamcorper, velit sit amet feugiat varius, massa sem aliquam dui, non aliquam augue velit vel est. Phasellus eu sapien in purus feugiat scelerisque congue id velit. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos.', 'Lorem ipsum dolor sit amet, consectetur adipiscing elit?'],
 
-					// should trim non-sentence-ending punctuation
-					['<span>one two three:</span><p>four five six</p>', 'one two three'],
-
 					// Content after line breaks can be discarded
-					['<p>Intro text<br /><a href=\"https://example.org/\">example.org/</span></a></p><p>more text</p>', 'Intro text'],
+					['<p>Intro text<br /><a href="https://example.org/">example.org/</span></a></p><p>more text</p>', 'Intro text'],
 
 					// HTML without outer wrapping element
 					['Lorem ipsum dolor <span>sit amet</span>', 'Lorem ipsum dolor sit amet'],