From f20c12ee40807b0a33acb2c4bb2a4a16f21e07db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Soner=20U=C5=9Fakl=C4=B1?= Date: Tue, 24 Nov 2020 14:37:54 -0500 Subject: [PATCH] fix: add client side check for userslug #8939 --- public/src/client/register.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/public/src/client/register.js b/public/src/client/register.js index 26096c29e1..8010835c86 100644 --- a/public/src/client/register.js +++ b/public/src/client/register.js @@ -151,12 +151,12 @@ define('forum/register', [ callback = callback || function () {}; var username_notify = $('#username-notify'); - - if (username.length < ajaxify.data.minimumUsernameLength) { + var userslug = slugify(username); + if (username.length < ajaxify.data.minimumUsernameLength || userslug.length < ajaxify.data.minimumUsernameLength) { showError(username_notify, '[[error:username-too-short]]'); } else if (username.length > ajaxify.data.maximumUsernameLength) { showError(username_notify, '[[error:username-too-long]]'); - } else if (!utils.isUserNameValid(username) || !slugify(username)) { + } else if (!utils.isUserNameValid(username) || !userslug) { showError(username_notify, '[[error:invalid-username]]'); } else { Promise.allSettled([