Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-07-15 02:42:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: emailer.send and emailer.sendToEmail returns Boolean based on message being successfully sent

Browse Source 
Note that of course this doesn't mean the message was _delivered_, just sent off.

This will stop issues where emailer errors crash NodeBB
This commit is contained in:
Julian Lam
2022-01-28 15:01:55 -05:00
parent 680e36da67
commit f0e32ff182
2 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/emailer.js
View File

@@ -45,7 +45,7 @@ describe('emailer', () => {
// TODO: test sendmail here at some point
it('plugin hook should work', (done) => {
it('plugin hook should work', async () => {
const error = new Error();
Plugins.hooks.register('emailer-test', {
@@ -59,12 +59,10 @@ describe('emailer', () => {
},
});
Emailer.sendToEmail(template, email, language, params, (err) => {
assert.equal(err, error);
const success = await Emailer.sendToEmail(template, email, language, params);
assert.strictEqual(success, false);
Plugins.hooks.unregister('emailer-test', 'filter:email.send');
done();
});
Plugins.hooks.unregister('emailer-test', 'filter:email.send');
});
it('should build custom template on config change', (done) => {